>>>>> "Maxime" == Maxime Ripard writes:
Maxime> Use the devm_kzalloc managed function to stripdown the error and remove
Maxime> code.
Maxime> Signed-off-by: Maxime Ripard
Besides the comment of Jean -
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaar
>>>>> "Maxin" == Maxin B John writes:
Maxin> Fixes the wrong filename.
Maxin> Signed-off-by: Maxin B. John
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a
>>>>> "Maxin" == Maxin B John writes:
Maxin> This drops a few lines of code and allows common APIs to handle
Maxin> those for us.
Maxin> Signed-off-by: Maxin B. John
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: se
>>>>> "Maxin" == Maxin B John writes:
Maxin> Hi Peter,
Maxin> This drops a few lines of code and allows common APIs to handle
Maxin> those for us.
Maxin> Signed-off-by: Maxin B. John
>> Acked-by: Peter Korsgaard
Maxin> Is there any upda
}
MR> dev_info(&pdev->dev, "%d port mux on %s adapter\n",
MR> -pdata->n_values, parent->name);
MR> -
MR> - platform_set_drvdata(pdev, mux);
MR> + mux->data->n_values, parent->name);
MR> return 0;
MR> add_ada
at internally
Andreas> still uses platform_get_resource.
I have no idea why sparc is being odd in this regard, but assuming this
is how it's done, I'm fine with this change.
A quick grep doesn't find any other drivers doing this though:
git grep -l archdata.irqs drivers | xargs grep platform_ge
c-ocores.c
Andreas> +++ b/drivers/i2c/busses/i2c-ocores.c
Andreas> @@ -4,6 +4,9 @@
Andreas> *
Andreas> * Peter Korsgaard
Andreas> *
Andreas> + * Support for the GRLIB port of the controller by
Andreas> + * Andreas Larsson
Andreas> + *
Andreas> * This file
e mux is already allocated using kcalloc, we don't need to
MR> do it for data as well. I will remove it.
Ok, great.
--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
DISCLAIMER:
Unless indicated otherwise, the information contained in this message is
privil
forms that
Andreas> have ioread/write32, but not ioread/write32be are frv and mn10300. Do
Andreas> you know if those platforms are using i2c-ocores?
Not to my knowledge, no. In that case:
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line &q
dev)
MR> +{
MR> + struct device_node *np = pdev->dev.of_node;
MR> + struct device_node *adapter_np, *child;
MR> + struct i2c_adapter *adapter;
MR> + unsigned *values, *gpios;
MR> + int i = 0;
MR> +
MR> + if (!np)
MR> + return 0;
This sh
/ TYPE_GRLIB) and a 2nd of_device_id
entry with .data = TYPE_GRLIB, and then using that in the probe routine
would be nicer. Have a look at i2c-at91.c for an example of a driver
doing something like that.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>> example of a driver doing something like that.
Andreas> Yes, that is a good idea. Do you think casting to and from
Andreas> void * in the following solution is too ugly and rather have a
Andreas> struct pointed to, or do you think that would be unnecessary?
I find the castin
; +
Andreas> + match = of_match_node(ocores_i2c_match, pdev->dev.of_node);
Andreas> + if (match)
Andreas> + return (int)match->data;
Can this ever fail? If not, you might as well do the of_match_node
inline in the probe instead of this helper.
Other than t
could even move to a single ops
structure), so it would be shorter to assign them at the same time:
if (!i2c->setreg || !i2c->getreg) {
switch (i2c->reg_io_width) {
case 1:
i2c->setreg = oc_setreg_8;
i2c->getreg = oc_getreg_8;
break;
case 2:
om
Andreas> grlib functions by setting the setreg and getreg function
Andreas> pointers.
Andreas> Signed-off-by: Andreas Larsson
Acked-by: Peter Korsgaard
Thanks!
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a mes
gt; defined.
Andreas> Signed-off-by: Andreas Larsson
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "BP" == Bill Pemberton writes:
BP> CONFIG_HOTPLUG is going away as an option. As result the __dev*
BP> markings will be going away.
BP> Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
BP> and __devexit.
BP> Signed-off-by:
>>>>> "Bill" == Bill Pemberton writes:
Bill> CONFIG_HOTPLUG is going away as an option. As result the __dev*
Bill> markings will be going away.
Bill> Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
Bill> and __devexit.
Acked
by casting the pointer to long.
I've CC'ed Andreas who made the change.
Acked-by: Peter Korsgaard
Jayachandran> Signed-off-by: Jayachandran C
Jayachandran> ---
Jayachandran> drivers/i2c/busses/i2c-ocores.c |2 +-
Jayachandran> 1 file changed, 1 insertion(+), 1 delet
>>>>> "JD" == Jean Delvare writes:
JD> gpio_direction_output() may fail, check for that and deal with it
JD> appropriately. Also log an error message if gpio_request() fails.
JD> Signed-off-by: Jean Delvare
JD> Cc: Peter Korsgaard
JD> Cc: Wolfram Sang
t; -#else
>> -#define OCORES_I2C_PM NULL
>> -#endif
>>
>> static struct platform_driver ocores_i2c_driver = {
>> .probe = ocores_i2c_probe,
>> @@ -490,7 +487,7 @@ static struct platform_driver ocores_i2c_driver = {
>> .owner = THIS_MODULE,
>>>>> "JD" == Jean Delvare writes:
JD> gpio_direction_output() may fail, check for that and deal with it
JD> appropriately. Also log an error message if gpio_request() fails.
JD> Signed-off-by: Jean Delvare
JD> Cc: Peter Korsgaard
JD> Cc: Wolfram Sang
master is supported"?
Also there's a typo: s/use the claim/use to claim/
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
another error code. This error should be passed further
IN> instead of being ignored.
Two different fixes, so should be 2 separate patches. Other that that,
it looks good.
Acked-by: Peter Korsgaard
--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is sub
>>>>> "IN" == Ionut Nicu writes:
IN> If the i2c-parent bus driver is not loaded, returning
IN> -EINVAL will force people to unload and then reload the
IN> module again to get it working.
IN> Signed-off-by: Ionut Nicu
Acked-by: Peter Korsgaard
--
So
>>>>> "IN" == Ionut Nicu writes:
IN> of_get_named_gpio could return -E_PROBE_DEFER or another
IN> error code. This error should be passed further instead
IN> of being ignored.
Acked-by: Peter Korsgaard
--
Sorry about disclaimer - It's out of my contro
>>
>> Signed-off-by: Ionut Nicu
WS> Doesn't the non-DT case need fixing, too?
Arguably yes.
--
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL
DISCLAIMER<http://www.barco.com/en/maildisclaimer>
--
To unsubscribe from this list:
>>>>> "IN" == Ionut Nicu writes:
IN> If the i2c-parent bus driver is not loaded, returning
IN> -ENODEV will force people to unload and then reload the
IN> module again to get it working.
IN> Signed-off-by: Ionut Nicu
Acked-by: Peter Korsgaard
--
So
ta.n_gpios; i++)
IN> - gpio_set_value(mux->gpio_base + mux->data.gpios[i],
IN> - val & (1 << i));
IN> + gpio_set_value_cansleep(mux->gpio_base + mux->data.gpios[i],
IN> + val & (1 << i
>>>>> "Wolfram" == Wolfram Sang writes:
> Warn users that class based instantiation is going away soon in favour
> of more robust probing and faster bootup times.
> Signed-off-by: Wolfram Sang
> Cc: Peter Korsgaard
> ---
> This patch is a su
>>>>> "Jingoo" == Jingoo Han writes:
> Make of_device_id array const, because all OF functions
> handle it as const.
> Signed-off-by: Jingoo Han
Acked-by: Peter Korsgaard
> ---
> drivers/i2c/busses/i2c-ocores.c |2 +-
> 1 file chan
by: Jingoo Han
> Acked-by: Peter Korsgaard
> Acked-by: Maxime Coquelin
> ---
> Changes since v1:
> - squashed all patches into a single patch
> - added acked-by
--
By, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body
eak after some time.
> Signed-off-by: Wolfram Sang
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Max" == Max Filippov writes:
> Allow bus clock specification as a common clock handle. This makes this
> controller easier to use in a setup based on common clock framework.
> Signed-off-by: Max Filippov
Looks sensible to me - Thanks.
Acked-by
the value of
> the clock assigned to this platform_device?
> The usual thing to do when 'clock-frequency' is not set is to default to
> 100kHz.
The confusion comes from the fact that the device tree bindings uses
clock-frequency for the clock frequency of the IP core and NOT for
the history, the device tree patch originally used a
custom "clock_khz" property until some guy told him to use
clock-frequency ;)
https://lists.ozlabs.org/pipermail/devicetree-discuss/2010-November/003650.html
As far as I can see I wasn't CC'ed on that patch.
--
Bye, Peter Korsgaa
From: Peter Korsgaard
Add an i2c mux driver providing virtual i2c busses using a hardware MUX
sitting on a master bus and controlled through gpio pins.
E.G. something like:
-- -- Virtual bus 1 - - - - -
| | SCL/SDA
From: Peter Korsgaard
Add an i2c mux driver providing virtual i2c busses using a hardware MUX
sitting on a master bus and controlled through gpio pins.
E.G. something like:
-- -- Virtual bus 1 - - - - -
| | SCL/SDA
>>>>> "Jean" == Jean Delvare writes:
Jean> Hi Peter,
Jean> Sorry and the late answer.
Thanks for the feedback, see below for a few comments.
>> +++ b/Documentation/i2c/busses/i2c-gpiomux
>> @@ -0,0 +1,65 @@
>> +Kernel driv
| || |---| |
-- -- - - - - -
SCL/SDA of the master I2C bus is multiplexed to virtual bus 1..M
according to the settings of the GPIO pins 1..N.
Signed-off-by: Peter Korsgaard
---
Changes since v2:
- Adjust according to Jean&#
gpiomux_values,
>> + .n_values = ARRAY_SIZE(myboard_gpiomux_values),
>> + .gpio = myboard_gpiomux_gpios,
Jean> .gpios
>> + .gpios = ARRAY_SIZE(myboard_gpiomux_gpios),
Jean> .n_gpios
Ups, fixed.
>> +GENERIC GPIO I2C MULTIPLEXER DRIVER
| || |---| |
-- -- - - - - -
SCL/SDA of the master I2C bus is multiplexed to bus segment 1..M
according to the settings of the GPIO pins 1..N.
Signed-off-by: Peter Korsgaard
---
Changes since v3:
- Adjust according to
should I resend the patch?
>> + if (pdata->idle != GPIO_I2CMUX_NO_IDLE)
>> + deselect = gpiomux_deselect;
We could probably move this up and add the assignment of init_state to
this contional, instead of testing against GPIO_I2CMUX_NO_IDLE twice.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
driver, however, has
Jonas> been upstream for a while so I guess we're stuck with it.
Yes, it was more or less the best name I could come with. Just calling
it i2c.c wouldn't have been any good either.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsu
akefile before
muxes, but alternatively you could play with the init order (E.G. use
subsys_initcall instead of module_init in the bus driver, see
b8680784875 for an example).
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a
For V2 I will move the register field defines from i2c-ocores.c to
Jan> i2c-ocores.h and include that file in the new driver - unless anyone
Jan> objects.
Ben, do you really think that's worthwhile? It's just 6 registers with a
few bits in 3 of them.
--
Bye, Peter Korsgaard
--
To u
and register a platform device
for gpio-i2cmux which you then forcibly unregister in the i801 remove
handler without providing a release() function on the platform device?
That's afaik wrong as the platform_device might be in use (E.G. someone
has the sysfs entry open or similar, and you need to use
o a patch adding a i2c_clock_khz member to
ocores_i2c_platform_data as long as it doesn't break existing boards
(E.G. 0 should get handled as 100Khz).
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-EIO;
>> - else
>> + else {
>> + printk(KERN_NOTICE
WARNING seems more suitable here.
>> + "ocores_xfer() i2c transfer to %d-%#x timed out\n",
>> + i2c_adapter_id(adap), msgs->addr);
>> + i2c->msg = 0; /* remove the caller's request which
>> will be re-used */
>> return -ETIMEDOUT;
>> + }
>> }
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Axel" == Axel Lin writes:
Axel> This patch converts the drivers in drivers/i2c/* to use the
Axel> module_platform_driver() macro which makes the code smaller and a bit
Axel> simpler.
Axel> Cc: Jean Delvare
Axel> Cc: Ben Dooks
Axel> Cc: J
t i2c-gpiomux.c, and renamed it to gpio-i2cmux.c on
request of you.
I don't mind the new name though, so:
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ed. If we were to rename it we should also rename struct
gpio_i2cmux_platform_data.
I don't feel strongly about it - It will break for existing users, but
there's probably not too many of those. Your call.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line &quo
>>>>> "AL" == Axel Lin writes:
AL> This patch converts gpio-i2cmux to use the module_platform_driver() macro
which
AL> makes the code smaller and a bit simpler.
AL> Signed-off-by: Axel Lin
Acked-by: Peter Korsgaard
--
Sorry about disclaimer - It's
gt; It *is* on my todo-list, though...
>>
>> Any news on this?
Wolfram> Well, it is still on my list :/ (I wouldn't mind if someone is
Wolfram> faster than me)
I'll be away for the next 2 weeks, but will do it afterwards if nobody
beats me to it (and I don't for
ram> of EXPERIMENTAL should do for this.
Agreed.
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "JD" == Jean Delvare writes:
JD> Align the name of i2c-mux-gpio's data structure on the new driver name.
JD> Also change one define and adjust function names, even if they aren't
JD> part of the public interface, for consistency.
JD> Signe
>>>>> "JD" == Jean Delvare writes:
JD> Update the MAINTAINERS entry and all other references accordingly.
JD> Based on an original patch by Wolfram Sang.
JD> Signed-off-by: Jean Delvare
JD> Acked-by: Peter Korsgaard
JD> Cc: Wolfram Sang
JD> ---
EXPERIMENTAL for this driver from Kconfig.
And also please consider CC'ing the maintainer on patches (E.G. me) - I
didn't notice this before now.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
this change to the dt bindings, instead of risking
breaking stuff for platform drivers as well? There's no conceptual
reason why reg_shift is any better than regstep.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
thout problems.
I afaik even posted an example driver back when Dave posted his
multiplex hack.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
is by making sure the multiplexer starts in
an unconnected state so the trunk probe doesn't find anything, or
simply not use the old style probing.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel
posted his
>> multiplex hack.
Rodolfo> Did you post the code on this list?
Yes, but notice that it was for a multiplexer NOT controlled over I2C.
http://www.mail-archive.com/i...@lm-sensors.org/msg01539.html
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line
arent mutex
enable mux
do transfer on parent bus
disable mux
unlock parent
So that afaik shouldn't be a problem.
If your mux doesn't have an enable control and there's no unused
connection you can use instead, then that ofcourse doesn't work.
--
Bye, Peter Korsgaard
--
To
gh something else (in this case a
sram-like bus on a fpga).
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ch.
I guess Wolfram referred to the context line which was clearly word wrapped:
@@ -456,17 +456,22 @@ static int mpc_xfer(struct i2c_adapter *adap,
struct i2c_msg *msgs, int num)
The other lines look fine.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubsc
abs.org/pipermail/linuxppc-dev/2009-May/072274.html
Please consider using git send-email for patches.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
i2c_add_adapter(&i2c->adap);
+ ret = i2c_add_numbered_adapter(&i2c->adap);
if (ret) {
dev_err(&pdev->dev, "Failed to add adapter\n");
goto add_adapter_failed;
Or am I misunderstanding the issue?
--
Bye, Peter Korsgaard
--
on is the pass a list of I2C devices in the
Richard> platform data to the Open Cores driver. This is useful for
Richard> MFD drivers.
Richard> Signed-off-by: Richard Röjfors
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscrib
s3c24xx_i2c_init() was overwriting the IICLC value set just above in
s3c24xx_i2c_clockrate() with zero, effectively disabling the platform
line control setting.
Signed-off-by: Peter Korsgaard
---
drivers/i2c/busses/i2c-s3c2410.c |5 -
1 files changed, 0 insertions(+), 5 deletions
>>>>> "Peter" == Peter Korsgaard writes:
Peter> s3c24xx_i2c_init() was overwriting the IICLC value set just
Peter> above in s3c24xx_i2c_clockrate() with zero, effectively
Peter> disabling the platform line control setting.
ping?
--
Bye, Peter Korsgaar
> msleep() here, then I'd be interested to know.
I'll test on my 6410 board over the weekend. Notice that I've been
hacking on the uboot drivers/i2c/s3c24x0_i2c.c file to add s3c64xx
support, and I there had to add a udelay before setting the start
condition to get it to work stable
>>>>> "Joakim" == Joakim Tjernlund writes:
Hi,
Joakim> Ah, that explains it. Who then will look after i2c-mpc? Kumar?
Ben Dooks (embedded i2c maintainer). He's afaik coming home today, so
give him a few days to catch up on mails.
--
Bye, Peter Korsgaard
directories) easily go stale when reorganizing the tree.
Exactly, that's normally frowned upon in other parts of the tree.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
| || |---| |
-- -- - - - - -
SCL/SDA of the master I2C bus is multiplexed to virtual bus 1..M
according to the settings of the GPIO pins 1..N.
Signed-off-by: Peter Korsgaard
---
Documentation/i2c/busses/i2c-gpiomux | 65
>>>>> "Peter" == Peter Korsgaard writes:
Peter> Add an i2c bus driver providing virtual i2c busses using a hardware
Peter> MUX sitting on a master bus and controlled through gpio pins.
Peter> E.G. something like:
Peter> -- ---
merged (which is scheduled to happen in kernel 2.6.36.)
But this patch is independent from that work as the mux access isn't
through I2C, hence no changes to i2c-core needed.
Do you want me to resend or do you still have the original patch?
--
Bye, Peter Korsgaard
--
To unsubscribe from t
lm-sensors.org/msg01539.html
None of the locking changes in core are needed when the MUX isn't
controlled through I2C. I guess I could use the i2c-mux.c functions, as
there's some overlap in the trivial gpiomux_xfer/gpiomux_func functions,
but that can easily be done once the mux stuff is merge
Your scenario fits perfectly.
Hmm, I'll take a closer look at the last version then - sorry. In the
past it afaik did. What is the point of the i2c-core changes if path
control isn't via i2c?
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-
d in the logs
IN> without these error prints.
IN> This patch changes the error messages from these deferral cases
IN> to debug messages.
IN> Signed-off-by: Ionut Nicu
Acked-by: Peter Korsgaard
--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This me
message when a driver
>> requests probe deferral, so this can be traced in the logs
>> without these error prints.
>>
>> This patch removes the error messages for these deferral cases.
>>
>> Signed-off-by: Ionut Nicu
AS> Acked-by: Alexander Sverdlin
Acked-by:
Changes v1->v2:
> - expand changelog with motivation for the change.
You should also document the big-endian property in
Documentation/devicetree/bindings/i2c/i2c-ocores.txt, otherwise it looks
good.
With that added:
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from th
re common properties documented
> in the Documentation/devicetree/bindings/common-properties.txt
Ok, then it looks good to me.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Hans" == Hans de Goede writes:
> According to the datasheets to n factor for dividing the tclk is
s/to/the/
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@
from the
mfd_cell). Make sure you set the .id member to something unique.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
== -1.
Please make sure you use unique ids when you have more than 1 device
instance on your system.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ss
> pointers).
As the serial number is available on a separate i2c address, wouldn't
it be simpler to handle these as special (read only) device variants and
instantiate E.G. a 24c64 (for the normal data) and a 24cs64 (for the
serial)?
--
Bye, Peter Korsgaard
--
To unsubscribe from thi
t; both memory blocks share the same address pointer.
> I'll resend the series.
But we're protected by the i2c bus lock, right? You do a single
i2c_transfer to read the serial number.
--
Venlig hilsen,
Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubsc
my bad. It needs to be fixed as
>> > both memory blocks share the same address pointer.
>>
>> > I'll resend the series.
>>
>> But we're protected by the i2c bus lock, right? You do a single
>> i2c_transfer to read the serial number.
> Wh
88 matches
Mail list logo
