Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

2015-08-09 Thread Robert Jarzmik
Vaibhav Hiremath writes: > Robert, > > It would be helpful if you can test this patch-series and confirm that > it now fixes the NULL pointer deference issue. Tested, it works on pxa27x in master mode, in non-DT mode. For all non-DT patches, you can add my : Tested-by: Robert Jarz

Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

2015-08-05 Thread Robert Jarzmik
Vaibhav Hiremath writes: > Robert, > > It would be helpful if you can test this patch-series and confirm that > it now fixes the NULL pointer deference issue. > > Thanks, > Vaibhav Hi Vaibhav, My next slot is probably this comming Sunday. I'll do the test and report. Cheers. -- Robert -- To u

Re: [PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family

2015-07-20 Thread Robert Jarzmik
Vaibhav Hiremath writes: > On Monday 20 July 2015 12:39 PM, Vaibhav Hiremath wrote: >> >> >> On Monday 20 July 2015 12:36 PM, Vaibhav Hiremath wrote: >>> >>> >>> On Saturday 18 July 2015 01:19 AM, Robert Jarzmik wrote: >>>> Vaibhav Hi

Re: [PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family

2015-07-17 Thread Robert Jarzmik
Vaibhav Hiremath writes: >> So, I applied patches 1-6 to for-next to make some progress. >> >> The others need more thought because of the bindings which shall be >> discussed replying to the patches in question. >> >> Thanks for the updated work with lots of proper references. >> > > OK, Thanks

Re: [PATCH-V2 03/12] i2c: pxa: Return I2C_RETRY when timeout in pio mode

2015-07-03 Thread Robert Jarzmik
off-by: Vaibhav Hiremath Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH-V2 02/12] i2c: pxa: No need to set slave addr for i2c master mode reset

2015-07-03 Thread Robert Jarzmik
hav Hiremath > Cc: Wolfram Sang Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH-V2 08/12] i2c: pxa: enable/disable i2c module across msg xfer

2015-07-03 Thread Robert Jarzmik
Vaibhav Hiremath writes: > I have taken care of all comments on the 3 patches. > > Just in case if you have any comments on other patches in series, > I will wait for a day before pushing next version. That would be great, yeah. I'll make another pass tomorrow. If that works for you, and if you

Re: [PATCH-V2 07/12] i2c:pxa: Use devm_ variants in probe function

2015-07-03 Thread Robert Jarzmik
rr(&dev->dev, "failed to get the clk: %ld\n", PTR_ERR(i2c->clk)); Once that is done, you can add my : Acked-by: Robert Jarzmik -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH-V2 08/12] i2c: pxa: enable/disable i2c module across msg xfer

2015-07-03 Thread Robert Jarzmik
Vaibhav Hiremath writes: > #define _IBMR(i2c) ((i2c)->reg_ibmr) > @@ -286,6 +287,22 @@ static void i2c_pxa_scream_blue_murder(struct pxa_i2c > *i2c, const char *why) > static void i2c_pxa_master_complete(struct pxa_i2c *i2c, int ret); > static irqreturn_t i2c_pxa_handler(int this_irq, void

Re: [PATCH-V2 11/12] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

2015-07-03 Thread Robert Jarzmik
Vaibhav Hiremath writes: > + i2c->clk = devm_clk_get(&dev->dev, NULL); > + if (IS_ERR(i2c->clk)) { > + dev_err(&dev->dev, "failed to get the clk\n"); > + dev_err(&dev->dev, "failed to get the clk: %ld\n", > PTR_ERR(i2c->clk)); > + return PTR_ERR(i2c->

Re: [PATCH-V2 04/12] i2c: pxa: Reset i2c controller on timeout in interrupt and pio mode

2015-07-03 Thread Robert Jarzmik
Vaibhav Hiremath writes: > In case of timeout during msg xfer assert reset to > i2c controller for both interrupt and PIO mode of operation. > > Signed-off-by: Jett.Zhou > [vaibhav.hirem...@linaro.org: Split & merge patches into logical changes > and update the Changelog] > Signed-off-by: Vaibha

Re: [PATCH 11/12] i2c:pxa: Use devm_ variants in probe function

2015-05-30 Thread Robert Jarzmik
Vaibhav Hiremath writes: > @@ -1270,10 +1270,17 @@ static int i2c_pxa_probe(struct platform_device *dev) > struct resource *res = NULL; > int ret, irq; > > - i2c = kzalloc(sizeof(struct pxa_i2c), GFP_KERNEL); > + i2c = devm_kzalloc(&dev->dev, sizeof(struct pxa_i2c), GFP_KERN

Re: [PATCH 10/12] i2c: pxa: Update debug function to dump more info on error

2015-05-29 Thread Robert Jarzmik
Vaibhav Hiremath writes: > Update i2c_pxa_scream_blue_murder() fn to print more information > in case of error. > > Signed-off-by: Jett.Zhou > [vaibhav.hirem...@linaro.org: Split patches into logical changes > and update the Changelog] > Signed-off-by: Vaibhav Hiremath > Cc: Wolfram Sang > > S

Re: [PATCH 09/12] i2c: pxa: Remove compile warnning in 64bit mode

2015-05-29 Thread Robert Jarzmik
bhav.hirem...@linaro.org: Updated Changelog] > Signed-off-by: Vaibhav Hiremath > Cc: Wolfram Sang Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [PATCH 07/12] i2c: pxa: Reset i2c controller on timeout in interrupt and pio mode

2015-05-29 Thread Robert Jarzmik
Vaibhav Hiremath writes: > In case of timeout during msg xfer assert reset to > i2c controller for both interrupt and PIO mode of operation. > > Signed-off-by: Jett.Zhou > [vaibhav.hirem...@linaro.org: Split & merge patches into logical changes > and update the Changelog] > Signed-off-by: Vaibha

Re: [PATCH 06/12] i2c: pxa: Return I2C_RETRY when timeout in pio mode

2015-05-29 Thread Robert Jarzmik
Vaibhav Hiremath writes: > From: Shouming Wang > > In case of timeout in pio mode of operation return I2C_RETRY. > This behavior will be same as interrupt mode of operation. > > Signed-off-by: Shouming Wang > [vaibhav.hirem...@linaro.org: Updated changelog] > Signed-off-by: Vaibhav Hiremath >

Re: [PATCH 05/12] i2c: pxa: Add bus reset functionality

2015-05-29 Thread Robert Jarzmik
Vaibhav Hiremath writes: > From: Rob Herring > > Since there is some problematic i2c slave devices on some > platforms such as dkb (sometimes), it will drop down sda > and make i2c bus hang, at that time, it need to config > scl/sda into gpio to simulate "stop" sequence to recover > i2c bus, so

Re: [PATCH 04/12] i2c: pxa: Add support for pxa910/988 & new configuration features

2015-05-29 Thread Robert Jarzmik
Vaibhav Hiremath writes: > @@ -167,6 +184,8 @@ struct pxa_i2c { > #define _ICR(i2c)((i2c)->reg_icr) > #define _ISR(i2c)((i2c)->reg_isr) > #define _ISAR(i2c) ((i2c)->reg_isar) > +#define _ILCR(i2c) ((i2c)->reg_ilcr) > +#define _IWCR(i2c) ((i2c)->reg_iwcr) > > /* > * I2C Slave

Re: [PATCH 03/12] i2c: pxa: Add reset operation when i2c bus busy

2015-05-29 Thread Robert Jarzmik
Vaibhav Hiremath writes: > From: "Jett.Zhou" > > According to some test in emei_dkb, we found some i2c slave device > (eg. camera sensor ov2659 power up) introduce noise on sda, so detect > i2c controller busy, and assert reset to i2c controller to recover as > early as possible to avoid more la

Re: [PATCH 02/12] i2c: pxa: No need to set slave addr for i2c master mode reset

2015-05-29 Thread Robert Jarzmik
Vaibhav Hiremath writes: > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c > index f4ac8c5..d4c798a 100644 > --- a/drivers/i2c/busses/i2c-pxa.c > +++ b/drivers/i2c/busses/i2c-pxa.c > @@ -459,8 +459,10 @@ static void i2c_pxa_reset(struct pxa_i2c *i2c) > writel(I2C_IS

Re: [PATCH v2 15/17] ARM: pxa: poodle: don't preallocate IRQ space for locomo

2015-04-28 Thread Robert Jarzmik
Dmitry Eremin-Solenikov writes: > As new locomo driver supports SPARSE_IRQ, don't preallocate NR_IRQS > space for it on poodle. > > Signed-off-by: Dmitry Eremin-Solenikov Acked-by: Robert Jarzmik -- Robert -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH v2 14/17] ARM: pxa: poodle: use new LoCoMo driver

2015-04-28 Thread Robert Jarzmik
Dmitry Eremin-Solenikov writes: > -#define POODLE_LOCOMO_GPIO_AMP_ON LOCOMO_GPIO(8) > -#define POODLE_LOCOMO_GPIO_MUTE_L LOCOMO_GPIO(10) > -#define POODLE_LOCOMO_GPIO_MUTE_R LOCOMO_GPIO(11) > -#define POODLE_LOCOMO_GPIO_232VCC_ON LOCOMO_GPIO(12) > -#define POODLE_LOCOMO_GPIO_JK_B

Re: [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp

2014-11-17 Thread Robert Jarzmik
Dmitry Eremin-Solenikov writes: > Change clk_enable/disable() calls to clk_prepare_enable() and > clk_disable_unprepare(). > > Signed-off-by: Dmitry Eremin-Solenikov > --- > drivers/usb/gadget/udc/pxa25x_udc.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/driv

I2C pxa regression

2009-03-08 Thread Robert Jarzmik
Hi, In linux-next, the commit named "i2c: Add missing KERN_* constants to printks", id 77130fc992cfdcce8c0a748a2daef16fc16e76bb, breaks compilation for pxa architectures. I think that hunk should be amended : > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c > index bdb1