Re: [PATCH v2 0/9] i2c: add generic support for timing parameters in DT

2015-12-14 Thread Simon Horman
On Mon, Dec 14, 2015 at 11:00:26AM +0100, Wolfram Sang wrote: > On Tue, Dec 08, 2015 at 10:37:44AM +0100, Wolfram Sang wrote: > > Here is a patch series adding better DT support for timing parameters like > > the > > raise time or the fall time which are generic for the I2C subsystem. There > > i

Re: [PATCH v2 0/9] i2c: add generic support for timing parameters in DT

2015-12-09 Thread Simon Horman
On Tue, Dec 08, 2015 at 10:37:44AM +0100, Wolfram Sang wrote: > Here is a patch series adding better DT support for timing parameters like the > raise time or the fall time which are generic for the I2C subsystem. There is > a > core function for parsing and an implementation for the RCar driver h

Re: [PATCH 0/9] i2c: add generic support for timing parameters in DT

2015-12-06 Thread Simon Horman
On Thu, Dec 03, 2015 at 04:51:30PM +0100, Wolfram Sang wrote: > Here is a patch series adding better DT support for timing parameters like the > raise time or the fall time which are generic for the I2C subsystem. There is > a > core function for parsing and an implementation for the RCar driver h

Re: [RFT 1/2] i2c: rcar: add support for r8a7795 (R-Car H3)

2015-08-05 Thread Simon Horman
On Wed, Aug 05, 2015 at 03:18:25PM +0200, Wolfram Sang wrote: > From: Wolfram Sang > > Enable the I2C core for this SoC. I add a new type because this version > has new features (e.g. DMA) which will be added somewhen later. Minor nit: s/somewhen/sometime/ or: s/somewhen // > Signed-off-by: Wol

Re: [PATCH v2 0/5] enable I2C on Renesas EMEV2 and KZM9D board

2015-07-14 Thread Simon Horman
On Tue, Jul 14, 2015 at 01:18:58PM +0200, Wolfram Sang wrote: > On Sat, Jul 11, 2015 at 09:46:21AM +0200, Wolfram Sang wrote: > > So, I picked up the old series from Ian and reworked it significantly. While > > his series was already an improvement from the driver found in the BSP, it > > was > >

Re: [PATCH 0/2] ARM: shmobile: r8a7740: move I2C errata handling into the driver

2015-06-10 Thread Simon Horman
need the > workaround at all, only some revisions of the r8a7740 are affected. > > After a short discussion with Simon, we agreed this should go via I2C. Acked-by: Simon Horman > > Wolfram Sang (2): > i2c: sh_mobile: add errata workaround > ARM: shmobile: r8a77

Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-05-21 Thread Simon Horman
adi,adxl346 and adi,adxl345, > in that order. > > Signed-off-by: Laurent Pinchart > Acked-by: Wolfram Sang > Signed-off-by: Geert Uytterhoeven > --- > v2: > - Add Acked-by. Reviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-05-21 Thread Simon Horman
ewed-by: Wolfram Sang > Signed-off-by: Geert Uytterhoeven > --- > v2: > - Add Reviewed-by. Reviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC] i2c: rcar: Fix order of restart and clear status

2015-03-29 Thread Simon Horman
On Fri, Mar 27, 2015 at 02:10:45PM +0100, Wolfram Sang wrote: > On Sat, Mar 07, 2015 at 11:33:49AM +0100, Wolfram Sang wrote: > > On Fri, Mar 06, 2015 at 11:05:31PM +0100, Wolfram Sang wrote: > > > > > > > I asked Kataoka-san about this and his response was as follows: > > > > > > Thanks, Simon!

Re: [PATCH/RFC] i2c: rcar: Support ACK by HW auto restart after NACK

2015-03-27 Thread Simon Horman
Hi Wolfram, On Fri, Mar 27, 2015 at 02:11:04PM +0100, Wolfram Sang wrote: > On Fri, Mar 06, 2015 at 11:18:09PM +0100, Wolfram Sang wrote: > > > > > > >Even if R-Car I2C received NACK, after that it might receive ACK > > > > >by HW auto restart. In case of that, driver would continue process. > >

Re: [PATCH/RFC] i2c: rcar: Fix order of restart and clear status

2015-03-03 Thread Simon Horman
Hi Wolfram, On Mon, Feb 23, 2015 at 02:07:18PM +0100, Wolfram Sang wrote: > Hi, > > On 2015-02-15 15:43, Yoshihiro Kaneko wrote: > >From: Ryo Kataoka > > > >In case of repeated START condition, the restart has to be kicked > >before clear status (MSR register). If it is kicked after clear status

Re: [PATCH/RFC] i2c: rcar: Support ACK by HW auto restart after NACK

2015-03-03 Thread Simon Horman
Hi Wolfram, On Mon, Feb 23, 2015 at 02:08:42PM +0100, Wolfram Sang wrote: > Hi, > > On 2015-02-15 15:44, Yoshihiro Kaneko wrote: > >From: Ryo Kataoka > > > >Even if R-Car I2C received NACK, after that it might receive ACK > >by HW auto restart. In case of that, driver would continue process. > >

Re: [PATCH 3/4] ARM: shmobile: koelsch: Add DA9063 PMIC device node for system restart

2014-12-21 Thread Simon Horman
On Tue, Dec 09, 2014 at 12:22:48PM +0100, Geert Uytterhoeven wrote: > Add a minimal device node for the DA9063 PMIC, which is connected to i2c6. > This allows the system to be restarted when the watchdog timer times > out, or when a system restart is requested. > > Regulator support is not yet inc

Re: [PATCH 0/4] ARM: shmobile: koelsch: Add DA9063 watchdog restart support

2014-12-10 Thread Simon Horman
On Wed, Dec 10, 2014 at 11:06:25AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Dec 10, 2014 at 1:33 AM, Simon Horman wrote: > > On Tue, Dec 09, 2014 at 12:22:45PM +0100, Geert Uytterhoeven wrote: > >> This patch series add restart support for r8a

Re: [PATCH 0/4] ARM: shmobile: koelsch: Add DA9063 watchdog restart support

2014-12-09 Thread Simon Horman
On Tue, Dec 09, 2014 at 12:22:45PM +0100, Geert Uytterhoeven wrote: > Hi Wim, Wolfram, Simon, Magnus, > > This patch series add restart support for r8a7791/koelsch through the watchdog > in the DA9063 PMIC. Restart can be triggered in two ways: > 1. Timeout of the watchdog timer, > 2. Ma

Re: [PATCH 3/5] i2c: sh_mobile: improve success message

2014-11-12 Thread Simon Horman
On Wed, Nov 12, 2014 at 05:12:19PM +0100, Wolfram Sang wrote: > On Fri, Nov 07, 2014 at 11:11:42AM +0100, Wolfram Sang wrote: > > From: Wolfram Sang > > > > No user needs magic hex values, makes this debug output. Add DMA info. > > > > Signed-off-by: Wolfram Sang > > Applied to for-next, thank

Re: [PATCH 5/5] ARM: shmobile: r8a7791: add DMA nodes for IIC

2014-11-12 Thread Simon Horman
On Fri, Nov 07, 2014 at 11:11:44AM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > Signed-off-by: Wolfram Sang > Acked-by: Laurent Pinchart > Acked-by: Geert Uytterhoeven Thanks, I have queued this up. > --- > arch/arm/boot/dts/r8a7791.dtsi | 6 ++ > 1 file changed, 6 insertions(+)

Re: [PATCH 4/5] ARM: shmobile: r8a7790: add DMA nodes for IIC

2014-11-12 Thread Simon Horman
On Fri, Nov 07, 2014 at 11:11:43AM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > Signed-off-by: Wolfram Sang > Acked-by: Laurent Pinchart > Acked-by: Geert Uytterhoeven Thanks, I have queued this up. > --- > arch/arm/boot/dts/r8a7790.dtsi | 8 > 1 file changed, 8 insertions(+

Re: [PATCH 1/5] ARM: shmobile: kzm9g legacy: Set i2c clks_per_count to 2

2014-11-12 Thread Simon Horman
On Wed, Nov 12, 2014 at 09:55:58AM +0100, Geert Uytterhoeven wrote: > On Wed, Nov 12, 2014 at 9:53 AM, Geert Uytterhoeven > wrote: > >> i2c_shmobile support.") in v2.6.37. > >> > >> Without this fix i2c may not operate correctly on the sh73a0/kzm9g. > > > > Thanks, that's correct. > > git tag

Re: [PATCH 1/5] ARM: shmobile: kzm9g legacy: Set i2c clks_per_count to 2

2014-11-12 Thread Simon Horman
On Wed, Nov 12, 2014 at 09:53:27AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Nov 12, 2014 at 2:44 AM, Simon Horman wrote: > > On Fri, Nov 07, 2014 at 06:24:21AM +0100, Wolfram Sang wrote: > >> On Thu, Nov 06, 2014 at 12:52:06PM +0100, Geert Uytterhoeven

Re: [PATCH 1/5] ARM: shmobile: kzm9g legacy: Set i2c clks_per_count to 2

2014-11-11 Thread Simon Horman
On Fri, Nov 07, 2014 at 06:24:21AM +0100, Wolfram Sang wrote: > On Thu, Nov 06, 2014 at 12:52:06PM +0100, Geert Uytterhoeven wrote: > > On sh73a0/kzm9g-legacy, probing of the i2c masters fails with: > > > > i2c-sh_mobile i2c-sh_mobile.0: timing values out of range: > > L/H=0x208/0x1bf > >

Re: [PATCH 3/5] i2c: sh_mobile: Document SoC-specific bindings

2014-11-09 Thread Simon Horman
On Fri, Nov 07, 2014 at 06:53:48PM +0100, Wolfram Sang wrote: > On Thu, Nov 06, 2014 at 12:52:08PM +0100, Geert Uytterhoeven wrote: > > Explicitly list the various SoC-specific compatible properties. > > This allows checkpatch to validate DTSes. > > > > Signed-off-by: Geert Uytterhoeven > > Appl

Re: [PATCH 5/5] ARM: shmobile: r8a73a4 dtsi: Add SoC-specific IIC compatible properties

2014-11-09 Thread Simon Horman
On Fri, Nov 07, 2014 at 06:26:16AM +0100, Wolfram Sang wrote: > On Thu, Nov 06, 2014 at 12:52:10PM +0100, Geert Uytterhoeven wrote: > > The IIC nodes used the generic compatible properties only. > > This may cause the driver to fail when using Standard Speed on IIC > > masters where the operational

Re: [PATCH 4/5] ARM: shmobile: sh73a0 dtsi: Add SoC-specific IIC compatible properties

2014-11-09 Thread Simon Horman
On Fri, Nov 07, 2014 at 06:25:33AM +0100, Wolfram Sang wrote: > On Thu, Nov 06, 2014 at 12:52:09PM +0100, Geert Uytterhoeven wrote: > > The IIC nodes used the generic compatible properties only. > > This causes the driver to fail when using Standard Speed, as the > > operational clock is driven by

Re: [PATCH 1/5] ARM: shmobile: kzm9g legacy: Set i2c clks_per_count to 2

2014-11-09 Thread Simon Horman
On Fri, Nov 07, 2014 at 06:24:21AM +0100, Wolfram Sang wrote: > On Thu, Nov 06, 2014 at 12:52:06PM +0100, Geert Uytterhoeven wrote: > > On sh73a0/kzm9g-legacy, probing of the i2c masters fails with: > > > > i2c-sh_mobile i2c-sh_mobile.0: timing values out of range: > > L/H=0x208/0x1bf > >

Re: [PATCH 3/5] i2c: sh_mobile: Document SoC-specific bindings

2014-11-06 Thread Simon Horman
On Thu, Nov 06, 2014 at 12:52:08PM +0100, Geert Uytterhoeven wrote: > Explicitly list the various SoC-specific compatible properties. > This allows checkpatch to validate DTSes. > > Signed-off-by: Geert Uytterhoeven Acked-by: Simon Horman > --- > Documentation/devicetre

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-09-21 Thread Simon Horman
On Fri, Sep 19, 2014 at 07:18:51PM +0200, Wolfram Sang wrote: > > > This approach has no effect to current feature, > > and can keep compatible for current and future, > > and can reduce / cleanup driver in the future. > > I defer the patch series for now. Maybe we should talk about it at our > n

Re: [PATCH] ARM: shmobile: koelsch: Remove non-existent i2c6 pinmux

2014-08-13 Thread Simon Horman
On Tue, Aug 12, 2014 at 03:48:12PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, Aug 12, 2014 at 3:36 PM, Simon Horman wrote: > > On Tue, Aug 12, 2014 at 03:03:13PM +0200, Geert Uytterhoeven wrote: > >> On r8a7791, i2c6 (aka iic3) doesn't need pinmux, bu

Re: [PATCH] ARM: shmobile: koelsch: Remove non-existent i2c6 pinmux

2014-08-12 Thread Simon Horman
On Tue, Aug 12, 2014 at 03:03:13PM +0200, Geert Uytterhoeven wrote: > On r8a7791, i2c6 (aka iic3) doesn't need pinmux, but the koelsch dts > refers to non-existent pinmux configuration data: > > pinmux core: sh-pfc does not support function i2c6 > sh-pfc e606.pfc: invalid function i2c6 in map

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Simon Horman
On Wed, Aug 06, 2014 at 05:36:37PM -0700, Kuninori Morimoto wrote: > > Hi Simon > > > > From: Kuninori Morimoto > > > > > > This patch adds DT compatible for Renesas R-Car Gen1/Gen2. > > > Current driver has SoC level .compatible > > > (r8a7778/r8a7779/r8a7790/r8a7791/r8a7792/r8a7793/r8a7794),

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Simon Horman
On Tue, Aug 05, 2014 at 09:40:12PM -0700, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch adds DT compatible for Renesas R-Car Gen1/Gen2. > Current driver has SoC level .compatible > (r8a7778/r8a7779/r8a7790/r8a7791/r8a7792/r8a7793/r8a7794), > but these can be match as generatio

Re: [PATCH V2 3/5] arm: shmobile: r7s72100: add nodes for i2c controllers to dtsi

2014-01-05 Thread Simon Horman
On Fri, Dec 27, 2013 at 05:27:47AM +0100, Wolfram Sang wrote: > On Wed, Dec 18, 2013 at 10:31:59PM +0100, Wolfram Sang wrote: > > From: Wolfram Sang > > > > I decided to put the pinmuxing into the dtsi file since there is only > > one pinmux posiibility which one probably wants to have when using

Re: [PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-26 Thread Simon Horman
On Thu, Dec 26, 2013 at 10:51:34PM +0100, Geert Uytterhoeven wrote: > On Thu, Dec 26, 2013 at 10:34 PM, Geert Uytterhoeven > wrote: > >>> Note that after dropping these lines: > >>> > >>>CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]), > >>>CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clk

Re: [PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-23 Thread Simon Horman
On Wed, Dec 18, 2013 at 10:31:58PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > Tested with RIIC2 on a genmai board. Others untested but hopefully > trivial enough to be added. > > Signed-off-by: Wolfram Sang > Acked-by: Magnus Damm > --- > > V2: adapt to established sorting Thanks. T

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Simon Horman
On Wed, Dec 18, 2013 at 01:15:42PM +0100, Wolfram Sang wrote: > > On Wed, Dec 18, 2013 at 03:53:45PM +0400, Sergei Shtylyov wrote: > > On 18-12-2013 15:43, Wolfram Sang wrote: > > > > >>>@@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = { > > >>> CLKDEV_CON_ID("mtu2_fck", &mstp_cl

Re: [PATCH 1/2] I2C: EMMA Mobile I2C master driver

2013-12-10 Thread Simon Horman
On Fri, Dec 06, 2013 at 08:52:38PM +, Ian Molton wrote: > On 25/09/13 05:45, Simon Horman wrote: > > >Hi Ian, > > > >I spoke with Magnus and in turn Ben about this at LinuxCon in New Orleans > >last week. > > > >Basically the position of Magnus and

Re: [PATCH 01/15] i2c: shmobile/rcar: Restrict non-COMPILE_TEST compilation

2013-11-27 Thread Simon Horman
rg > Signed-off-by: Laurent Pinchart Acked-by: Simon Horman > --- > drivers/i2c/busses/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 3b26129..92bdcf9 100644 > --- a/

Re: [PATCH 06/12] i2c: sh_mobile: Convert to clk_prepare/unprepare

2013-10-28 Thread Simon Horman
On Tue, Oct 29, 2013 at 06:02:24AM +0100, Wolfram Sang wrote: > On Mon, Oct 28, 2013 at 11:49:23PM +0100, Laurent Pinchart wrote: > > Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and > > clk_disable_unprepare() to get ready for the migration to the common > > clock framework.

Re: [PATCH resend] i2c: rcar: fixup rcar type naming

2013-10-28 Thread Simon Horman
t added naming was H1/H2 instead of Gen1/Gen2. > Gen1/Gen2 is better naming on this driver. > > Signed-off-by: Kuninori Morimoto Thanks Morimoto-san, this looks good to me. Acked-by: Simon Horman Wolfram, please consider applying this change. > --- > resend > - exchanged Wo

Re: [PATCH 1/2] I2C: EMMA Mobile I2C master driver

2013-09-24 Thread Simon Horman
On Thu, Sep 05, 2013 at 03:04:29PM +0900, Simon Horman wrote: > On Tue, Sep 03, 2013 at 05:49:29PM +0100, Ian Molton wrote: > > Add a driver for the EMMA mobile I2C block. > > > > The driver supports low and high-speed interrupt driven PIO transfers. > > &g

Re: [PATCH 1/2] I2C: EMMA Mobile I2C master driver

2013-09-04 Thread Simon Horman
On Tue, Sep 03, 2013 at 05:49:29PM +0100, Ian Molton wrote: > Add a driver for the EMMA mobile I2C block. > > The driver supports low and high-speed interrupt driven PIO transfers. > > Signed-off-by: Ian Molton Magnus, could you find some time to review this? > --- > drivers/i2c/busses/Kconfi

Re: [PATCH] i2c: sh_mobile: Don't start transfers when suspending

2013-02-15 Thread Simon Horman
On Thu, Feb 14, 2013 at 11:17:37AM -0600, Bastian Hecht wrote: > Currently we provoke i2c timeouts by allowing transfers when > suspending. This patch adds awareness to suspending and fixes these > issues. > The patch follows the style used in i2c-tegra.c - thanks. Hi, at this stage I do not expe

Re: [PATCH] i2c: rcar: fixup section mismatch on rcar_i2c_probe/remove()

2012-10-31 Thread Simon Horman
hen annotate the > variable with __exit* (see linux/init.h) or name the variable: > *driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console > > Reported-by: Simon Horman > Signed-off-by: Kuninori Morimoto > --- > Simon > > Is this patch solve your is

Re: [PATCH v3] i2c: add Renesas R-Car I2C driver

2012-10-30 Thread Simon Horman
On Thu, Sep 27, 2012 at 11:44:25PM -0700, Kuninori Morimoto wrote: > R-Car I2C is similar with SH7760 I2C. > But the SH7760 I2C driver had many workaround operations, since H/W had bugs. > Thus, it was pointless to keep compatible between SH7760 and R-Car I2C > drivers. > This patch creates new Re

Re: [PATCH v2] i2c: add Renesas R-Car I2C driver

2012-09-27 Thread Simon Horman
Hi Morimoto-san, Hi Wolfram, Hi All, I'm not aware of any objections to this patch from the shmobile side of things, so to that end: Acked-by: Simon Horman Wolfram, would you consider merging this change? On Thu, Sep 27, 2012 at 06:57:47PM -0700, Kuninori Morimoto wrote: > > Plea

Re: [PATCH] i2c: i2c-sh_mobile bus speed platform data V2

2011-04-28 Thread Simon Horman
On Thu, Apr 28, 2011 at 01:25:36PM +0900, Magnus Damm wrote: > From: Magnus Damm > > Add support to the i2c-sh_mobile driver for setting > the I2C bus speed using platform data. > > Signed-off-by: Magnus Damm Acked-by: Simon Horman -- To unsubscribe from this list: send the

Re: [PATCH] i2c: i2c-sh_mobile bus speed platform data

2011-04-27 Thread Simon Horman
011 at 10:18:01AM +0900, Simon Horman wrote: > >> >> On Thu, Apr 28, 2011 at 10:06:38AM +0900, Magnus Damm wrote: > >> >> > On Thu, Apr 28, 2011 at 7:14 AM, Simon Horman > >> >> > wrote: > >> >> > > I believe that on the sh73a0 an

Re: [PATCH] i2c: i2c-sh_mobile bus speed platform data

2011-04-27 Thread Simon Horman
On Thu, Apr 28, 2011 at 10:06:38AM +0900, Magnus Damm wrote: > On Thu, Apr 28, 2011 at 7:14 AM, Simon Horman wrote: > > Hi Magnus, > > > > On Thu, Apr 21, 2011 at 10:22:54PM +0900, Magnus Damm wrote: > >> From: Magnus Damm > >> > >> Add support

Re: [PATCH] i2c: i2c-sh_mobile bus speed platform data

2011-04-27 Thread Simon Horman
Hi Magnus, On Thu, Apr 21, 2011 at 10:22:54PM +0900, Magnus Damm wrote: > From: Magnus Damm > > Add support to the i2c-sh_mobile driver for setting > the I2C bus speed using platform data. > > Signed-off-by: Magnus Damm > --- > > drivers/i2c/busses/i2c-sh_mobile.c | 13 +++-- > inc

Re: [PATCH] i2c: add a module alias to the sh-mobile driver

2011-04-18 Thread Simon Horman
On Fri, Apr 15, 2011 at 08:18:57PM +0200, Guennadi Liakhovetski wrote: > This patch enables I2C driver autoloading on sh-mobile systems. > > Signed-off-by: Guennadi Liakhovetski > Cc: Simon Horman > Cc: Magnus Damm This appears correct to me. Reviewed-by: Simon Horman -- To u