[PATCH] i2c: mv64xxx: really allow I2C offloading

2015-10-20 Thread Thomas Petazzoni
lt;sta...@vger.kernel.org> Signed-off-by: Hezi <h...@marvell.com> [Thomas: reworked commit log and title.] Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- Note: the original fix is from Hezi, but I rewrote the commit log, which is why I authorized myself to treat

Re: [PATCH] i2c: mv64xxx: really allow I2C offloading

2015-10-20 Thread Thomas Petazzoni
Hello, On Tue, 20 Oct 2015 16:56:21 +, Hezi Shahmoon wrote: > Hi. > > It is: > Hezi Shahmoon > > Email: > h...@marvell.com Thanks Hezi. Wolfram, do you want me to send a v2 with Hezi's full name or will you fix that up when applying the patch ? Thanks, Thomas --

Re: i2c: i2c-mv64xxx: rework offload support to fix several problems

2015-07-05 Thread Thomas Petazzoni
Dear Antony Pavlov, On Sat, 4 Jul 2015 09:59:08 +0300, Antony Pavlov wrote: I have found your commit in the linux kernel mainline commit 00d8689b85a7bb37cc57ba4c40bd46325f51ced4 Author: Thomas Petazzoni thomas.petazz...@free-electrons.com Date: Thu Dec 11 17:33:46 2014 +0100

Re: Bug in i2c-core?

2015-02-28 Thread Thomas Petazzoni
, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: Bug in i2c-core?

2015-02-27 Thread Thomas Petazzoni
Dear Sébastien SZYMANSKI, On Fri, 27 Feb 2015 12:09:51 +0100, Sébastien SZYMANSKI wrote: error = input_register_device(sx8654-input); if (error) return error; Where is your -remove() function that unregisters the input device? Best regards, Thomas -- Thomas

Re: [PATCH] i2c: mv64xxx: enable acquisition of timeout value from Device Tree

2015-01-15 Thread Thomas Petazzoni
the default + timeout is 1000ms I think this description lacks one information: the timeout of *what* ? Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send

[PATCH 0/2] i2c: i2c-mv64xxx: fix offload support

2014-12-11 Thread Thomas Petazzoni
. They apply on top of 3.18. Thanks, Thomas Thomas Petazzoni (2): i2c: i2c-mv64xxx: use BIT() macro for register value definitions i2c: i2c-mv64xxx: rework offload support to fix several problems drivers/i2c/busses/i2c-mv64xxx.c | 325 +++ 1 file changed, 194

[PATCH 2/2] i2c: i2c-mv64xxx: rework offload support to fix several problems

2014-12-11 Thread Thomas Petazzoni
(EEPROM on I2C and RTC on I2C) - Armada XP WRT1900AC (LED controller on I2C) - Armada XP GP (EEPROM on I2C) Fixes: 930ab3d403ae (i2c: mv64xxx: Add I2C Transaction Generator support) Cc: sta...@vger.kernel.org # v3.12+ Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com

[PATCH 1/2] i2c: i2c-mv64xxx: use BIT() macro for register value definitions

2014-12-11 Thread Thomas Petazzoni
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com --- drivers/i2c/busses/i2c-mv64xxx.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c index 2f64273..7f57d1f 100644

Re: [PATCH 0/5] mv64xxx updates

2014-02-13 Thread Thomas Petazzoni
adding Maxime Ripard in Cc, since he is the maintainer of the Allwinner platform, which also uses this I2C driver. So I guess he would like to be notified of such changes in order to test that the driver still works for him. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux

Re: [PATCH v4 3/3] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs

2014-01-07 Thread Thomas Petazzoni
= !of_property_read_bool(np, offload-broken); Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v2 1/2] ARM: mvebu: Add support to get the ID and the revision of a SoC

2014-01-03 Thread Thomas Petazzoni
mvebu_get_soc_id(u32 *dev, u32 *rev); +#else +int mvebu_get_soc_id(u32 *dev, u32 *rev) Missing static inline. Without these, if this header file is included more than once, you will have two times the same symbol defined. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded

Re: [PATCH v2 2/2] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs

2014-01-03 Thread Thomas Petazzoni
revision + * weplay safe and we don't enable it weplay - we play + */ + if (mvebu_get_soc_id(rev, dev) == 0 dev MV78XX0_A0_REV) + drv_data-offload_enabled = true; } out: Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons

Re: [PATCH] EMMA: Add em i2c driver

2013-09-04 Thread Thomas Petazzoni
); Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support

2013-08-06 Thread Thomas Petazzoni
should support a Device Tree file that uses marvell,mv78230-i2c alone. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line

Re: [PATCH 1/2] i2c-mv64xxx: Add I2C Transaction Generator support

2013-06-07 Thread Thomas Petazzoni
; This could be written directly as: drv_data-bridge_enabled = of_property_read_bool(np, i2c,i2c-bridge); Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com

Re: [PATCH 2/2] ARM: dts: mvebu: Add the i2c-bridge capability to the mv64xxx-i2c

2013-06-07 Thread Thomas Petazzoni
that, for now. We can probably assume future Marvell SoC may also have this feature, but we don't know for sure. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe

Re: [PATCH] i2c: mv64xxx: Add support Armada-XP SoC

2012-10-30 Thread Thomas Petazzoni
. This is not needed: ARCH_MVEBU already selects PLAT_ORION. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-i2c

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Thomas Petazzoni
it in drivers/pinctrl/, which I have started doing. Should I continue working on a drivers/pinctrl/ driver for mvebu for Armada 370/XP, and then we see together if it makes sense to extend to Orion, and if so, what changes are needed? Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Thomas Petazzoni
to keep the compatibility. Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Thomas Petazzoni
as they're compatible. It can only make things better imho. Certainly, especially for MPP/GPIO that are definitely very similar. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Thomas Petazzoni
to just leave to the user of the GPIO to use a GPIO that's appropriate for its usage, i.e not use a GPO when input is needed? Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Thomas Petazzoni
-- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Thomas Petazzoni
was posted in January, so two Linaro Connects happened since them, I don't know if progress has been made here. I guess I'll just stick to irq_chip_generic + irqdomain_legacy for now. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development