On 11 June 2015 at 15:07, Wolfram Sang wrote:
> On Thu, Jun 11, 2015 at 08:11:46PM +0800, Wan ZongShun wrote:
>> Change AMD CZ SMBUS device ID from 0x790b to
>> use Macro definition
>>
>> Signed-off-by: Wan ZongShun
>
> I think it makes sense that this patch goes in via MMC. This I2C change
> is
On 11 June 2015 at 14:11, Wan ZongShun wrote:
> Change this quirk to apply to AMD Carrizo platform.
>
> Signed-off-by: Wan ZongShun
>
> Tested-by: Nath, Arindam
> Tested-by: Ramesh, Ramya
Thanks, applied! I changed the prefix of the commit message header
from "SDHCI." to "mmc: sdhci-pci:"
Kin
On 12 June 2015 at 22:34, Bjorn Helgaas wrote:
> On Thu, Jun 11, 2015 at 08:11:45PM +0800, Wan ZongShun wrote:
>> The KERNCZ is new AMD SB/FCH generation name, like HUDSON2.
>> We will adopt 0x790b as device ID since from this gereration.
>
> s/We will adopt 0x790b as device ID since from/0x790b i
Previously only the ACPI PM domain was supported by the i2c bus.
Let's convert to the common attach/detach functions for PM domains,
which currently means we are extending the support to include the
generic PM domain as well.
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Ulf Hansson
Review
Previously only the ACPI PM domain was supported by the i2c bus.
Let's convert to the common attach/detach functions for PM domains,
which currently means we are extending the support to include the
generic PM domain as well.
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Ulf Hansson
Review
Previously only the ACPI PM domain was supported by the i2c bus.
Let's convert to the common attach/detach functions for PM domains,
which currently means we are extending the support to include the
generic PM domain as well.
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Ulf Hansson
---
dr
Previously only the ACPI power domain was supported by the i2c bus.
Let's convert to the common attach/detach functions for power domains,
which currently means we are extending the support to include the
generic power domain as well.
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Ulf Ha
Previously only the ACPI power domain was supported by the i2c bus.
Let's convert to the common attach/detach functions for power domains,
which currently means we are extending the support to include the
generic power domain as well.
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Ulf Ha
g as you cc the list, patches won't be forgotten
> ;)
Thanks Wolfram, sorry for nagging! :-)
Kind regards
Ulf Hansson
>
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6 May 2014 11:31, Ulf Hansson wrote:
> On 10 April 2014 20:49, Linus Walleij wrote:
>> On Thu, Apr 10, 2014 at 3:59 PM, Ulf Hansson wrote:
>>
>>> For !CONFIG_PM_RUNTIME, the device were never put back into active
>>> state while resuming.
>>>
>>
On 10 April 2014 16:19, Ulf Hansson wrote:
> devm_ioremap() returns NULL on error, not an error.
>
> Cc: Alessandro Rubini
> Cc: Linus Walleij
> Signed-off-by: Ulf Hansson
Linus, Wolfram - ping.
Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line "u
On 10 April 2014 20:49, Linus Walleij wrote:
> On Thu, Apr 10, 2014 at 3:59 PM, Ulf Hansson wrote:
>
>> For !CONFIG_PM_RUNTIME, the device were never put back into active
>> state while resuming.
>>
>> For CONFIG_PM_RUNTIME, we blindly trusted the device to be inac
devm_ioremap() returns NULL on error, not an error.
Cc: Alessandro Rubini
Cc: Linus Walleij
Signed-off-by: Ulf Hansson
---
drivers/i2c/busses/i2c-nomadik.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c
kept active after the transfer.
To handle both issues above, use pm_runtime_force_suspend|resume() from
the system suspend|resume callbacks.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
Do note, this patch were sent during the previous kernel re
Commit "i2c: nomadik: Fixup deployment of runtime PM" introduced a
compiler warning for !CONFIG_PM. Let's fix it here.
Signed-off-by: Ulf Hansson
---
Wolfram, currently one of the queued patches for i2c nomadik introduced a
compiler warning. I decided to add a fixup patch
On 19 February 2014 17:05, Wolfram Sang wrote:
> On Wed, Feb 19, 2014 at 01:27:47PM +0100, Ulf Hansson wrote:
>> We should never be busy performing transfers at suspend late, thus
>> there are no reason to check for it.
>>
>> Cc: Alessandro Rubini
>> Cc: L
On 19 February 2014 16:10, Mark Brown wrote:
> On Wed, Feb 19, 2014 at 03:20:07PM +0100, Ulf Hansson wrote:
>
>> Also note that, Russell has already applied the corresponding part in
>> the amba bus (patch 1)
>
> Why would this depend on an AMBA patch and if it does sur
On 4 February 2014 16:58, Ulf Hansson wrote:
> Convert to the SET_PM_RUNTIME_PM macro while defining the runtime PM
> callbacks. This means the callbacks becomes available for both
> CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME, which is needed to handle the
> combinations of these scena
On 10 February 2014 13:51, Mark Brown wrote:
> On Mon, Feb 10, 2014 at 01:33:50PM +0100, Ulf Hansson wrote:
>> On 4 February 2014 20:16, Mark Brown wrote:
>
>> > This seems like a fairly hideous thing to be having to open code in an
>> > individual driver, it all lo
kept active after the transfer.
To handle both issues above, we need to re-use the runtime PM callbacks
and check the runtime PM state of the device before proceeding with our
operations for system suspend.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Ha
We should never be busy performing transfers at suspend late, thus
there are no reason to check for it.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
Changes in v4:
Fixed compiler warning.
---
drivers/i2c/busses/i2c-nomadik.c | 13
On 19 February 2014 10:40, Russell King - ARM Linux
wrote:
> On Tue, Feb 04, 2014 at 04:58:42PM +0100, Ulf Hansson wrote:
>> Convert to the SET_PM_RUNTIME_PM macro while defining the runtime PM
>> callbacks. This means the callbacks becomes available for both
>>
Use devm_* functions to simplify code and error handling.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
Change in v5:
Fix the screwed up rebase for the second time.
Note, still the other v3 patches in this patchset, applies on top of
On 18 February 2014 23:20, Ulf Hansson wrote:
> Use devm_* functions to simplify code and error handling.
>
> Cc: Alessandro Rubini
> Cc: Linus Walleij
> Cc: Wolfram Sang
> Signed-off-by: Ulf Hansson
> ---
>
> Changes in v4:
> Rebased on top of Linus Wall
Use devm_* functions to simplify code and error handling.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
Changes in v4:
Rebased on top of Linus Walleij's v2 patch:
"i2c: nomadik: factor platform data into state container"
On 18 February 2014 21:50, Ulf Hansson wrote:
> On 18 February 2014 19:43, Wolfram Sang wrote:
>>
>>> I added the IS_ERR, check as you suggested. That caused a rebase of
>>> the other patches as well.
>>>
>>> Sorry if it was unclear.
>>
>>
On 18 February 2014 19:43, Wolfram Sang wrote:
>
>> I added the IS_ERR, check as you suggested. That caused a rebase of
>> the other patches as well.
>>
>> Sorry if it was unclear.
>
> No problem. I am about to apply all patches except 17 as you suggested.
> It fails here, however, although I appl
On 18 February 2014 17:46, Russell King - ARM Linux
wrote:
> On Tue, Feb 18, 2014 at 05:36:52PM +0100, Ulf Hansson wrote:
>> If we add SDIO irq support to mmci in future; parts of that
>> implementation includes a re-route of DAT1 to a GPIO irq when entering
>> runtime suspe
On 18 February 2014 17:05, Russell King - ARM Linux
wrote:
> On Tue, Feb 04, 2014 at 04:58:44PM +0100, Ulf Hansson wrote:
>> In runtime suspended state, we are not expecting IRQs and thus we can
>> safely mask them, not only for pwrreg_nopower variants but for all.
>>
>
On 18 February 2014 12:01, Wolfram Sang wrote:
> On Mon, Feb 17, 2014 at 04:20:18PM +0100, Ulf Hansson wrote:
>> Use devm_* functions to simplify code and error handling.
>>
>> Cc: Alessandro Rubini
>> Cc: Linus Walleij
>> Cc: Wolfram Sang
>> Signed-off-b
kept active after the transfer.
To handle both issues above, we need to re-use the runtime PM callbacks
and check the runtime PM state of the device before proceeding with our
operations for system suspend.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Ha
We should never be busy performing transfers at suspend late, thus
there are no reason to check for it.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
drivers/i2c/busses/i2c-nomadik.c | 10 --
1 file changed, 10 deletions(-)
diff --git a
been completed,
the reference counting for the clock will be screwed up and never reach
zero. We resolve this by implementing runtime PM callbacks and let them
handle the resources accordingly, including the clock.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf
The amba bus are responsible for pm_runtime_enable|disable, remove the
redundant pm_runtime_disable at driver removal.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
drivers/i2c/busses/i2c-nomadik.c |1 -
1 file changed, 1 deletion(-)
diff --git
At system suspend_late, runtime PM has been disabled by the PM core
which means we can safely operate on these resources. Consequentially
we no longer have to wait until the noirq phase of the system suspend.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
Use devm_* functions to simplify code and error handling.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
drivers/i2c/busses/i2c-nomadik.c | 31 ++-
1 file changed, 10 insertions(+), 21 deletions(-)
diff --git a/drivers
On 15 February 2014 16:03, Wolfram Sang wrote:
> On Thu, Feb 13, 2014 at 03:09:02PM +0100, Ulf Hansson wrote:
>> Use devm_* functions to simplify code and error handling.
>>
>> Cc: Alessandro Rubini
>> Cc: Linus Walleij
>> Cc: Wolfram Sang
>> Signed-off-b
On 10 February 2014 11:14, Ulf Hansson wrote:
> On 5 February 2014 15:34, Linus Walleij wrote:
>> On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote:
>>
>>> Since the device is active while a successful probe has been completed,
>>> the reference counting for
At system suspend_late, runtime PM has been disabled by the PM core
which means we can safely operate on these resources. Consequentially
we no longer have to wait until the noirq phase of the system suspend.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
Use devm_* functions to simplify code and error handling.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
Changes in v2:
Rebased on top of latest i2c-nomadik branch.
---
drivers/i2c/busses/i2c-nomadik.c | 29 +
1
The amba bus are responsible for pm_runtime_enable|disable, remove the
redundant pm_runtime_disable at driver removal.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
Changes in v2:
Rebased on top of latest i2c-nomadik branch.
---
drivers/i2c
been completed,
the reference counting for the clock will be screwed up and never reach
zero. We resolve this by implementing runtime PM callbacks and let them
handle the resources accordingly, including the clock.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf
kept active after the transfer.
To handle both issues above, we need to re-use the runtime PM callbacks
and check the runtime PM state of the device before proceeding with our
operations for system suspend.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Ha
We should never be busy performing transfers at suspend late, thus
there are no reason to check for it.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
Changes in v2:
Rebased on top of latest i2c-nomadik branch.
---
drivers/i2c/busses/i2c
On 4 February 2014 20:16, Mark Brown wrote:
> On Tue, Feb 04, 2014 at 04:58:48PM +0100, Ulf Hansson wrote:
>
>> @@ -2328,8 +2300,23 @@ static int pl022_suspend(struct device *dev)
>> return ret;
>> }
>>
>> - pm_runtime_get_sync(dev);
&g
On 4 February 2014 20:22, Kevin Hilman wrote:
> Ulf Hansson writes:
>
>> Due to the available runtime PM callbacks, we are now able to put our
>> device into low power state at system suspend.
>>
>> Earlier we could not accomplish this without trusting a power do
On 4 February 2014 20:19, Mark Brown wrote:
> On Tue, Feb 04, 2014 at 04:58:50PM +0100, Ulf Hansson wrote:
>> Make use of clk_prepare_enable and clk_disable_unprepare to simplify
>> code. No functional change.
>
> I went ahead and applied this since it looks good and seem
On 4 February 2014 18:07, Mark Brown wrote:
> On Tue, Feb 04, 2014 at 04:58:49PM +0100, Ulf Hansson wrote:
>> Use clk_disable_unprepare and clk_prepare_enable from the runtime PM
>> callbacks, to fully gate|ungate clocks. Potentially this will save more
>> power, depending
On 4 February 2014 19:49, Mark Brown wrote:
> On Tue, Feb 04, 2014 at 04:58:41PM +0100, Ulf Hansson wrote:
>
>> The fixes for the amba bus needs to be merged prior to the other, thus I
>> think
>> it could make sense to merge this complete patchset through Russell's
On 5 February 2014 15:45, Fabio Estevam wrote:
> On Tue, Feb 4, 2014 at 1:58 PM, Ulf Hansson wrote:
>
>> +static int nmk_i2c_runtime_resume(struct device *dev)
>> +{
>> + struct amba_device *adev = to_amba_device(dev);,
>> + struct nmk_i2c_dev *n
On 5 February 2014 15:34, Linus Walleij wrote:
> On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote:
>
>> Since the device is active while a successful probe has been completed,
>> the reference counting for the clock will be screwed up and never reach
>> zero.
>&g
To give provision for amba drivers to make use of the late|early PM
callbacks, we point the amba bus PM callbacks to the generic versions
of these.
Cc: Russell King
Signed-off-by: Ulf Hansson
---
drivers/amba/bus.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/amba/bus.c
In runtime suspended state, we are not expecting IRQs and thus we can
safely mask them, not only for pwrreg_nopower variants but for all.
Obviously we then also need to make sure we restore the IRQ mask while
becoming runtime resumed.
Cc: Russell King
Signed-off-by: Ulf Hansson
---
drivers
Convert to the SET_PM_RUNTIME_PM macro while defining the runtime PM
callbacks. This means the callbacks becomes available for both
CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME, which is needed by drivers and
power domains.
Cc: Russell King
Signed-off-by: Ulf Hansson
---
drivers/amba/bus.c |4
Convert to the SET_PM_RUNTIME_PM macro while defining the runtime PM
callbacks. This means the callbacks becomes available for both
CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME, which is needed to handle the
combinations of these scenarios.
Cc: Russell King
Signed-off-by: Ulf Hansson
---
drivers/mmc
Convert to the SET_PM_RUNTIME_PM macro while defining the runtime PM
callbacks. This means the callbacks becomes available for both
CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME, which is needed to handle the
combinations of these scenarios.
Cc: Mark Brown
Signed-off-by: Ulf Hansson
---
drivers/spi
ignored, which now isn't the case any more.
Moreover, putting the device into low power state couldn't be done
without first bringing it back to full power. This constraint don't
exists any more.
Cc: Mark Brown
Signed-off-by: Ulf Hansson
---
drivers/spi/spi
Use clk_disable_unprepare and clk_prepare_enable from the runtime PM
callbacks, to fully gate|ungate clocks. Potentially this will save more
power, depending on the clock tree for the current SOC.
Cc: Mark Brown
Signed-off-by: Ulf Hansson
---
drivers/spi/spi-pl022.c |4 ++--
1 file changed
Make use of clk_prepare_enable and clk_disable_unprepare to simplify
code. No functional change.
Cc: Mark Brown
Signed-off-by: Ulf Hansson
---
drivers/spi/spi-pl022.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi
.
Cc: Russell King
Signed-off-by: Ulf Hansson
---
drivers/mmc/host/mmci.c | 45 +
1 file changed, 25 insertions(+), 20 deletions(-)
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index c88da1c..074e0cb 100644
--- a/drivers/mmc/host
The driver core is now taking care of putting our pins into default
state at probe. Thus we can remove the redundant call for it in probe.
Cc: Mark Brown
Signed-off-by: Ulf Hansson
---
drivers/spi/spi-pl022.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b
The amba bus are responsible for pm_runtime_enable|disable, remove the
redundant pm_runtime_disable at driver removal.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
drivers/i2c/busses/i2c-nomadik.c |1 -
1 file changed, 1 deletion(-)
diff --git
At system suspend_late, runtime PM has been disabled by the PM core
which means we can safely operate on these resources. Consequentially
we no longer have to wait until the noirq phase of the system suspend.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
drivers/i2c/busses/i2c-nomadik.c | 47 ++
1 file changed, 27 insertions(+), 20 deletions(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index 0caa8ea
Use devm_* functions to simplify code and error handling.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
drivers/i2c/busses/i2c-nomadik.c | 29 +
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/drivers/i2c
kept active after the transfer.
To handle both issues above, we need to re-use the runtime PM callbacks
and check the runtime PM state of the device before proceeding with our
operations for system suspend.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Ha
Sang
Signed-off-by: Ulf Hansson
---
drivers/i2c/busses/i2c-nomadik.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index 42c9e51..0caa8ea 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
We should never be busy performing transfers at suspend late, thus
there are no reason to check for it.
Cc: Alessandro Rubini
Cc: Linus Walleij
Cc: Wolfram Sang
Signed-off-by: Ulf Hansson
---
drivers/i2c/busses/i2c-nomadik.c | 10 --
1 file changed, 10 deletions(-)
diff --git a
he and the other maintainers think this is okay.
Ulf Hansson (17):
amba: Let runtime PM callbacks be available for CONFIG_PM
amba: Add late and early PM callbacks
mmc: mmci: Mask IRQs for all variants during runtime suspend
mmc: mmci: Let runtime PM callbacks be available for CONFIG_PM
M code for this is already, nomadik and omap
for example. I think typically clocks, pins and if there are a power
domain regulator for the controller, those should be handled through
runtime PM to save power at "request inactivity".
Kind regards
Ulf Hansson
>
> Anyway, thanks for le
Hi Linus,
Thanks for resending this patch. This patch is needed for me to be
able to add clock lookups for the i2c devices for ux500, unless the
boot will be broken.
Kind regards
Ulf Hansson
On 10 October 2012 13:02, Linus Walleij wrote:
> From: Philippe Begnic
>
> Make sure to clk_p
Hi Wolfram,
Juts a kind reminder on this. Do you see any problem merging this?
Kind regards
Ulf Hansson
On 20 September 2012 21:17, Linus Walleij wrote:
> On Thu, Sep 20, 2012 at 5:20 PM, Ulf Hansson
> wrote:
>
>> From: Philippe Begnic
>>
>> Make sure to clk_pr
From: Philippe Begnic
Make sure to clk_prepare as well as clk_enable.
Signed-off-by: Philippe Begnic
Signed-off-by: Ulf Hansson
---
drivers/i2c/busses/i2c-nomadik.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c
73 matches
Mail list logo
