Dear Lucas,
Lucas De Marchi lucas.de.mar...@gmail.com wrote on 23.06.2015 19:02:03:
On Tue, Jun 23, 2015 at 1:45 PM, christian.rupp...@alitech.com wrote:
Hello,
Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16:
[...]
The result is not very encouraging: Out of five (identical
wrote on 23.06.2015
19:02:03:
On Tue, Jun 23, 2015 at 1:45 PM, christian.rupp...@alitech.com
wrote:
Hello,
Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16:
[...]
The result is not very encouraging: Out of five (identical)
designware
i2c
Hello,
Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16:
Mika Westerberg mika.westerb...@linux.intel.com wrote on 10.06.
2015 09:07:22:
On Tue, Jun 09, 2015 at 03:29:01PM -0300, Lucas De Marchi wrote:
Hi Mika,
On Tue, Jun 9, 2015 at 5:51 AM, Mika Westerberg
mika.westerb
: Christian Ruppert christian.rupp...@abilis.com
Acked-by: Christian Ruppert christian.rupp...@alitech.com
Please note that my email address has changed and use the alitech one in
future. The abilis address might be switched off soon.
Cc: Mika Westerberg mika.westerb...@linux.intel.com
Cc: Wolfram
Hello Alexey,
Alexey Brodkin alexey.brod...@synopsys.com wrote on 03/03/2015 05:37:31
PM:
From:
Alexey Brodkin alexey.brod...@synopsys.com
To:
christian.rupp...@alitech.com christian.rupp...@alitech.com,
Cc:
mika.westerb...@linux.intel.com mika.westerb...@linux.intel.com,
vgu...@synopsys.com
Cc: Christian Ruppert christian.rupp...@abilis.com
Cc: Mika Westerberg mika.westerb...@linux.intel.com
Cc: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-designware-platdrv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 2015-03-03 18:21, Wolfram Sang wrote:
which omit this type of messages completely. Andy's proposal of
centralising this looks like a very good solution here (and on
top of that removes many useless strings from the kernel
binary).
I am
On Tue, Oct 07, 2014 at 12:35:29PM +, Vineet Gupta wrote:
+CC Guenter Roeck
[...]
However, the kernel-doc comment for init_machine in
mach_desc.h is now slightly confusing (still mentioning device tree).
A platform of future can still call of_platform_populate() etc to reparse the
nowadays but I'm not sure about ARC.
That's why I have copied Christian Ruppert.
Christian,
Do you see problems on your side if we depend on COMMON_CLK?
COMMON_CLK is not selected by the ARC architecture in general. However,
we do select COMMON_CLK in the TB10x platform which uses the designware
. From my point of view there is no need to move select
COMMON_CLK up to the ARC architecture level.
Greetings,
Christian
--
Christian Ruppert , christian.rupp...@abilis.com
/|
Tel: +41/(0)22 816 19-42 //| 3, Chemin
On Sat, Aug 24, 2013 at 01:58:47PM +0900, Shinya Kuribayashi wrote:
On 8/21/13 11:39 PM, Christian Ruppert wrote:
On Fri, Aug 16, 2013 at 11:15:12AM +0900, Shinya Kuribayashi wrote:
On 8/5/13 6:31 PM, Christian Ruppert wrote:
On Wed, Jul 24, 2013 at 11:31:44PM +0900, Shinya Kuribayashi wrote
On Fri, Aug 16, 2013 at 11:15:12AM +0900, Shinya Kuribayashi wrote:
Hi,
On 8/5/13 6:31 PM, Christian Ruppert wrote: On Wed, Jul 24, 2013 at
11:31:44PM +0900, Shinya Kuribayashi wrote:
As said before, all t_SCL things should go away. Please forget
about 100kbps, 400kbps, and so on. Bus
On Mon, Aug 05, 2013 at 12:02:26PM +0200, Wolfram Sang wrote:
Would it make sense to add generic I2C device tree properties for those
parameters? These parameters are independent of the actual bus driver,
rather a PCB property... And as such the correct place would be device
tree or
On Wed, Jul 17, 2013 at 11:39:58PM +0900, Shinya Kuribayashi wrote:
On 7/16/13 8:16 PM, Christian Ruppert wrote: On Sat, Jul 13, 2013 at
02:36:43PM +0900, Shinya Kuribayashi wrote:
Basically, DW I2C core provides a good enough (and quite direct) way
to control tHIGH and tLOW timing specs
.
_
scl \__ ...
___ __
sda \_/ ...
|-|---|
(1) (2)
On Wed, Jul 10, 2013 at 06:56:35PM +0200, Christian Ruppert wrote:
If I understand the above, it leaves Tf and Tr to be PCB specific and then
these values are passed
On Wed, Jul 10, 2013 at 01:52:15PM +0300, Mika Westerberg wrote:
On Tue, Jul 09, 2013 at 06:19:28PM +0200, Christian Ruppert wrote:
What I meant is the following: The clock cycle time Tc is composed of
the four components
Tc = Th + Tf + Tl + Tr
where
Th: Time during which
On Tue, Jul 09, 2013 at 11:44:02AM +0300, Mika Westerberg wrote:
On Mon, Jul 08, 2013 at 03:42:17PM +0200, Christian Ruppert wrote:
On Mon, Jul 08, 2013 at 02:45:26PM +0300, Mika Westerberg wrote:
The DesignWare I2C controller has high count (HCNT) and low count (LCNT)
registers for each
sda_hold_time;
+ u16 ss_hcnt;
+ u16 ss_lcnt;
+ u16 fs_hcnt;
+ u16 fs_lcnt;
};
#define ACCESS_SWAP 0x0001
--
1.8.3.2
--
Christian Ruppert
ARC based platform, no issues with
compilation or functionality. Thanks for pointing this out.
Reviewed-by: Christian Ruppert christian.rupp...@abilis.com
Signed-off-by: Vincent Stehlé vincent.ste...@freescale.com
Cc: Wolfram Sang w...@the-dreams.de
Cc: Christian Ruppert christian.rupp
This patch makes the SDA hold time configurable through device tree.
Signed-off-by: Christian Ruppert christian.rupp...@abilis.com
Signed-off-by: Pierrick Hascoet pierrick.hasc...@abilis.com
---
.../devicetree/bindings/i2c/i2c-designware.txt | 15 +++
arch/arc/boot/dts
This patch makes the SDA hold time configurable through device tree.
Signed-off-by: Christian Ruppert christian.rupp...@abilis.com
Signed-off-by: Pierrick Hascoet pierrick.hasc...@abilis.com
---
.../devicetree/bindings/i2c/i2c-designware.txt | 14 ++
arch/arc/boot/dts
of these factors and I deduce they
all have their importance. We know that the specified internal device
timings are sometimes buggy, I don't know about the other two.
Greetings,
Christian
--
Christian Ruppert , christian.rupp...@abilis.com
On Wed, Jun 19, 2013 at 11:45:40AM +0200, Wolfram Sang wrote:
Hi,
On Wed, Jun 12, 2013 at 04:47:45PM +0200, Christian Ruppert wrote:
On Mon, Jun 10, 2013 at 05:29:55PM +0200, Wolfram Sang wrote:
On Tue, May 14, 2013 at 03:04:02PM +0200, Christian Ruppert wrote:
This patch makes
This patch makes the SDA hold time configurable through device tree.
Signed-off-by: Christian Ruppert christian.rupp...@abilis.com
Signed-off-by: Pierrick Hascoet pierrick.hasc...@abilis.com
---
.../devicetree/bindings/i2c/i2c-designware.txt | 14 ++
arch/arc/boot/dts
On Fri, Jun 14, 2013 at 04:37:41PM +0200, Wolfram Sang wrote:
On Fri, Jun 07, 2013 at 10:51:23AM +0200, Christian Ruppert wrote:
[...]
+ /*
+* We must disable the adapter before unlocking the dev-lock mutex
+* below. Otherwise the hardware might continue generating interrupts
On Mon, Jun 17, 2013 at 10:33:36AM +0200, Jean Delvare wrote:
On Mon, 17 Jun 2013 10:19:33 +0200, Christian Ruppert wrote:
On Fri, Jun 14, 2013 at 04:37:41PM +0200, Wolfram Sang wrote:
BTW since I am currently here: i2c-designware-core should be in the
'algos' directory
on
Mika's patch). Under this condition you can assume
Tested-By: Christian Ruppert christian.rupp...@abilis.com
I still think the code is more logical with this patch than without it
and I am in favour of applying both (if Andy agrees that is). We must
keep in mind, however, that http
On Thu, Jun 13, 2013 at 11:33:56AM +0300, Andy Shevchenko wrote:
On Thu, 2013-06-13 at 10:16 +0200, Christian Ruppert wrote:
As promised, I gave this one some over-night stress testing and I can
confirm what I said previously:
- The patch does _not_ solve the interrupt loop lockups
On Tue, Jun 11, 2013 at 08:40:37PM +0200, Wolfram Sang wrote:
On Fri, Jun 07, 2013 at 03:01:34PM +0200, Christian Ruppert wrote:
Hi Andy,
I like your patch and I just did some testing on it. Unluckily, it
doesn't solve the lock-up problem.
I haven't investigated any further but I
On Mon, Jun 10, 2013 at 05:29:55PM +0200, Wolfram Sang wrote:
On Tue, May 14, 2013 at 03:04:02PM +0200, Christian Ruppert wrote:
This patch makes the SDA hold time configurable through device tree.
[rebased to i2c-current/i2c-next/mainline-3.10-rc1]
Signed-off-by: Christian Ruppert
On Fri, Jun 07, 2013 at 08:23:53AM +0300, Mika Westerberg wrote:
Hi Christian,
On Thu, Jun 06, 2013 at 03:43:35PM +0200, Christian Ruppert wrote:
The designware block is not always properly disabled in the case of
transfer errors. Interrupts from aborted transfers might be handled
after
/ to be
applied first.
Signed-off-by: Christian Ruppert christian.rupp...@abilis.com
---
drivers/i2c/busses/i2c-designware-core.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-core.c
b/drivers/i2c/busses/i2c-designware-core.c
index
.
Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com
Reviewed-by: Christian Ruppert christian.rupp...@abilis.com
---
drivers/i2c/busses/i2c-designware-core.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-core.c
b
*/
i2c_dw_xfer_init(dev);
--
1.8.2.rc0.22.gb3600c3
--
Christian Ruppert , christian.rupp...@abilis.com
/|
Tel: +41/(0)22 816 19-42 //| 3, Chemin du Pré-Fleuri
_// | bilis Systems CH
that the system is stuck in an infinite interrupt loop (where
FIFOs are never emptied).
This patch cleanly disables the designware-i2c hardware at the end of
every transfer, successful or not.
Signed-off-by: Christian Ruppert christian.rupp...@abilis.com
---
drivers/i2c/busses/i2c-designware-core.c
if the
initiating process is killed.
Signed-off-by: Christian Ruppert christian.rupp...@abilis.com
---
drivers/i2c/busses/i2c-designware-core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-core.c
b/drivers/i2c/busses/i2c-designware-core.c
index
This patch makes the SDA hold time configurable through device tree.
[rebased to i2c-current/i2c-next/mainline-3.10-rc1]
Signed-off-by: Christian Ruppert christian.rupp...@abilis.com
Signed-off-by: Pierrick Hascoet pierrick.hasc...@abilis.com
---
.../devicetree/bindings/i2c/i2c-designware.txt
Looks like this was eaten by the spam filter last time so i'm resending
it to the lists only:
This patch makes the SDA hold time configurable through device tree.
Signed-off-by: Christian Ruppert christian.rupp...@abilis.com
Signed-off-by: Pierrick Hascoet pierrick.hasc...@abilis.com
by i2c/next.
Signed-off-by: Christian Ruppert christian.rupp...@abilis.com
Signed-off-by: Pierrick Hascoet pierrick.hasc...@abilis.com
---
.../devicetree/bindings/i2c/i2c-designware.txt | 15 +++
drivers/i2c/busses/i2c-designware-core.c |5 +
drivers/i2c/busses
by i2c/next.
Signed-off-by: Christian Ruppert christian.rupp...@abilis.com
Signed-off-by: Pierrick Hascoet pierrick.hasc...@abilis.com
---
.../devicetree/bindings/i2c/i2c-designware.txt | 15 +++
drivers/i2c/busses/i2c-designware-core.c |5 +
drivers/i2c/busses
-baseline).
Signed-off-by: Christian Ruppert christian.rupp...@abilis.com
Signed-off-by: Pierrick Hascoet pierrick.hasc...@abilis.com
---
.../devicetree/bindings/i2c/i2c-designware.txt | 18 ++
drivers/i2c/busses/i2c-designware-core.c |6 +++
drivers/i2c/busses/i2c
On Fri, Feb 15, 2013 at 01:50:37PM +0200, Mika Westerberg wrote:
On Fri, Feb 15, 2013 at 11:11:50AM +0100, Christian Ruppert wrote:
This patch implements interrupt sharing and SDA hold time configuration in
the designware i2c driver. Both functions are enabled through platform data
42 matches
Mail list logo
