Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

On Mon, Aug 06, 2012 at 05:28:44PM -0700, Kevin Hilman wrote: Hi Wolfram, Kevin Hilman khil...@ti.com writes: In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on failure. Without this, after a failed xfer, the runtime PM usecount will have been incremented, but not

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

Hi Wolfram, Kevin Hilman khil...@ti.com writes: In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on failure. Without this, after a failed xfer, the runtime PM usecount will have been incremented, but not decremented causing the usecount to never reach zero after a failure. This

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

Hi Shubhrajyoti, Shubhrajyoti Datta omaplinuxker...@gmail.com writes: Hi Kevin, Thanks for the patch , a doubt below Thanks for the review. On Wed, Jun 27, 2012 at 7:15 AM, Kevin Hilman khil...@ti.com wrote: In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on failure. So the

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

On Friday 29 June 2012 03:25 AM, Kevin Hilman wrote: Hi Shubhrajyoti, Shubhrajyoti Datta omaplinuxker...@gmail.com writes: Hi Kevin, Thanks for the patch , a doubt below Thanks for the review. On Wed, Jun 27, 2012 at 7:15 AM, Kevin Hilman khil...@ti.com wrote: In omap_i2c_xfer(), ensure

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

Hi Kevin, Thanks for the patch , a doubt below On Wed, Jun 27, 2012 at 7:15 AM, Kevin Hilman khil...@ti.com wrote: In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on failure. So the failure means that the usecount is incremented. However the device was not enabled. In that case

[PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on failure. Without this, after a failed xfer, the runtime PM usecount will have been incremented, but not decremented causing the usecount to never reach zero after a failure. This keeps the device always runtime PM enabled which keeps