Re: [PATCH] I2C: add CSR SiRFprimaII on-chip I2C controllers driver

2011-11-07 Thread Barry Song
2011/11/2 Russell King - ARM Linux li...@arm.linux.org.uk: On Wed, Nov 02, 2011 at 10:39:04AM +, Jamie Iles wrote: +   clk = clk_get(pdev-dev, NULL); +   if (IS_ERR(clk)) { +           err = PTR_ERR(clk); +           dev_err(pdev-dev, Clock get failed\n); +           goto out; +  

Re: [PATCH] I2C: add CSR SiRFprimaII on-chip I2C controllers driver

2011-11-06 Thread Barry Song
Jamie, Thanks for reviewing very much. thoese are definitely good comments. 2011/11/2 Jamie Iles ja...@jamieiles.com: Hi Barry, I'm not too familiar with I2C, so just a couple of general comments inline, but otherwise looks good to me. Jamie On Wed, Nov 02, 2011 at 03:10:10AM -0700, Barry

Re: [PATCH] I2C: add CSR SiRFprimaII on-chip I2C controllers driver

2011-11-06 Thread Barry Song
2011/11/2 Russell King - ARM Linux li...@arm.linux.org.uk: On Wed, Nov 02, 2011 at 10:39:04AM +, Jamie Iles wrote: +   clk = clk_get(pdev-dev, NULL); +   if (IS_ERR(clk)) { +           err = PTR_ERR(clk); +           dev_err(pdev-dev, Clock get failed\n); +           goto out; +  

[PATCH] I2C: add CSR SiRFprimaII on-chip I2C controllers driver

2011-11-02 Thread Barry Song
From: Zhiwu Song zhiwu.s...@csr.com SiRFprimaII is the latest generation application processor from CSR’s multi-function SoC product family. The SoC support codes are in arch/arm/mach-prima2 from Linux mainline 3.0. There are two I2C controllers on primaII, features include: ■ Two I2C controller

Re: [PATCH] I2C: add CSR SiRFprimaII on-chip I2C controllers driver

2011-11-02 Thread Jamie Iles
Hi Barry, I'm not too familiar with I2C, so just a couple of general comments inline, but otherwise looks good to me. Jamie On Wed, Nov 02, 2011 at 03:10:10AM -0700, Barry Song wrote: From: Zhiwu Song zhiwu.s...@csr.com SiRFprimaII is the latest generation application processor from CSR’s

Re: [PATCH] I2C: add CSR SiRFprimaII on-chip I2C controllers driver

2011-11-02 Thread Russell King - ARM Linux
On Wed, Nov 02, 2011 at 10:39:04AM +, Jamie Iles wrote: + clk = clk_get(pdev-dev, NULL); + if (IS_ERR(clk)) { + err = PTR_ERR(clk); + dev_err(pdev-dev, Clock get failed\n); + goto out; + } + + clk_enable(clk); The return value of