2011/11/2 Russell King - ARM Linux li...@arm.linux.org.uk:
On Wed, Nov 02, 2011 at 10:39:04AM +, Jamie Iles wrote:
+ clk = clk_get(pdev-dev, NULL);
+ if (IS_ERR(clk)) {
+ err = PTR_ERR(clk);
+ dev_err(pdev-dev, Clock get failed\n);
+ goto out;
+
Jamie,
Thanks for reviewing very much. thoese are definitely good comments.
2011/11/2 Jamie Iles ja...@jamieiles.com:
Hi Barry,
I'm not too familiar with I2C, so just a couple of general comments
inline, but otherwise looks good to me.
Jamie
On Wed, Nov 02, 2011 at 03:10:10AM -0700, Barry
2011/11/2 Russell King - ARM Linux li...@arm.linux.org.uk:
On Wed, Nov 02, 2011 at 10:39:04AM +, Jamie Iles wrote:
+ clk = clk_get(pdev-dev, NULL);
+ if (IS_ERR(clk)) {
+ err = PTR_ERR(clk);
+ dev_err(pdev-dev, Clock get failed\n);
+ goto out;
+
From: Zhiwu Song zhiwu.s...@csr.com
SiRFprimaII is the latest generation application processor from CSR’s
multi-function SoC product family.
The SoC support codes are in arch/arm/mach-prima2 from Linux mainline
3.0.
There are two I2C controllers on primaII, features include:
■ Two I2C controller
Hi Barry,
I'm not too familiar with I2C, so just a couple of general comments
inline, but otherwise looks good to me.
Jamie
On Wed, Nov 02, 2011 at 03:10:10AM -0700, Barry Song wrote:
From: Zhiwu Song zhiwu.s...@csr.com
SiRFprimaII is the latest generation application processor from CSR’s
On Wed, Nov 02, 2011 at 10:39:04AM +, Jamie Iles wrote:
+ clk = clk_get(pdev-dev, NULL);
+ if (IS_ERR(clk)) {
+ err = PTR_ERR(clk);
+ dev_err(pdev-dev, Clock get failed\n);
+ goto out;
+ }
+
+ clk_enable(clk);
The return value of