Hi Wolfram,
On Sat, 2015-03-07 at 01:24 +0100, Wolfram Sang wrote:
Presented like this I wonder if this merits being a dev_err at all.
Wouldn't dev_dbg be more adequate? This might remove the need for the
condition and also avoid bothering everyone if something in the platform
device
Presented like this I wonder if this merits being a dev_err at all.
Wouldn't dev_dbg be more adequate? This might remove the need for the
condition and also avoid bothering everyone if something in the platform
device structures or device tree is not right.
return irq; /*
There's no point in printing error message if platform_get_irq()
returns -EPROBE_DEFER because probe deferring subsystem already outputs
message in bootlog like this:
---8---
platform e001d000.i2c: Driver i2c_designware requests probe deferral
---8---
Moreover in case of probe deferral
Hi Christian,
On Tue, 2015-03-03 at 17:28 +0100, Christian Ruppert wrote:
On 2015-03-03 16:27, Alexey Brodkin wrote:
There's no point in printing error message if platform_get_irq()
returns -EPROBE_DEFER because probe deferring subsystem already outputs
message in bootlog like this:
...@abilis.com
christian.rupp...@abilis.com
Date:
03/03/2015 05:38 PM
Subject:
Re: [PATCH] i2c: designware: Suppress error message if
platform_get_irq() returns -EPROBE_DEFER
Hi Christian,
[...]
irq = platform_get_irq(pdev, 0);
if (irq 0) {
- dev_err(pdev-dev
On 2015-03-03 16:27, Alexey Brodkin wrote:
There's no point in printing error message if platform_get_irq()
returns -EPROBE_DEFER because probe deferring subsystem already outputs
message in bootlog like this:
---8---
platform e001d000.i2c: Driver i2c_designware requests probe deferral
which omit this type of messages completely. Andy's proposal of
centralising this looks like a very good solution here (and on top of
that removes many useless strings from the kernel binary).
I am all for centralizing printouts. I recommended this at my ELCE talk
last year, too. However, you
On Tue, 2015-03-03 at 18:46 +0100, Christian Ruppert wrote:
On 2015-03-03 18:21, Wolfram Sang wrote:
which omit this type of messages completely. Andy's proposal of
centralising this looks like a very good solution here (and on
top of that removes many useless strings from the kernel
On Tue, 2015-03-03 at 20:11 +0100, Wolfram Sang wrote:
Yes, I was thinking even about some wrapper on top of platform_get_irq()
since it seems there are no messaging done inside platform.c, though
devm_* functions usually have it.
When I had a look a few months ago, the situation with
I am all for centralizing printouts. I recommended this at my ELCE
talk last year, too. However, you need to keep in mind that irqs
are sometimes optional and you don't want error messages for those
irqs. IMO worthwhile, but not a low hanging fruit...
There is a lot of truth in
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 2015-03-03 18:21, Wolfram Sang wrote:
which omit this type of messages completely. Andy's proposal of
centralising this looks like a very good solution here (and on
top of that removes many useless strings from the kernel
binary).
I am
11 matches
Mail list logo
