Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-23 Thread Doug Anderson
Tomasz, On Fri, Jun 20, 2014 at 4:59 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On 21.06.2014 01:53, Doug Anderson wrote: Kevin, On Fri, Jun 20, 2014 at 4:13 PM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@chromium.org writes: Kevin, On Fri, Jun 20, 2014 at 2:48 PM,

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-23 Thread Kevin Hilman
Doug Anderson diand...@chromium.org writes: [...] On Fri, Jun 20, 2014 at 4:59 PM, Tomasz Figa tomasz.f...@gmail.com wrote: I'm not sure noirq is going to work correctly, at least not with current callbacks. I can see a call to clk_prepare_enable() there which needs to acquire a mutex.

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-23 Thread Kevin Hilman
Doug Anderson diand...@chromium.org writes: Kevin, On Fri, Jun 20, 2014 at 4:13 PM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@chromium.org writes: Kevin, On Fri, Jun 20, 2014 at 2:48 PM, Kevin Hilman khil...@linaro.org wrote: Hi Doug, Doug Anderson

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-23 Thread Tomasz Figa
On 24.06.2014 00:19, Kevin Hilman wrote: Doug Anderson diand...@chromium.org writes: [...] On Fri, Jun 20, 2014 at 4:59 PM, Tomasz Figa tomasz.f...@gmail.com wrote: I'm not sure noirq is going to work correctly, at least not with current callbacks. I can see a call to

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-23 Thread Doug Anderson
Kevin, On Mon, Jun 23, 2014 at 3:19 PM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@chromium.org writes: [...] On Fri, Jun 20, 2014 at 4:59 PM, Tomasz Figa tomasz.f...@gmail.com wrote: I'm not sure noirq is going to work correctly, at least not with current callbacks. I

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-23 Thread Tomasz Figa
On 24.06.2014 00:27, Doug Anderson wrote: Kevin, On Mon, Jun 23, 2014 at 3:19 PM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@chromium.org writes: [...] On Fri, Jun 20, 2014 at 4:59 PM, Tomasz Figa tomasz.f...@gmail.com wrote: I'm not sure noirq is going to work

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-23 Thread Doug Anderson
Kevin, On Mon, Jun 23, 2014 at 3:23 PM, Kevin Hilman khil...@linaro.org wrote: So I guess in this case the truly correct way to handle it is: 1. i2c controller should have Runtime PM even though (as per the code now) there's nothing you can do to it to save power under normal circumstances.

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-23 Thread Kevin Hilman
Doug Anderson diand...@chromium.org writes: Kevin, On Mon, Jun 23, 2014 at 3:23 PM, Kevin Hilman khil...@linaro.org wrote: So I guess in this case the truly correct way to handle it is: 1. i2c controller should have Runtime PM even though (as per the code now) there's nothing you can do to

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-23 Thread Kevin Hilman
Tomasz Figa tomasz.f...@gmail.com writes: On 24.06.2014 00:27, Doug Anderson wrote: Kevin, On Mon, Jun 23, 2014 at 3:19 PM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@chromium.org writes: [...] On Fri, Jun 20, 2014 at 4:59 PM, Tomasz Figa tomasz.f...@gmail.com wrote:

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-20 Thread Kevin Hilman
Hi Doug, Doug Anderson diand...@chromium.org writes: On Thu, Jun 19, 2014 at 11:43 AM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@chromium.org writes: The original code for the exynos i2c controller registered for the noirq variants. However during review feedback it was

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-20 Thread Doug Anderson
Kevin, On Fri, Jun 20, 2014 at 2:48 PM, Kevin Hilman khil...@linaro.org wrote: Hi Doug, Doug Anderson diand...@chromium.org writes: On Thu, Jun 19, 2014 at 11:43 AM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@chromium.org writes: The original code for the exynos i2c

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-20 Thread Kevin Hilman
Doug Anderson diand...@chromium.org writes: Kevin, On Fri, Jun 20, 2014 at 2:48 PM, Kevin Hilman khil...@linaro.org wrote: Hi Doug, Doug Anderson diand...@chromium.org writes: On Thu, Jun 19, 2014 at 11:43 AM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@chromium.org

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-20 Thread Doug Anderson
Kevin, On Fri, Jun 20, 2014 at 4:13 PM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@chromium.org writes: Kevin, On Fri, Jun 20, 2014 at 2:48 PM, Kevin Hilman khil...@linaro.org wrote: Hi Doug, Doug Anderson diand...@chromium.org writes: On Thu, Jun 19, 2014 at 11:43

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-20 Thread Tomasz Figa
On 21.06.2014 01:53, Doug Anderson wrote: Kevin, On Fri, Jun 20, 2014 at 4:13 PM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@chromium.org writes: Kevin, On Fri, Jun 20, 2014 at 2:48 PM, Kevin Hilman khil...@linaro.org wrote: Hi Doug, Doug Anderson

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-19 Thread Kevin Hilman
Doug Anderson diand...@chromium.org writes: The original code for the exynos i2c controller registered for the noirq variants. However during review feedback it was moved to SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no longer actually noirq (despite functions named

Re: [PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-19 Thread Doug Anderson
Kevin, On Thu, Jun 19, 2014 at 11:43 AM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@chromium.org writes: The original code for the exynos i2c controller registered for the noirq variants. However during review feedback it was moved to SIMPLE_DEV_PM_OPS without anyone

[PATCH] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-18 Thread Doug Anderson
The original code for the exynos i2c controller registered for the noirq variants. However during review feedback it was moved to SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no longer actually noirq (despite functions named exynos5_i2c_suspend_noirq and