Re: [PATCH] i2c: i2c-s3c2410: Remove recently introduced performance overheads

2012-11-22 Thread Wolfram Sang
On Wed, Nov 21, 2012 at 01:12:11PM +0900, Mark Brown wrote: > The changes in "i2c-s3c2410: use exponential back off while polling for > bus idle" remove the initial busy wait for I2C transfers to complete and > replace it with usleep_range() calls which will schedule. > > Since for older SoCs I2C

Re: [PATCH] i2c: i2c-s3c2410: Remove recently introduced performance overheads

2012-11-20 Thread Daniel Kurtz
On Wed, Nov 21, 2012 at 1:08 PM, Olof Johansson wrote: > On Tue, Nov 20, 2012 at 8:12 PM, Mark Brown > wrote: >> The changes in "i2c-s3c2410: use exponential back off while polling for >> bus idle" remove the initial busy wait for I2C transfers to complete and >> replace it with usleep_range() ca

Re: [PATCH] i2c: i2c-s3c2410: Remove recently introduced performance overheads

2012-11-20 Thread Olof Johansson
On Tue, Nov 20, 2012 at 8:12 PM, Mark Brown wrote: > The changes in "i2c-s3c2410: use exponential back off while polling for > bus idle" remove the initial busy wait for I2C transfers to complete and > replace it with usleep_range() calls which will schedule. > > Since for older SoCs I2C transfers

[PATCH] i2c: i2c-s3c2410: Remove recently introduced performance overheads

2012-11-20 Thread Mark Brown
The changes in "i2c-s3c2410: use exponential back off while polling for bus idle" remove the initial busy wait for I2C transfers to complete and replace it with usleep_range() calls which will schedule. Since for older SoCs I2C transfers would usually complete within an extremely small number of C

Re: [PATCH] i2c: i2c-s3c2410: Remove recently introduced performance overheads

2012-11-20 Thread Daniel Kurtz
On Tue, Nov 20, 2012 at 1:57 PM, Mark Brown wrote: > The changes in "i2c-s3c2410: use exponential back off while polling for > bus idle" remove the initial busy wait for I2C transfers to complete and > replace it with usleep_range() calls which will schedule. > > Since for older SoCs I2C transfers

Re: [PATCH] i2c: i2c-s3c2410: Remove recently introduced performance overheads

2012-11-20 Thread Mark Brown
On Tue, Nov 20, 2012 at 05:45:55PM +0800, Daniel Kurtz wrote: > On Tue, Nov 20, 2012 at 1:57 PM, Mark Brown > > + spins = 3; > > + do { > > + cpu_relax(); > > + iicstat = readl(i2c->regs + S3C2410_IICSTAT); > > + } while ((iicstat & S3C2410_IICSTAT_STA

[PATCH] i2c: i2c-s3c2410: Remove recently introduced performance overheads

2012-11-19 Thread Mark Brown
The changes in "i2c-s3c2410: use exponential back off while polling for bus idle" remove the initial busy wait for I2C transfers to complete and replace it with usleep_range() calls which will schedule. Since for older SoCs I2C transfers would usually complete within an extremely small number of C