Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-05-11 Thread Jarkko Nikula
On Tue, 11 May 2010 10:01:22 +0300 Mika Westerberg ext-mika.1.westerb...@nokia.com wrote: I believe this is already in mainline: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7c6bd2010fced38444c9fd658f4c6ce61bd185bf Ah, yeah. I was using the sound-2.6.git tree

Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-04-16 Thread Grazvydas Ignotas
On Wed, Mar 31, 2010 at 3:27 PM, Jarkko Nikula jhnik...@gmail.com wrote: On Wed, 31 Mar 2010 04:27:41 -0600 (MDT) Paul Walmsley p...@pwsan.com wrote: This patch moves register shift setting before any register accesses are done. Signed-off-by: Mika Westerberg

Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-03-31 Thread Paul Walmsley
Hi Mika, Ben, On Tue, 23 Mar 2010, Mika Westerberg wrote: Commit d84d3ea317ce0db89ce0903b4037f800c5d4c477 added register shift to allow also 16-bit register access. However, omap_i2c_unidle() is called before these are set which causes the following OOPS: Unhandled fault: alignment

Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-03-31 Thread Jarkko Nikula
On Wed, 31 Mar 2010 04:27:41 -0600 (MDT) Paul Walmsley p...@pwsan.com wrote: This patch moves register shift setting before any register accesses are done. Signed-off-by: Mika Westerberg ext-mika.1.westerb...@nokia.com Cc: Cory Maccarrone darkstar6...@gmail.com Tested-by: Paul

[PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-03-23 Thread Mika Westerberg
Commit d84d3ea317ce0db89ce0903b4037f800c5d4c477 added register shift to allow also 16-bit register access. However, omap_i2c_unidle() is called before these are set which causes the following OOPS: Unhandled fault: alignment exception (0x801) at 0xfa070009 Internal error: : 801 [#1]