Re: [PATCH] i2c: omap: fix i207 errata handling

2014-11-22 Thread Wolfram Sang
> Guys, I really appreciate you help. > So much testing and review. > I could not have done one. > Thank you! Well, thank YOU, for your hard work in verifying this controller at low-level and in corner-cases. This is very much appreciated. Plus, you have been very responsive to comments. Really g

Re: [PATCH] i2c: omap: fix i207 errata handling

2014-11-22 Thread Wolfram Sang
On Fri, Nov 21, 2014 at 04:16:51AM +0400, Alexander Kochetkov wrote: > commit 6d9939f651419a63e091105663821f9c7d3fec37 (i2c: omap: split out [XR]DR > and [XR]RDY) changed the way how errata i207 (I2C: RDR Flag May Be Incorrectly > Set) get handled. 6d9939f6514 code doesn't correspond to workaround

Re: [PATCH] i2c: omap: fix i207 errata handling

2014-11-21 Thread Alexander Kochetkov
21 нояб. 2014 г., в 3:29, Alexander Kochetkov написал(а): >> >> Found by code review. Real impact haven't seen. >> Tested on Beagleboard XM C. > > Does anybody know the "certain rare conditions" when RDR errata appears? > I tested without luck (Beagleboard XM C). Spent half a day trying to ca

Re: [PATCH] i2c: omap: fix i207 errata handling

2014-11-21 Thread Alexander Kochetkov
21 нояб. 2014 г., в 19:08, Felipe Balbi написал(а): > Tested on BBB and AM437x Starter Kit > > Tested-by: Felipe Balbi > Reviewed-by: Felipe Balbi 21 нояб. 2014 г., в 0:10, Aaro Koskinen написал(а): > I could not see any breakage or anything wrong on OMAP2 & OMAP3. > On OMAP1 I don't have

Re: [PATCH] i2c: omap: fix i207 errata handling

2014-11-21 Thread Felipe Balbi
On Fri, Nov 21, 2014 at 04:16:51AM +0400, Alexander Kochetkov wrote: > commit 6d9939f651419a63e091105663821f9c7d3fec37 (i2c: omap: split out [XR]DR > and [XR]RDY) changed the way how errata i207 (I2C: RDR Flag May Be Incorrectly > Set) get handled. 6d9939f6514 code doesn't correspond to workaround

Re: [PATCH] i2c: omap: fix i207 errata handling

2014-11-20 Thread Alexander Kochetkov
21 нояб. 2014 г., в 3:16, Alexander Kochetkov написал(а): > commit 6d9939f651419a63e091105663821f9c7d3fec37 (i2c: omap: split out [XR]DR > and [XR]RDY) changed the way how errata i207 (I2C: RDR Flag May Be Incorrectly > Set) get handled. It's is seen if open 6d9939f651419a63e09^ and 6d9939f65141

[PATCH] i2c: omap: fix i207 errata handling

2014-11-20 Thread Alexander Kochetkov
commit 6d9939f651419a63e091105663821f9c7d3fec37 (i2c: omap: split out [XR]DR and [XR]RDY) changed the way how errata i207 (I2C: RDR Flag May Be Incorrectly Set) get handled. 6d9939f6514 code doesn't correspond to workaround provided by errata. According to errata ISR must filter out spurious RDR b