Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-24 Thread Tomasz Figa
Hi, On Monday 25 of February 2013 00:16:49 Heiko Stübner wrote: > Am Sonntag, 24. Februar 2013, 23:39:44 schrieb Linus Walleij: > > On Sun, Feb 24, 2013 at 6:00 PM, Tomasz Figa wrote: > > >> > Note that we are talking here about a temporary solution. The > > >> > legacy > > >> > DT- based pin co

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-24 Thread Heiko Stübner
Am Sonntag, 24. Februar 2013, 23:39:44 schrieb Linus Walleij: > On Sun, Feb 24, 2013 at 6:00 PM, Tomasz Figa wrote: > >> > Note that we are talking here about a temporary solution. The legacy > >> > DT- based pin configuration will go away after all the DT-enabled > >> > platforms using this drive

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-24 Thread Linus Walleij
On Sun, Feb 24, 2013 at 6:00 PM, Tomasz Figa wrote: >> > Note that we are talking here about a temporary solution. The legacy >> > DT- based pin configuration will go away after all the DT-enabled >> > platforms using this driver get migrated to pin control and so will >> > the need to check if p

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-24 Thread Tomasz Figa
On Sunday 24 of February 2013 02:01:45 Linus Walleij wrote: > On Sun, Feb 24, 2013 at 1:58 AM, Tomasz Figa wrote: > > [Me] > > > >> Surely you know this when setting up the pdata from your machine? > > > > Cases 2) and 3) are both DT-enabled cases, where there is no pdata > > coming from board-

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-23 Thread Linus Walleij
On Sun, Feb 24, 2013 at 1:58 AM, Tomasz Figa wrote: > [Me] >> Surely you know this when setting up the pdata from your machine? > > Cases 2) and 3) are both DT-enabled cases, where there is no pdata coming > from board-specific code. (...) > Note that we are talking here about a temporary solutio

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-23 Thread Tomasz Figa
On Sunday 24 of February 2013 01:47:49 Linus Walleij wrote: > On Sun, Feb 24, 2013 at 1:38 AM, Tomasz Figa wrote: > > The driver must know whether pin control is available, because it has > > to fall back to legacy GPIO-based pin configuration if it is not. > > This means that we must either chec

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-23 Thread Linus Walleij
On Sun, Feb 24, 2013 at 1:38 AM, Tomasz Figa wrote: > The driver must know whether pin control is available, because it has to > fall back to legacy GPIO-based pin configuration if it is not. This means > that we must either check for NULL (which probably is not right, since > returned handle is

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-23 Thread Tomasz Figa
Hi Linus, On Sunday 24 of February 2013 01:16:21 Linus Walleij wrote: > On Sat, Feb 23, 2013 at 6:57 PM, Heiko Stübner wrote: > > When pinctrl is not built the fallback functions fail silently > > and emit either 0 error codes or NULL pinctrl handles. > > > > Therefore it's needed to also check

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-23 Thread Linus Walleij
On Sat, Feb 23, 2013 at 6:57 PM, Heiko Stübner wrote: > When pinctrl is not built the fallback functions fail silently > and emit either 0 error codes or NULL pinctrl handles. > > Therefore it's needed to also check for this NULL-handle when > falling back to parsing the i2c gpios from devicetree

[PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-23 Thread Heiko Stübner
When pinctrl is not built the fallback functions fail silently and emit either 0 error codes or NULL pinctrl handles. Therefore it's needed to also check for this NULL-handle when falling back to parsing the i2c gpios from devicetree. Signed-off-by: Heiko Stuebner --- drivers/i2c/busses/i2c-s3c