Re: [PATCH]I2C device - release cleanup

2010-03-24 Thread Jean Delvare
On Tue, 23 Mar 2010 19:11:26 +, jhautb...@gmail.com wrote: > > Yes, that would be better. If you do that, please make sure to run your > > > patch through scripts/checkpatch.pl before sending it. > > I will take the time to do it. I can't say when :p. > I did run checkpatch.pl, and I can't re

Re: [PATCH]I2C device - release cleanup

2010-03-23 Thread Jean Delvare
On Tue, 23 Mar 2010 13:02:41 +, jhautb...@gmail.com wrote: > Hi Jean, > > < snip > > > Did you test your patch? I am very skeptical that calling > > > single_release() out of the blue is the right thing to do. My instinct > > > tells me that single_release() is only meant for callers of > >

Re: [PATCH]I2C device - release cleanup

2010-03-23 Thread Jean Delvare
Hi Jean-Michel, On Tue, 23 Mar 2010 11:01:28 +0100, Jean-Michel Hautbois wrote: > Hi there, > > Here is a little patch which aims to cleanup the release function in > i2c-dev.c. > This is only a call to single_release, instead of kfree and several things. > > Signed-off-by: Jean-Michel Hautbois

[PATCH]I2C device - release cleanup

2010-03-23 Thread Jean-Michel Hautbois
Hi there, Here is a little patch which aims to cleanup the release function in i2c-dev.c. This is only a call to single_release, instead of kfree and several things. Signed-off-by: Jean-Michel Hautbois --- drivers/i2c/i2c-dev.c --- linux-2.6.34-rc2/drivers/i2c/i2c-dev.c.orig 2010-03-23 10:19:26