Re: [PATCH 03/10] i2c-designware: retrieve clock frequency based CONFIG_HAVE_CLK

2011-02-08 Thread Dirk Brandewie
On 02/05/2011 09:46 AM, Ben Dooks wrote: On Wed, Feb 02, 2011 at 06:20:01PM -0800, dirk.brande...@gmail.com wrote: From: Dirk Brandewie x86 does not have clk_dev support. The PCI variant of the driver sets the clock rate being supplied to the IP block based on config information attached to th

Re: [PATCH 03/10] i2c-designware: retrieve clock frequency based CONFIG_HAVE_CLK

2011-02-05 Thread Ben Dooks
On Wed, Feb 02, 2011 at 06:20:01PM -0800, dirk.brande...@gmail.com wrote: > From: Dirk Brandewie > > x86 does not have clk_dev support. The PCI variant of the driver sets > the clock rate being supplied to the IP block based on config > information attached to the PCI ID Could you have a set of

Re: [PATCH 03/10] i2c-designware: retrieve clock frequency based CONFIG_HAVE_CLK

2011-02-03 Thread Shinya Kuribayashi
On 2/3/2011 11:20 AM, dirk.brande...@gmail.com wrote: > +u32 i2c_dw_clk_get_rate(struct dw_i2c_dev *dev) > +{ > +#ifndef CONFIG_HAVE_CLK > + return dev->clk_khz; > +#else > + return clk_get_rate(dev->clk)/1000; > +#endif > +} > + As pointed out before, I prefer not use #ifndef like this:

[PATCH 03/10] i2c-designware: retrieve clock frequency based CONFIG_HAVE_CLK

2011-02-02 Thread dirk . brandewie
From: Dirk Brandewie x86 does not have clk_dev support. The PCI variant of the driver sets the clock rate being supplied to the IP block based on config information attached to the PCI ID Signed-off-by: Dirk Brandewie --- drivers/i2c/busses/i2c-designware-core.c | 14 -- drivers