Re: [PATCH 06/15] mfd/ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core

2012-05-14 Thread Linus Walleij
On Mon, May 14, 2012 at 10:41 AM, Lee Jones wrote: > On 09/05/12 13:20, Linus Walleij wrote: >> (...) >> +static int ab8500_i2c_write(struct ab8500 *ab8500, u16 addr, u8 data) >> +static int ab8500_i2c_read(struct ab8500 *ab8500, u16 addr) >> >> As you might have noticed, many people have been co

Re: [PATCH 06/15] mfd/ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core

2012-05-14 Thread Lee Jones
On 09/05/12 13:20, Linus Walleij wrote: On Fri, May 4, 2012 at 8:23 PM, Lee Jones wrote: ab8500-i2c is used as core code to register the ab8500 device. After allocating ab8500 memory, it immediately calls into ab8500-core where the real initialisation takes place. This patch moves all core reg

Re: [PATCH 06/15] mfd/ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core

2012-05-09 Thread Linus Walleij
On Fri, May 4, 2012 at 8:23 PM, Lee Jones wrote: > ab8500-i2c is used as core code to register the ab8500 device. > After allocating ab8500 memory, it immediately calls into > ab8500-core where the real initialisation takes place. This > patch moves all core registration and memory allocation int

Re: [PATCH 06/15] mfd/ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core

2012-05-07 Thread Mark Brown
On Fri, May 04, 2012 at 07:23:16PM +0100, Lee Jones wrote: > ab8500-i2c is used as core code to register the ab8500 device. > After allocating ab8500 memory, it immediately calls into > ab8500-core where the real initialisation takes place. This > patch moves all core registration and memory alloca

Re: [PATCH 06/15] mfd/ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core

2012-05-04 Thread Lee Jones
Whoops, I put that comment in the wrong place. Let me amend: On 04/05/12 22:24, Lee Jones wrote: On 04/05/12 21:25, Arnd Bergmann wrote: On Friday 04 May 2012, Lee Jones wrote: ab8500-i2c is used as core code to register the ab8500 device. After allocating ab8500 memory, it immediately calls

Re: [PATCH 06/15] mfd/ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core

2012-05-04 Thread Lee Jones
On 04/05/12 21:25, Arnd Bergmann wrote: On Friday 04 May 2012, Lee Jones wrote: ab8500-i2c is used as core code to register the ab8500 device. After allocating ab8500 memory, it immediately calls into ab8500-core where the real initialisation takes place. This patch moves all core registration

Re: [PATCH 06/15] mfd/ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core

2012-05-04 Thread Arnd Bergmann
On Friday 04 May 2012, Lee Jones wrote: > > ab8500-i2c is used as core code to register the ab8500 device. > After allocating ab8500 memory, it immediately calls into > ab8500-core where the real initialisation takes place. This > patch moves all core registration and memory allocation into > the

[PATCH 06/15] mfd/ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core

2012-05-04 Thread Lee Jones
ab8500-i2c is used as core code to register the ab8500 device. After allocating ab8500 memory, it immediately calls into ab8500-core where the real initialisation takes place. This patch moves all core registration and memory allocation into the true ab8500-core file and removes ab8500-i2c complete