Re: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-14 Thread Shinya Kuribayashi
Ben, Mark and Russell, Russell King - ARM Linux wrote: [ big snip ] I would strongly advise you to ensure that your implementation conforms to the intentions of the clk API Thanks for kind explanations. I'd like to give the clkdev a try. -- Shinya Kuribayashi NEC Electronics -- To unsubscribe

Re: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-14 Thread Russell King - ARM Linux
On Wed, Oct 14, 2009 at 01:19:23PM +0900, Shinya Kuribayashi wrote: > # As you can imagine, my local clk implementation is based on > "clk_id" name matching, which looks simple for me. ... but totally wrong, and will eventually bite you. Please use clkdev and use the device names for the primary

Re: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-14 Thread Mark Brown
On Wed, Oct 14, 2009 at 01:19:23PM +0900, Shinya Kuribayashi wrote: > * And clk_get() is expected to pick up a clock source with: > 1) dev_id + clk_id ... strict matching condition (default) > 2) dev_id only ... fuzzy extension1 (clk_id can be regarded as wildcard) > 3) clk_id only ... fuzzy exte

Re: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-13 Thread Shinya Kuribayashi
Mark Brown wrote: On Tue, Oct 13, 2009 at 11:50:49AM +0900, Shinya Kuribayashi wrote: This driver is originally prepared for the ARM kernel where rich and well-maintained "clkdev" clock framework is available, and clock name might not be strictly required. ARM's clkdev does slightly fuzzy match

Re: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-13 Thread Shinya Kuribayashi
Ben Dooks wrote: On Tue, Oct 13, 2009 at 11:50:49AM +0900, Shinya Kuribayashi wrote: This driver is originally prepared for the ARM kernel where rich and well-maintained "clkdev" clock framework is available, and clock name might not be strictly required. ARM's clkdev does slightly fuzzy matchi

Re: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-13 Thread Ben Dooks
On Tue, Oct 13, 2009 at 11:50:49AM +0900, Shinya Kuribayashi wrote: > This driver is originally prepared for the ARM kernel where rich and > well-maintained "clkdev" clock framework is available, and clock name > might not be strictly required. ARM's clkdev does slightly fuzzy > matching where it

FW: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-13 Thread Olivares, Ricardo Perez
...@lists.infradead.org Subject: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source This driver is originally prepared for the ARM kernel where rich and well-maintained "clkdev" clock framework is available, and clock name might not be strictly required. AR

FW: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-13 Thread Olivares, Ricardo Perez
...@lists.infradead.org Subject: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source This driver is originally prepared for the ARM kernel where rich and well-maintained "clkdev" clock framework is available, and clock name might not be strictly required. AR

FW: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-13 Thread Olivares, Ricardo Perez
...@lists.infradead.org Subject: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source This driver is originally prepared for the ARM kernel where rich and well-maintained "clkdev" clock framework is available, and clock name might not be strictly required. AR

FW: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-13 Thread Olivares, Ricardo Perez
...@lists.infradead.org; ben-li...@fluff.org Subject: Re: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source On Tue, Oct 13, 2009 at 11:50:49AM +0900, Shinya Kuribayashi wrote: > This driver is originally prepared for the ARM kernel where rich and > well-maintained "cl

Re: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-13 Thread Mark Brown
On Tue, Oct 13, 2009 at 11:50:49AM +0900, Shinya Kuribayashi wrote: > This driver is originally prepared for the ARM kernel where rich and > well-maintained "clkdev" clock framework is available, and clock name > might not be strictly required. ARM's clkdev does slightly fuzzy > matching where it

[PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-12 Thread Shinya Kuribayashi
This driver is originally prepared for the ARM kernel where rich and well-maintained "clkdev" clock framework is available, and clock name might not be strictly required. ARM's clkdev does slightly fuzzy matching where it basically gives preference to "struct device" mathing over "clock id". As