Re: [PATCH 1/3] i2c: i801: refactor i801_block_transaction_byte_by_byte

2012-06-19 Thread Jean Delvare
Hi Daniel, Sorry for the very late reply, I'm only reviewing this patch series now. On Fri, 6 Jan 2012 18:58:20 +0800, Daniel Kurtz wrote: > 1) As a slight optimization, pull some logic out of the byte loop during > byte-by-byte transactions by just setting the I801_LAST_BYTE bit, as > defined i

[PATCH 1/3] i2c: i801: refactor i801_block_transaction_byte_by_byte

2012-01-06 Thread Daniel Kurtz
1) As a slight optimization, pull some logic out of the byte loop during byte-by-byte transactions by just setting the I801_LAST_BYTE bit, as defined in the i801 (PCH) datasheet, when reading the last byte of a byte-by-byte I2C_SMBUS_READ. 2) Clear INTR after clearing BYTE_DONE per ICH10 datasheet

[PATCH 1/3] i2c: i801: refactor i801_block_transaction_byte_by_byte

2011-12-13 Thread Daniel Kurtz
1) As a slight optimization, pull some logic out of the byte loop during byte-by-byte transactions by just setting the I801_LAST_BYTE bit, as defined in the i801 (PCH) datasheet, when reading the last byte of a byte-by-byte I2C_SMBUS_READ. 2) Clear INTR after clearing BYTE_DONE per ICH10 datasheet