Re: [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support

2013-08-09 Thread Wolfram Sang
Does it mean that once I will have added the handle of this string, you will be able to take the series for the 3.12 kernel? Most looks good. The only thing I noticed from a glimpse is that maybe you could use be32_to_cpu or something instead of shifting 8 bit chunks out of the data_hi/lo? --

Re: [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support

2013-08-08 Thread Gregory CLEMENT
On 07/08/2013 17:57, Jason Cooper wrote: On Wed, Aug 07, 2013 at 04:35:46PM +0200, Wolfram Sang wrote: But we shouldn't use it alone: we should always use: compatible = marvell,mv78230-i2c, marvell,mv64xxx-i2c; From my point of view using marvell,mv78230-i2c alone is an error. Wolfram

Re: [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support

2013-08-07 Thread Wolfram Sang
But we shouldn't use it alone: we should always use: compatible = marvell,mv78230-i2c, marvell,mv64xxx-i2c; From my point of view using marvell,mv78230-i2c alone is an error. Wolfram what is your opinion on it? It is not strictly an error, but risky. If you use an older Kernel version

Re: [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support

2013-08-07 Thread Jason Cooper
On Wed, Aug 07, 2013 at 04:35:46PM +0200, Wolfram Sang wrote: But we shouldn't use it alone: we should always use: compatible = marvell,mv78230-i2c, marvell,mv64xxx-i2c; From my point of view using marvell,mv78230-i2c alone is an error. Wolfram what is your opinion on it? It is

Re: [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support

2013-08-06 Thread Maxime Ripard
On Tue, Aug 06, 2013 at 02:05:24PM +0200, Gregory CLEMENT wrote: On 16/07/2013 10:05, Maxime Ripard wrote: Hi Gregory, On Mon, Jul 15, 2013 at 04:24:36PM +0200, Gregory CLEMENT wrote: The I2C Transaction Generator offloads CPU from managing I2C transfer step by step. This feature

Re: [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support

2013-08-06 Thread Thomas Petazzoni
Dear Gregory CLEMENT, On Tue, 06 Aug 2013 14:05:24 +0200, Gregory CLEMENT wrote: But we shouldn't use it alone: we should always use: compatible = marvell,mv78230-i2c, marvell,mv64xxx-i2c; From my point of view using marvell,mv78230-i2c alone is an error. I disagree. I believe the driver

[PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support

2013-07-15 Thread Gregory CLEMENT
The I2C Transaction Generator offloads CPU from managing I2C transfer step by step. This feature is currently only available on Armada XP, so usage of this mechanism is activated through device tree. Based on the work of Piotr Ziecik and rewrote to use the new way of handling multiples i2c