Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-09-21 Thread Simon Horman
On Fri, Sep 19, 2014 at 07:18:51PM +0200, Wolfram Sang wrote: This approach has no effect to current feature, and can keep compatible for current and future, and can reduce / cleanup driver in the future. I defer the patch series for now. Maybe we should talk about it at our next

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-09-19 Thread Wolfram Sang
This approach has no effect to current feature, and can keep compatible for current and future, and can reduce / cleanup driver in the future. I defer the patch series for now. Maybe we should talk about it at our next meeting? -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-07 Thread Kuninori Morimoto
Hi Magnus With this in mind I think the best way forward is as follows: A) Keep on using per-SoC compatible string unless it is documented somewhere and in parallel B) Work on getting per-device hardware version number from hardware device team (snip) From my point of view your proposal

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Simon Horman
On Tue, Aug 05, 2014 at 09:40:12PM -0700, Kuninori Morimoto wrote: From: Kuninori Morimoto kuninori.morimoto...@renesas.com This patch adds DT compatible for Renesas R-Car Gen1/Gen2. Current driver has SoC level .compatible (r8a7778/r8a7779/r8a7790/r8a7791/r8a7792/r8a7793/r8a7794), but

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Kuninori Morimoto
Hi Simon From: Kuninori Morimoto kuninori.morimoto...@renesas.com This patch adds DT compatible for Renesas R-Car Gen1/Gen2. Current driver has SoC level .compatible (r8a7778/r8a7779/r8a7790/r8a7791/r8a7792/r8a7793/r8a7794), but these can be match as generation level. Hi

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Simon Horman
On Wed, Aug 06, 2014 at 05:36:37PM -0700, Kuninori Morimoto wrote: Hi Simon From: Kuninori Morimoto kuninori.morimoto...@renesas.com This patch adds DT compatible for Renesas R-Car Gen1/Gen2. Current driver has SoC level .compatible

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Kuninori Morimoto
Hi Simon At our face-to-face meeting in Montpellier we discussed the idea of generation bindings. And my recollection is that Magnus and I had strong reservations about declaring what generation compatibility is without it being explicitly stated in hardware documentation. From

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Magnus Damm
Hi Morimoto-san, On Thu, Aug 7, 2014 at 11:43 AM, Kuninori Morimoto kuninori.morimoto...@gmail.com wrote: Hi Simon At our face-to-face meeting in Montpellier we discussed the idea of generation bindings. And my recollection is that Magnus and I had strong reservations about declaring what

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Kuninori Morimoto
Hi Magnus The problem is that gen2 is not something that is pre-defined. As you may have noticed earlier, new SoCs keep on coming and even though they may be part of gen2 they may or may not be compatible with the gen2 compatible string. So based on that, if we use the SoC part number in

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Magnus Damm
Hi Morimoto-san, Thanks for your comments! On Thu, Aug 7, 2014 at 2:19 PM, Kuninori Morimoto kuninori.morimoto...@gmail.com wrote: Hi Magnus The problem is that gen2 is not something that is pre-defined. As you may have noticed earlier, new SoCs keep on coming and even though they may be

[PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-05 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com This patch adds DT compatible for Renesas R-Car Gen1/Gen2. Current driver has SoC level .compatible (r8a7778/r8a7779/r8a7790/r8a7791/r8a7792/r8a7793/r8a7794), but these can be match as generation level. Signed-off-by: Kuninori Morimoto