> Although I don't think there is any need to add clearing to probe path as
> clearing happens beginning of transmit before enabling the interrupts.
Well, in case the firmware left interrupts dangling, they would still be
dangling unless someone starts some communication. Chances are small,
but b
On 10/10/2015 10:53 AM, Wolfram Sang wrote:
On Mon, Aug 31, 2015 at 05:31:28PM +0300, Jarkko Nikula wrote:
There is no need to clear interrupts in i2c_dw_pci_probe() since only place
where interrupts are unmasked is i2c_dw_xfer_init() and there interrupts
are always cleared after commit 2a2d95e9
On Mon, Aug 31, 2015 at 05:31:28PM +0300, Jarkko Nikula wrote:
> There is no need to clear interrupts in i2c_dw_pci_probe() since only place
> where interrupts are unmasked is i2c_dw_xfer_init() and there interrupts
> are always cleared after commit 2a2d95e9d6d2 ("i2c: designware: always
> clear in
There is no need to clear interrupts in i2c_dw_pci_probe() since only place
where interrupts are unmasked is i2c_dw_xfer_init() and there interrupts
are always cleared after commit 2a2d95e9d6d2 ("i2c: designware: always
clear interrupts before enabling them").
This allows to cleanup the code and r