Re: [PATCH 3/4] gpio: Kontron PLD gpio driver

2013-04-12 Thread Michael Brunner
Hi Linus, As this code is from me I will comment on your review. On Wed, 10 Apr 2013 22:45:51 +0200 Linus Walleij linus.wall...@linaro.org wrote: (...) Trying to do some real review... (...) +++ b/drivers/gpio/gpio-kempld.c +#include linux/acpi.h Is this used? Actually not,

Re: [PATCH 3/4] gpio: Kontron PLD gpio driver

2013-04-12 Thread Linus Walleij
On Fri, Apr 12, 2013 at 1:09 PM, Michael Brunner mi...@gmx.de wrote: (...) +struct kempld_gpio_data { + struct gpio_chipchip; + int irq; + struct kempld_device_data *pld; + uint16_tmask;

Re: [PATCH 3/4] gpio: Kontron PLD gpio driver

2013-04-10 Thread Linus Walleij
On Tue, Apr 9, 2013 at 6:41 PM, Guenter Roeck li...@roeck-us.net wrote: On Tue, Apr 09, 2013 at 10:46:15AM +0200, Linus Walleij wrote: On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser kevin.stras...@linux.intel.com wrote: From: Michael Brunner michael.brun...@kontron.com Add gpio support

Re: [PATCH 3/4] gpio: Kontron PLD gpio driver

2013-04-10 Thread Linus Walleij
On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser kevin.stras...@linux.intel.com wrote: From: Michael Brunner michael.brun...@kontron.com Add gpio support for the on-board PLD found on some Kontron embedded modules. Signed-off-by: Michael Brunner michael.brun...@kontron.com Signed-off-by:

Re: [PATCH 3/4] gpio: Kontron PLD gpio driver

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 10:46:15AM +0200, Linus Walleij wrote: On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser kevin.stras...@linux.intel.com wrote: From: Michael Brunner michael.brun...@kontron.com Add gpio support for the on-board PLD found on some Kontron embedded modules.

[PATCH 3/4] gpio: Kontron PLD gpio driver

2013-04-08 Thread Kevin Strasser
From: Michael Brunner michael.brun...@kontron.com Add gpio support for the on-board PLD found on some Kontron embedded modules. Signed-off-by: Michael Brunner michael.brun...@kontron.com Signed-off-by: Kevin Strasser kevin.stras...@linux.intel.com --- drivers/gpio/Kconfig| 22 ++