Re: [PATCH v2] HID: support i2c write-read and large transfers in hid-cp2112

2015-06-18 Thread Ellen Wang
I'll do that, and use the quirks mechanism, too. Stay tuned. On 06/18/2015 01:26 AM, Wolfram Sang wrote: Mine is rev 1 !!! Found also that in the datasheet chapter 12 reports the differences between the two revisions. In 12.1 it states that revision 1 does not implement repeated start.

Re: [PATCH v2] HID: support i2c write-read and large transfers in hid-cp2112

2015-06-18 Thread Antonio Borneo
On Thu, Jun 18, 2015 at 4:26 PM, Wolfram Sang w...@the-dreams.de wrote: Mine is rev 1 !!! Found also that in the datasheet chapter 12 reports the differences between the two revisions. In 12.1 it states that revision 1 does not implement repeated start. Perfect! I will try to replace my

Re: [PATCH v2] HID: support i2c write-read and large transfers in hid-cp2112

2015-06-18 Thread Antonio Borneo
On Thu, Jun 18, 2015 at 8:55 AM, Ellen Wang el...@cumulusnetworks.com wrote: ... Since the the long-read fix is less controversial, I've split it out and sent it as a separate patch. Hi Ellen, got it, will check soon As for repeated start, it's not that easy for me to check it. The chip

Re: [PATCH v2] HID: support i2c write-read and large transfers in hid-cp2112

2015-06-18 Thread Wolfram Sang
Mine is rev 1 !!! Found also that in the datasheet chapter 12 reports the differences between the two revisions. In 12.1 it states that revision 1 does not implement repeated start. Perfect! I will try to replace my device with a newer one. Can this be checked in the code? signature.asc

Re: [PATCH v2] HID: support i2c write-read and large transfers in hid-cp2112

2015-06-17 Thread Ellen Wang
On 06/15/2015 02:10 AM, Antonio Borneo wrote: On Sat, Jun 13, 2015 at 4:26 PM, Ellen Wang el...@cumulusnetworks.com wrote: cp2112_i2c_xfer() only supports a single i2c_msg and only reads up to 61 bytes. More than one message at a time and longers reads just return errors. This breaks certain

Re: [PATCH v2] HID: support i2c write-read and large transfers in hid-cp2112

2015-06-15 Thread Antonio Borneo
On Sat, Jun 13, 2015 at 4:26 PM, Ellen Wang el...@cumulusnetworks.com wrote: cp2112_i2c_xfer() only supports a single i2c_msg and only reads up to 61 bytes. More than one message at a time and longers reads just return errors. This breaks certain important cases. For example, the at24

[PATCH v2] HID: support i2c write-read and large transfers in hid-cp2112

2015-06-13 Thread Ellen Wang
cp2112_i2c_xfer() only supports a single i2c_msg and only reads up to 61 bytes. More than one message at a time and longers reads just return errors. This breaks certain important cases. For example, the at24 eeprom driver generates paired write and read messages (for eeprom address and data).