Re: [PATCH v2 0/1] PN544 NFC driver.

2010-11-01 Thread Matti J. Aaltonen
Hi. On Fri, 2010-10-29 at 14:33 -0700, ext Andrew Morton wrote: On Fri, 29 Oct 2010 09:26:08 +0300 Matti J. Aaltonen matti.j.aalto...@nokia.com wrote: Hello. And thanks to Andrew for the comments. include/linux/pn544.h | 99 ++ Is drivers/misc/ the best place for

Re: [PATCH v2 0/1] PN544 NFC driver.

2010-11-01 Thread Matti J. Aaltonen
On Fri, 2010-10-29 at 23:50 +0100, ext Mark Brown wrote: On Fri, Oct 29, 2010 at 02:33:33PM -0700, Andrew Morton wrote: Another consideration here is that if we do expect more NFC devices and drivers for them, then we should aim for some standardisation of the interface, from day one.

Re: [PATCH v2 0/1] PN544 NFC driver.

2010-11-01 Thread Mark Brown
On Mon, Nov 01, 2010 at 02:25:25PM +0200, Matti J. Aaltonen wrote: On Fri, 2010-10-29 at 23:50 +0100, ext Mark Brown wrote: There's other NFC devices out there being used with Linux. But NFC drivers are not easy to find. In the kernel code drivers/parisc/pdc_stable.c contains the following

[PATCH v2 0/1] PN544 NFC driver.

2010-10-29 Thread Matti J. Aaltonen
Hello. And thanks to Andrew for the comments. include/linux/pn544.h | 99 ++ Is drivers/misc/ the best place for this? Don't be afraid to create a new drivers/nfc/ even if it has only one driver in it. If someone later comes in and adds a new NFC driver then things will all fall

Re: [PATCH v2 0/1] PN544 NFC driver.

2010-10-29 Thread Andrew Morton
On Fri, 29 Oct 2010 09:26:08 +0300 Matti J. Aaltonen matti.j.aalto...@nokia.com wrote: Hello. And thanks to Andrew for the comments. include/linux/pn544.h | 99 ++ Is drivers/misc/ the best place for this? Don't be afraid to create a new drivers/nfc/ even if it has only one

Re: [PATCH v2 0/1] PN544 NFC driver.

2010-10-29 Thread Mark Brown
On Fri, Oct 29, 2010 at 02:33:33PM -0700, Andrew Morton wrote: Another consideration here is that if we do expect more NFC devices and drivers for them, then we should aim for some standardisation of the interface, from day one. Some discussion of this would also be helpful for reviewers.