Re: [PATCH v2 05/10] i2c: rcar: refactor setup of a msg

2015-11-18 Thread Magnus Damm
Hi Wolfram, On Wed, Nov 18, 2015 at 5:07 PM, Wolfram Sang wrote: > >> On Lager it seems that the GP5_5/GP_6 pins with the I2C2 bus for the >> ADV7511 chip has more flexible configuration, so using either IIC or >> I2C should be possible. You can sample those pins on EXIO_A with the >> ZEBAX break

Re: [PATCH v2 05/10] i2c: rcar: refactor setup of a msg

2015-11-18 Thread Wolfram Sang
> On Lager it seems that the GP5_5/GP_6 pins with the I2C2 bus for the > ADV7511 chip has more flexible configuration, so using either IIC or > I2C should be possible. You can sample those pins on EXIO_A with the > ZEBAX break out adapter. Yes, that's what I basically did here for developing the

Re: [PATCH v2 05/10] i2c: rcar: refactor setup of a msg

2015-11-17 Thread Wolfram Sang
> can continue that on Lager. In the meantime I could also capture I2C traces > using a scope and send them to you. Cool, thanks! I think I'll start with sending you another trace-printk patch soon. And can you push the branch you were using somewhere? With the config as an additional commit?

Re: [PATCH v2 05/10] i2c: rcar: refactor setup of a msg

2015-11-17 Thread Laurent Pinchart
Hi Magnus, On Wednesday 18 November 2015 11:18:00 Magnus Damm wrote: > On Tue, Nov 17, 2015 at 4:00 PM, Wolfram Sang wrote: > > Hi Laurent, > > > >> Sorry for bringing bad news, but as with v1, this patch breaks ADV7511 > >> detection on my Koelsch board. Reverting it on top of the series fixes

Re: [PATCH v2 05/10] i2c: rcar: refactor setup of a msg

2015-11-17 Thread Magnus Damm
Hi Wolfram, On Tue, Nov 17, 2015 at 4:00 PM, Wolfram Sang wrote: > Hi Laurent, > >> Sorry for bringing bad news, but as with v1, this patch breaks ADV7511 >> detection on my Koelsch board. Reverting it on top of the series fixes the >> problem. > > In v1, patch 5/9 was breaking. I hope in v2, it

Re: [PATCH v2 05/10] i2c: rcar: refactor setup of a msg

2015-11-16 Thread Laurent Pinchart
Hi Wolfram, On Tuesday 17 November 2015 08:00:53 Wolfram Sang wrote: > Hi Laurent, > > > Sorry for bringing bad news, but as with v1, this patch breaks ADV7511 > > detection on my Koelsch board. Reverting it on top of the series fixes the > > problem. > > In v1, patch 5/9 was breaking. I hope in

Re: [PATCH v2 05/10] i2c: rcar: refactor setup of a msg

2015-11-16 Thread Wolfram Sang
Hi Laurent, > Sorry for bringing bad news, but as with v1, this patch breaks ADV7511 > detection on my Koelsch board. Reverting it on top of the series fixes the > problem. In v1, patch 5/9 was breaking. I hope in v2, it is 6/10 and not 5/10 as you replied to (patch 1/10 is the new one)? This b

Re: [PATCH v2 05/10] i2c: rcar: refactor setup of a msg

2015-11-16 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. Sorry for bringing bad news, but as with v1, this patch breaks ADV7511 detection on my Koelsch board. Reverting it on top of the series fixes the problem. You'll find the dmesg and trace logs with your debugging patch applied attached to this e-mail in two

[PATCH v2 05/10] i2c: rcar: refactor setup of a msg

2015-11-12 Thread Wolfram Sang
From: Wolfram Sang We want to reuse this function later. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-rcar.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 0f2dc74ab8bcc1..4bd3099