Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-19 Thread Samuel Ortiz
Hi Wolfram, On Wed, Jun 19, 2013 at 12:00:20PM +0200, Wolfram Sang wrote: > > > Applied with Stephen's Reviewed-by, thanks. > > According to Wolfgang, this is not needed as he will revert the i2c > > commits that are causing those crashes. > > I would not take it for now. > > "Wolfram", please ;)

Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-19 Thread Wolfram Sang
On Wed, Jun 19, 2013 at 10:27:40AM +0200, Samuel Ortiz wrote: > Hi Lee, > > On Wed, Jun 19, 2013 at 09:18:59AM +0100, Lee Jones wrote: > > On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > > > > > Commit "i2c: core: make it possible to match a pure device tree driver" > > > changed semantics of the

Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-19 Thread Lee Jones
On Wed, 19 Jun 2013, Samuel Ortiz wrote: > Hi Lee, > > On Wed, Jun 19, 2013 at 09:18:59AM +0100, Lee Jones wrote: > > On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > > > > > Commit "i2c: core: make it possible to match a pure device tree driver" > > > changed semantics of the i2c probing for devi

Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-19 Thread Samuel Ortiz
Hi Lee, On Wed, Jun 19, 2013 at 09:18:59AM +0100, Lee Jones wrote: > On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > > > Commit "i2c: core: make it possible to match a pure device tree driver" > > changed semantics of the i2c probing for device tree devices. > > Device tree probed devices now get

Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-19 Thread Lee Jones
On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > Commit "i2c: core: make it possible to match a pure device tree driver" > changed semantics of the i2c probing for device tree devices. > Device tree probed devices now get a NULL i2c_device_id pointer. > This caused kernel panics due to NULL derefere

Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-18 Thread Stephen Warren
On 06/18/2013 04:14 AM, Tuomas Tynkkynen wrote: > Commit "i2c: core: make it possible to match a pure device tree driver" > changed semantics of the i2c probing for device tree devices. > Device tree probed devices now get a NULL i2c_device_id pointer. > This caused kernel panics due to NULL derefe

[PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-18 Thread Tuomas Tynkkynen
Commit "i2c: core: make it possible to match a pure device tree driver" changed semantics of the i2c probing for device tree devices. Device tree probed devices now get a NULL i2c_device_id pointer. This caused kernel panics due to NULL dereference. Moves the of_match_device call from tps65910_par