Re: [PATCH v2 2/4] Documentation: i2c: describe the new slave mode

2015-04-01 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, Mar 23, 2015 at 9:26 AM, Wolfram Sang w...@the-dreams.de wrote: --- /dev/null +++ b/Documentation/i2c/slave-interface +I2C slave events + + +The bus driver sends an event to the backend using the following function: + + ret =

Re: [PATCH v2 2/4] Documentation: i2c: describe the new slave mode

2015-04-01 Thread Wolfram Sang
On Wed, Apr 01, 2015 at 02:17:47PM +0200, Geert Uytterhoeven wrote: Hi Wolfram, On Mon, Mar 23, 2015 at 9:26 AM, Wolfram Sang w...@the-dreams.de wrote: --- /dev/null +++ b/Documentation/i2c/slave-interface +I2C slave events + + +The bus driver sends an event to

Re: [PATCH v2 2/4] Documentation: i2c: describe the new slave mode

2015-03-23 Thread Uwe Kleine-König
Hello Wolfram, On Mon, Mar 23, 2015 at 09:26:37AM +0100, Wolfram Sang wrote: +Developer manual + + +I2C slave events + + +The bus driver sends an event to the backend using the following function: + + ret = i2c_slave_event(client, event, val) +

Re: [PATCH v2 2/4] Documentation: i2c: describe the new slave mode

2015-03-23 Thread Wolfram Sang
I don't understand why you want to force a valid pointer here. According to my sense of defensive programming I'd say: If the bus driver doesn't expect the slave to consume/provide a value, let's pass NULL to notice the assumption being wrong. The wording is fine, now. For me, an OOPS is

[PATCH v2 2/4] Documentation: i2c: describe the new slave mode

2015-03-23 Thread Wolfram Sang
From: Wolfram Sang wsa+rene...@sang-engineering.com Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com --- Changes since V1: * fixed all minor issues found by Geert * fixed all minor issues found by Uwe * made clear that NULL is not allowed as third parameter * reworded the paragraph