Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-09 Thread Octavian Purdila
On Tue, Sep 9, 2014 at 12:36 PM, Johan Hovold wrote: > On Fri, Sep 05, 2014 at 07:04:51PM +0300, Octavian Purdila wrote: >> On Fri, Sep 5, 2014 at 6:38 PM, Johan Hovold wrote: >> > On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > >> > In general, how well have these patches bee

Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-09 Thread Johan Hovold
On Fri, Sep 05, 2014 at 07:04:51PM +0300, Octavian Purdila wrote: > On Fri, Sep 5, 2014 at 6:38 PM, Johan Hovold wrote: > > On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > > In general, how well have these patches been tested with disconnect > > events? At least gpiolib is kno

Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-08 Thread Johan Hovold
On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > --- /dev/null > +++ b/drivers/gpio/gpio-dln2.c > @@ -0,0 +1,537 @@ > +/* > + * Driver for the Diolan DLN-2 USB-GPIO adapter > + * > + * Copyright (c) 2014 Intel Corporation > + * > + * This program is free software; you can redist

Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-08 Thread Johan Hovold
On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > From: Daniel Baluta > > This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module. > > Information about the USB protocol interface can be found in the > Programmer's Reference Manual [1], see section 2.9 for the GPI

Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-05 Thread Octavian Purdila
On Fri, Sep 5, 2014 at 6:38 PM, Johan Hovold wrote: > On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > >> +static int dln2_do_remove(struct dln2_gpio *dln2) >> +{ >> + /* When removing the DLN2 USB device, gpiochip_remove may fail >> + * due to i2c drivers holding a GPI

Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-05 Thread Johan Hovold
On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > +static int dln2_do_remove(struct dln2_gpio *dln2) > +{ > + /* When removing the DLN2 USB device, gpiochip_remove may fail > + * due to i2c drivers holding a GPIO pin. However, the i2c bus > + * will eventually be re

[PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-05 Thread Octavian Purdila
From: Daniel Baluta This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 2.9 for the GPIO module commands and responses. [1] https://www.diolan.com/downloads/dln-api