Hi Carsten,
Carsten Behling wrote on 2011-11-23:
> I think it must be:
>
> + for (i = 0; i < msg->len; ++i) {
> + internal_address |= ((unsigned)msg->buf[msg->len-1-i])
> << (8 * i);
> + int_addr_flag += AT91_TWI_IADRSZ_1;
> + }
> +
ann.de]
Gesendet: Mittwoch, 23. November 2011 11:29
An: Carsten Behling
Cc: 'linux-i2c@vger.kernel.org'; 'linux-arm-ker...@lists.infradead.org';
'linux-ker...@vger.kernel.org'
Betreff: RE: [PATCH v5 3/4] drivers/i2c/busses/i2c-at91.c: add new driver
he Nachricht-
Von: Voss, Nikolaus [mailto:n.v...@weinmann.de]
Gesendet: Dienstag, 22. November 2011 17:26
An: Carsten Behling
Cc: 'linux-i2c@vger.kernel.org'; 'linux-arm-ker...@lists.infradead.org';
'linux-ker...@vger.kernel.org'
Betreff: RE: [PATCH v5 3/4] drivers/
Hi,
Carsten Behling wrote on 2011-11-23:
>> this case is already catched in at91_do_twi_transfer():
>
> Sorry, I did not found this code in your patch.
> (http://www.mail-archive.com/linux-i2c@vger.kernel.org/msg06556.html):
>
>> + if (is_read) {
>> + if (!dev->buf_len)
yes
Hi,
Carsten Behling wrote on 2011-11-22:
> +static void at91_twi_read_next_byte(struct at91_twi_dev *dev)
> +{
> + *dev->buf = at91_twi_read(dev, AT91_TWI_RHR) & 0xff;
> +
> + /* send stop if second but last byte has been read */
> + if (--dev->buf_len == 1)
> + at9
On Tue, Nov 08, 2011 at 11:49:46AM +0100, Nikolaus Voss wrote:
> This driver has the following properties compared to the old driver:
> 1. Support for multiple interfaces.
> 2. Interrupt driven I/O as opposed to polling/busy waiting.
> 3. Support for _one_ repeated start (Sr) condition, which is en
This driver has the following properties compared to the old driver:
1. Support for multiple interfaces.
2. Interrupt driven I/O as opposed to polling/busy waiting.
3. Support for _one_ repeated start (Sr) condition, which is enough
for most real-world applications including all SMBus transfer t
