Re: [PATCH v5 3/4] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014, Gregory CLEMENT wrote: > On 08/01/2014 16:21, Wolfram Sang wrote: > >> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c > >> b/drivers/i2c/busses/i2c-mv64xxx.c > >> index 8be7e42aa4de..f424c0f89946 100644 > >> --- a/drivers/i2c/busses/i2c-mv64xxx.c > >> +++ b/drivers/i2

Re: [PATCH v5 3/4] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs

2014-01-08 Thread Wolfram Sang
> >> + { > >> + .compatible = "marvell,mv78230-a0-i2c", > >> + .data = &mv64xxx_i2c_regs_mv64xxx > >> + }, > > > > I think a oneliner entry like the entries above is easier to read, but > > that is very minor... > > By using one line we would break the 80 character rule, > hat

Re: [PATCH v5 3/4] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs

2014-01-08 Thread Gregory CLEMENT
On 08/01/2014 16:21, Wolfram Sang wrote: > On Wed, Jan 08, 2014 at 04:06:28PM +0100, Gregory CLEMENT wrote: >> The first variants of Armada XP SoCs (A0 stepping) have issues related >> to the i2c controller which prevent to use the offload mechanism and >> lead to a kernel hang during boot. >> >> T

Re: [PATCH v5 3/4] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs

2014-01-08 Thread Wolfram Sang
On Wed, Jan 08, 2014 at 04:06:28PM +0100, Gregory CLEMENT wrote: > The first variants of Armada XP SoCs (A0 stepping) have issues related > to the i2c controller which prevent to use the offload mechanism and > lead to a kernel hang during boot. > > The commit introduces a new the compatible strin

[PATCH v5 3/4] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs

2014-01-08 Thread Gregory CLEMENT
The first variants of Armada XP SoCs (A0 stepping) have issues related to the i2c controller which prevent to use the offload mechanism and lead to a kernel hang during boot. The commit introduces a new the compatible string marvell,mv78230-a0-i2c for the i2c controller. When this compatible strin