Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-21 Thread Eddie Huang
Hi, Please see my reply below (I skip comments that already reply in another mail). On Wed, 2015-05-20 at 10:57 +0200, Uwe Kleine-König wrote: > Hello, > > now that I understood the formula some more comments to the calculation. > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: >

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-20 Thread Uwe Kleine-König
Hello, On Wed, May 20, 2015 at 09:03:40PM +0800, Yingjoe Chen wrote: > On Wed, 2015-05-20 at 10:57 +0200, Uwe Kleine-König wrote: > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > > > + if (i2c->speed_hz > MAX_HS_MODE_SPEED) > > > + return -EINVAL; > > According to the pla

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-19 Thread Yingjoe Chen
On Tue, 2015-05-19 at 16:48 +0200, Matthias Brugger wrote: > 2015-05-18 20:43 GMT+02:00 Uwe Kleine-König : <...> > >> --- /dev/null > >> +++ b/drivers/i2c/busses/i2c-mt65xx.c > >> @@ -0,0 +1,675 @@ > >> +/* > >> + * Copyright (c) 2014 MediaTek Inc. > >> + * Author: Xudong.chen > > s/Xudong.chen/Xu