Re: [PATCHv2 5/5] i2c: i801: Use managed pcim_* PCI device initialization and reservation

2015-02-13 Thread Jean Delvare
Hi Jarkko, On Wed, 11 Feb 2015 14:32:08 +0200, Jarkko Nikula wrote: Simplifies the code a bit and makes easier to disable PCI device on driver detach by removing the pcim_pin_device() call in the future if needed. Reason why i2c-i801.c doesn't ever call pci_disable_device() was because it

Re: [PATCHv2 5/5] i2c: i801: Use managed pcim_* PCI device initialization and reservation

2015-02-13 Thread Jean Delvare
On Fri, 13 Feb 2015 13:47:07 +0200, Jarkko Nikula wrote: On 02/13/2015 12:47 PM, Jean Delvare wrote: On Wed, 11 Feb 2015 14:32:08 +0200, Jarkko Nikula wrote: diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index 5fb35464f693..9f7b69743233 100644 ---

[PATCHv2 5/5] i2c: i801: Use managed pcim_* PCI device initialization and reservation

2015-02-11 Thread Jarkko Nikula
Simplifies the code a bit and makes easier to disable PCI device on driver detach by removing the pcim_pin_device() call in the future if needed. Reason why i2c-i801.c doesn't ever call pci_disable_device() was because it made some systems to hang during power-off. See commit d6fcb3b9cf77