Re: [PATCHv4] i2c: add generic I2C multiplexer using gpio api

2010-11-30 Thread Jean Delvare
Hi Peter, On Tue, 30 Nov 2010 20:44:15 +0100, Peter Korsgaard wrote: > > "Jean" == Jean Delvare writes: > >> + for (i = 0; i < pdata->n_gpios; i++) { > >> + ret = gpio_request(pdata->gpios[i], "gpio-i2cmux"); > >> + if (ret) > >> + goto err_request_gpio; >

Re: [PATCHv4] i2c: add generic I2C multiplexer using gpio api

2010-11-30 Thread Peter Korsgaard
> "Jean" == Jean Delvare writes: Hi, Jean> I've fixed two remaining minor things myself, and your patch is Jean> ready to be applied now, except for one issue I just noticed. See Jean> below. Great. >> +gpio-i2cmux uses the platform bus, so you need to provide a struct >> +platform_de

Re: [PATCHv4] i2c: add generic I2C multiplexer using gpio api

2010-11-30 Thread Jean Delvare
Hi Peter, On Tue, 30 Nov 2010 15:03:08 +0100, Peter Korsgaard wrote: > Add an i2c mux driver providing access to i2c bus segments using a > hardware MUX sitting on a master bus and controlled through gpio pins. > > E.G. something like: > > -- -- Bus segment 1 -

[PATCHv4] i2c: add generic I2C multiplexer using gpio api

2010-11-30 Thread Peter Korsgaard
Add an i2c mux driver providing access to i2c bus segments using a hardware MUX sitting on a master bus and controlled through gpio pins. E.G. something like: -- -- Bus segment 1 - - - - - | | SCL/SDA| |-- | | |