Re: [RFC PATCH] i2c-designware-core: disable adapter before fill dev structure

2013-06-13 Thread Christian Ruppert
On Thu, Jun 13, 2013 at 11:33:56AM +0300, Andy Shevchenko wrote: > On Thu, 2013-06-13 at 10:16 +0200, Christian Ruppert wrote: > > As promised, I gave this one some over-night stress testing and I can > > confirm what I said previously: > > > > - The patch does _not_ solve the interrupt loop lock

Re: [RFC PATCH] i2c-designware-core: disable adapter before fill dev structure

2013-06-13 Thread Andy Shevchenko
On Thu, 2013-06-13 at 10:16 +0200, Christian Ruppert wrote: > As promised, I gave this one some over-night stress testing and I can > confirm what I said previously: > > - The patch does _not_ solve the interrupt loop lockups on its own. So, it just means my assumptions about what is happening t

Re: [RFC PATCH] i2c-designware-core: disable adapter before fill dev structure

2013-06-13 Thread Christian Ruppert
Hello, As promised, I gave this one some over-night stress testing and I can confirm what I said previously: - The patch does _not_ solve the interrupt loop lockups on its own. - The patch works well in conjunction with http://patchwork.ozlabs.org/patch/249622/ (which in turn depends on Mika'

Re: [RFC PATCH] i2c-designware-core: disable adapter before fill dev structure

2013-06-12 Thread Christian Ruppert
On Tue, Jun 11, 2013 at 08:40:37PM +0200, Wolfram Sang wrote: > On Fri, Jun 07, 2013 at 03:01:34PM +0200, Christian Ruppert wrote: > > Hi Andy, > > > > I like your patch and I just did some testing on it. Unluckily, it > > doesn't solve the lock-up problem. > > > > I haven't investigated any furt

Re: [RFC PATCH] i2c-designware-core: disable adapter before fill dev structure

2013-06-11 Thread Wolfram Sang
On Fri, Jun 07, 2013 at 03:01:34PM +0200, Christian Ruppert wrote: > Hi Andy, > > I like your patch and I just did some testing on it. Unluckily, it > doesn't solve the lock-up problem. > > I haven't investigated any further but I suspect that on top of the > cases I observed when debugging this

Re: [RFC PATCH] i2c-designware-core: disable adapter before fill dev structure

2013-06-07 Thread Christian Ruppert
Hi Andy, I like your patch and I just did some testing on it. Unluckily, it doesn't solve the lock-up problem. I haven't investigated any further but I suspect that on top of the cases I observed when debugging this (interrupts after initialisation of dev, easy to prove) there are more obscure ca

[RFC PATCH] i2c-designware-core: disable adapter before fill dev structure

2013-06-07 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c index c41ca63..a1d3d95 100644 --- a/drivers/i2c/busse