> If ii is alright with you I will change the dev_err(...)messages to
> dev_dbg(...) so that they do not spoil the logs.
OK.
> >> + rc = of_property_read_string(dev->device->of_node, "interrupt-names",
> >> + &int_name);
> >
> > I haven't checked but is that
Wolfram,
>
> Don't print out, it will spoil the logs. Timeouts can happen on I2C
> busses, no need to inform the user.
>
If ii is alright with you I will change the dev_err(...)messages to
dev_dbg(...) so that they do not spoil the logs.
>> + rc = of_property_read_string(dev->device->of_nod
On Tue, May 19, 2015 at 12:23:44PM -0400, Kamal Dasu wrote:
> Adding support for i2c controller driver for Broadcom settop
> SoCs.
>
> Signed-off-by: Kamal Dasu
We are very close.
> +/* Wait for device to be ready */
> +static int brcmstb_i2c_wait_if_busy(struct brcmstb_i2c_dev *dev)
> +{
> +
Okay, Kamal. I got it. Thanks for the explanation.
Wolfram, I have no more comment on this patch.
Thanks,
Ray
On 5/20/2015 1:35 PM, Kamal Dasu wrote:
> Ray,
>
> I am using non combined operation so it not necessary have limit. I
> am not sending a stop condition till the last byte is written
Ray,
I am using non combined operation so it not necessary have limit. I
am not sending a stop condition till the last byte is written or read.
So if the xfer has more than the i2c buffer len we break up the
transfers after the initial salve address write into max read/write
data buffer size.
Th