RE: [PATCH v5 3/4] drivers/i2c/busses/i2c-at91.c: add new driver

2011-11-23 Thread Voss, Nikolaus
Hi, Carsten Behling wrote on 2011-11-23: this case is already catched in at91_do_twi_transfer(): Sorry, I did not found this code in your patch. (http://www.mail-archive.com/linux-i2c@vger.kernel.org/msg06556.html): + if (is_read) { + if (!dev-buf_len) yes, this

RE: [PATCH v5 3/4] drivers/i2c/busses/i2c-at91.c: add new driver

2011-11-23 Thread Voss, Nikolaus
Hi Carsten, Carsten Behling wrote on 2011-11-23: I think it must be: + for (i = 0; i msg-len; ++i) { + internal_address |= ((unsigned)msg-buf[msg-len-1-i]) (8 * i); + int_addr_flag += AT91_TWI_IADRSZ_1; + } +

RE: [PATCH v5 3/4] drivers/i2c/busses/i2c-at91.c: add new driver

2011-11-22 Thread Voss, Nikolaus
Hi, Carsten Behling wrote on 2011-11-22: +static void at91_twi_read_next_byte(struct at91_twi_dev *dev) +{ + *dev-buf = at91_twi_read(dev, AT91_TWI_RHR) 0xff; + + /* send stop if second but last byte has been read */ + if (--dev-buf_len == 1) +