Re: mc13xxx: add I2C support, V5

2012-05-01 Thread Marc Reilly
Hi Samuel, > > On Sunday, April 01, 2012 04:41:35 PM Marc Reilly wrote: > > > This series (against mfd-2.6/for-next) changes the mc13xxx driver to > > > use regmap and adds I2C support. > > > It has a compile dependency on regmap/for-next, as the spi driver uses > > > the recently added pad_bits c

Re: mc13xxx: add I2C support, V5

2012-05-01 Thread Samuel Ortiz
Hi Marc, On Tue, Apr 17, 2012 at 09:21:41AM +1000, Marc Reilly wrote: > Hi Samuel, > > > On Sunday, April 01, 2012 04:41:35 PM Marc Reilly wrote: > > This series (against mfd-2.6/for-next) changes the mc13xxx driver to use > > regmap and adds I2C support. > > It has a compile dependency on regma

Re: mc13xxx: add I2C support, V5

2012-04-16 Thread Marc Reilly
Hi Samuel, On Sunday, April 01, 2012 04:41:35 PM Marc Reilly wrote: > This series (against mfd-2.6/for-next) changes the mc13xxx driver to use > regmap and adds I2C support. > It has a compile dependency on regmap/for-next, as the spi driver uses the > recently added pad_bits config field. (bump

Re: mc13xxx: add I2C support, V5

2012-04-01 Thread Uwe Kleine-König
Hello Marc, On Sun, Apr 01, 2012 at 07:39:49PM +1000, Marc Reilly wrote: > > On Sun, Apr 01, 2012 at 04:41:35PM +1000, Marc Reilly wrote: > > > This series (against mfd-2.6/for-next) changes the mc13xxx driver to use > > > regmap and adds I2C support. > > > It has a compile dependency on regmap/fo

RE: mc13xxx: add I2C support, V5

2012-04-01 Thread Alex Gershgorin
Hi Marc, thanks for V5. > This series (against mfd-2.6/for-next) changes the mc13xxx driver to use > regmap and adds I2C support. > It has a compile dependency on regmap/for-next, as the spi driver uses the > recently added pad_bits config field. If included in your plans to relocate the current

Re: mc13xxx: add I2C support, V5

2012-04-01 Thread Uwe Kleine-König
Hi Marc, On Sun, Apr 01, 2012 at 04:41:35PM +1000, Marc Reilly wrote: > This series (against mfd-2.6/for-next) changes the mc13xxx driver to use > regmap and adds I2C support. > It has a compile dependency on regmap/for-next, as the spi driver uses the > recently added pad_bits config field. > >

mc13xxx: add I2C support, V5

2012-04-01 Thread Marc Reilly
Hi, This series (against mfd-2.6/for-next) changes the mc13xxx driver to use regmap and adds I2C support. It has a compile dependency on regmap/for-next, as the spi driver uses the recently added pad_bits config field. Patch 2/4 has: Reviewed-by: Mark Brown Patch 4/4 has: Signed-off-by: Oskar S

mc13xxx: add I2C support (now with regmap), V4

2012-03-18 Thread Marc Reilly
Hi, This series (against mfd-2.6/for-next) changes the mc13xxx driver to use regmap and adds I2C support. It has a compile dependency on regmap/for-next, as the spi driver uses the recently added pad_bits config field. Changes since V3: - spi driver uses padded register format (reads should actu

mc13xxx: add I2C support (now with regmap), V3

2012-03-14 Thread Marc Reilly
Hi, This series (against mfd-2.6/for-next) changes the mc13xxx driver to use regmap and adds I2C support. It generally goes about this the same way as the previous 2 versions, but now uses regmap. I am unable to test SPI functionality, but the I2C stuff works. It would be great if someone could

Re: mfd: mc13xxx: add I2C support, V2

2012-03-12 Thread Mark Brown
On Sun, Mar 11, 2012 at 12:50:18PM +0100, Wolfram Sang wrote: > free, if this is desired. I think the regmap approach should have been tried > before we go custom. sound/soc/codecs/ad193x.c might give an impression how > regmap spi/i2c in one driver could look like. There's a bunch of other examp

Re: mfd: mc13xxx: add I2C support, V2

2012-03-11 Thread Wolfram Sang
> The only issue from V1 [0] not addressed is the use of regmap - mainly, I > don't > have the time. I accept that this is a lame excuse but hope that use of > regmap > can come later if it is required. I really appreciate the effort, yet I fear that this is a show stopper. It gets open coded

mfd: mc13xxx: add I2C support, V2

2012-03-10 Thread Marc Reilly
Hi, This series (based on Samuel's mfd-2.6/for-next) adds I2C support for the mc13xxx family PMICs. Thanks to Oscar for adding dt support for the I2C driver.

Re: mc13xxx: add I2C support

2012-02-20 Thread Samuel Ortiz
Hi Marc, On Fri, Jan 20, 2012 at 06:55:35PM +1100, Marc Reilly wrote: > Hi, > > Thankyou all for your feedback and comments. I'll use them for a V2 but > Samuel, I'd like to know if you'd like me to base them on a specific branch > before I do. Please rebase it against my for-next branch. > S

Re: mc13xxx: add I2C support

2012-01-20 Thread Mark Brown
On Fri, Jan 20, 2012 at 06:55:35PM +1100, Marc Reilly wrote: > On Thursday, January 19, 2012 10:29:41 PM Mark Brown wrote: > > On Thu, Jan 19, 2012 at 12:12:31PM +0100, Arnaud Patard wrote: > > > I've never looked at regmap deeply but can't it be done with regmap or is > > > it just a bad idea ?

Re: mc13xxx: add I2C support

2012-01-20 Thread Rtp
Marc Reilly writes: > Hi, Hi, > > Thankyou all for your feedback and comments. I'll use them for a V2 but > Samuel, I'd like to know if you'd like me to base them on a specific branch > before I do. > > Shawn, thanks for testing! > > On Thursday, January 19, 2012 10:29:41 PM Mark Brown wrote:

Re: mc13xxx: add I2C support

2012-01-19 Thread Mark Brown
On Thu, Jan 19, 2012 at 12:12:31PM +0100, Arnaud Patard wrote: > I've never looked at regmap deeply but can't it be done with regmap or is it > just a bad idea ? Glancing quickly at the existing code it should map on reasonably well, though a new format definition may be required for the 25 bit s

Re: mc13xxx: add I2C support

2012-01-19 Thread Rtp
Marc Reilly writes: > Hi, Hi, > > This series (based on 3.2) adds I2C support for the mc13xxx family PMICs. > The patches are similar, but not identical to my previous patches for this > [1], the > main difference being the way the config items are done in patch 2. > > I don't have the hardwar

Re: mc13xxx: add I2C support

2012-01-18 Thread Shawn Guo
Hi Marc, On Thu, Jan 19, 2012 at 12:01:31PM +1100, Marc Reilly wrote: > Hi, > > This series (based on 3.2) adds I2C support for the mc13xxx family PMICs. > The patches are similar, but not identical to my previous patches for this > [1], the > main difference being the way the config items are d

mc13xxx: add I2C support

2012-01-18 Thread Marc Reilly
Hi, This series (based on 3.2) adds I2C support for the mc13xxx family PMICs. The patches are similar, but not identical to my previous patches for this [1], the main difference being the way the config items are done in patch 2. I don't have the hardware to retest on SPI hardware, I'd appreciat