Re: [PATCH] Type qualifiers in __ia64_get_io_port_base

2005-07-18 Thread Ian Wienand
On Mon, Jul 18, 2005 at 07:06:55PM -0700, david mosberger wrote: > This one is wrong. It should use __attribute_const__ instead. If you > just drop the "const", it will result in worse code. Ok, I see why reading about attribute const. Thanks! -- Signed-Off-By: Ian Wienand <[EMAIL PROTECTED]>

Re: [PATCH] Type qualifiers in __ia64_get_io_port_base

2005-07-18 Thread david mosberger
This one is wrong. It should use __attribute_const__ instead. If you just drop the "const", it will result in worse code. --david On 7/18/05, Ian Wienand <[EMAIL PROTECTED]> wrote: > Fix > > include/asm/io.h:125: warning: type qualifiers ignored on function return type > > produced by gcc 4

[PATCH] Fix unused variable cpe_poll_timer

2005-07-18 Thread Ian Wienand
Fix arch/ia64/kernel/mca.c:109: warning: 'cpe_poll_timer' defined but not used when building for the simulator, which has no ACPI -- Signed-Off-By: Ian Wienand <[EMAIL PROTECTED]> diff --git a/arch/ia64/kernel/mca.c b/arch/ia64/kernel/mca.c --- a/arch/ia64/kernel/mca.c +++ b/arch/ia64/kernel/m

[PATCH] Fix unused variable acpi_madt_rev

2005-07-18 Thread Ian Wienand
Fix arch/ia64/kernel/acpi.c:71: warning: 'acpi_madt_rev' defined but not used when building for the simulator (which has no ACPI) by moving inside an ACPI ifdef'd area. -- Signed-Off-By: Ian Wienand <[EMAIL PROTECTED]> diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c --- a/arch/i

[PATCH] Fix uninitalised values in ia64_tlb_init

2005-07-18 Thread Ian Wienand
Fix arch/ia64/mm/tlb.c: In function 'ia64_tlb_init': arch/ia64/mm/tlb.c:171: warning: 'ptce_info.base' may be used uninitialized in this function arch/ia64/mm/tlb.c:171: warning: 'ptce_info.count[0]' may be used uninitialized in this function arch/ia64/mm/tlb.c:171: warning: 'ptce_info.count[1]

[PATCH] Fix uninitalised values in efi_memmap_walk

2005-07-18 Thread Ian Wienand
Fix arch/ia64/kernel/efi.c: In function 'efi_memmap_walk': arch/ia64/kernel/efi.c:306: warning: 'prev.start' may be used uninitialized in this function arch/ia64/kernel/efi.c:306: warning: 'prev.end' may be used uninitialized in this function -- Signed-Off-By: Ian Wienand <[EMAIL PROTECTED]>

[PATCH] Fix uninitialised values in ia64_illegal_op_fault

2005-07-18 Thread Ian Wienand
Fix arch/ia64/kernel/traps.c: In function 'ia64_illegal_op_fault': arch/ia64/kernel/traps.c:444: warning: 'rv.arg3' is used uninitialized in this function arch/ia64/kernel/traps.c:444: warning: 'rv.arg2' is used uninitialized in this function arch/ia64/kernel/traps.c:444: warning: 'rv.arg1' is u

[PATCH] Fix uninitalised value in do_copy_task_regs

2005-07-18 Thread Ian Wienand
Fix arch/ia64/kernel/process.c:503: warning: 'ip' may be used uninitialized in this function -- Signed-Off-By: Ian Wienand <[EMAIL PROTECTED]> diff --git a/arch/ia64/kernel/process.c b/arch/ia64/kernel/process.c --- a/arch/ia64/kernel/process.c +++ b/arch/ia64/kernel/process.c @@ -500,7 +500,7

[PATCH] Type qualifiers in __ia64_get_io_port_base

2005-07-18 Thread Ian Wienand
Fix include/asm/io.h:125: warning: type qualifiers ignored on function return type produced by gcc 4 According to http://gcc.gnu.org/ml/gcc-patches/2000-10/msg00814.html the type qualifier is superfluous. -- Signed-Off-By: Ian Wienand <[EMAIL PROTECTED]> diff --git a/include/asm-ia64/io.h b/i

Fix some warnings when building with gcc 4

2005-07-18 Thread Ian Wienand
Hi, Following are some patches to fix some IA64 specific warnings I am seeing when building with gcc 4. I'm pretty sure they can't hurt people not using gcc 4. The only IA64 specific one that I still see is include/asm/mmu_context.h:67: warning: type qualifiers ignored on function return type

Re: [PATCH 2.6.13-rc1 05/10] IOCHK interface for I/O error handling/detecting

2005-07-18 Thread Grant Grundler
On Wed, Jul 06, 2005 at 02:11:42PM +0900, Hidetoshi Seto wrote: > [This is 5 of 10 patches, "iochk-05-check_bridge.patch"] ... > It means that A or B hits a bus error, but there is no data > which one actually hits the error. So, C should notify the > error to both of A and B, and clear the H