Re: [PATCH take3 0/12] Support vector domain on ia64

2007-07-17 Thread Yasuaki Ishimatsu
Hi Tony, Luck, Tony wrote: > Getting close now. New (I think it's new, I didn't notice it last time, but > I may have > missed it in the other build noise) concern while compiling this version was > the warning: > > arch/ia64/kernel/iosapic.c:597: warning: 'iosapic_free_rte' defined but not

Re: [PATCH 1/2] ia64 clocksource

2007-07-17 Thread john stultz
On Tue, 2007-07-17 at 18:31 -0400, Bob Picco wrote: > Hi: > Thanks for the review. > Hidetoshi Seto wrote: [Tue Jul 17 2007, 06:55:47AM EDT] > > Bob Picco wrote: > > >@@ -214,61 +209,56 @@ ENTRY(fsys_gettimeofday) > > : > > > movl r27 = xtime > > : > > > .time_redo: > > >- .pred.rel.mutex p8,p

Re: [PATCH 1/2] ia64 clocksource

2007-07-17 Thread Bob Picco
Hi: Thanks for the review. Hidetoshi Seto wrote: [Tue Jul 17 2007, 06:55:47AM EDT] > Bob Picco wrote: > >@@ -214,61 +209,56 @@ ENTRY(fsys_gettimeofday) > : > > movl r27 = xtime > : > > .time_redo: > >-.pred.rel.mutex p8,p9,p10 > >-ld4.acq r28 = [r29] // xtime_lock.sequence. Must

Re: [PATCH take3 0/12] Support vector domain on ia64

2007-07-17 Thread Eric W. Biederman
Yasuaki Ishimatsu <[EMAIL PROTECTED]> writes: > - define NR_IRQS as follow: > > Vector domain can provide the number of irqs being proportional to the > number of CPUs theoretically. However, the relation between them is > actually not linear, especially in large system. To avoid the memory

RE: [PATCH take3 0/12] Support vector domain on ia64

2007-07-17 Thread Luck, Tony
Getting close now. New (I think it's new, I didn't notice it last time, but I may have missed it in the other build noise) concern while compiling this version was the warning: arch/ia64/kernel/iosapic.c:597: warning: 'iosapic_free_rte' defined but not used This isn't spurious, the only ca

git pull on ia64 linux tree

2007-07-17 Thread Luck, Tony
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux-2.6.git release This will update the files shown below. Thanks! -Tony arch/ia64/hp/common/sba_iommu.c | 20 ++-- arch/ia64/hp/sim/boot/fw-emu.c |5 - arch/ia64/hp/s

[PATCH take3 10/12] Support irq migration across domain

2007-07-17 Thread Yasuaki Ishimatsu
Add support for IRQ migration across vector domain. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> Signed-off-by: Yasuaki Ishimatsu <[EMAIL PROTECTED]> arch/ia64/kernel/iosapic.c | 20 +--- arch/ia64/kernel/irq_ia64.c | 42 +++--- arch

[PATCH take3 9/12] Add support for vector domain

2007-07-17 Thread Yasuaki Ishimatsu
Add fundamental support for multiple vector domain. There still exists only one vector domain even with this patch. IRQ migration across domain is not supported yet by this patch. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> Signed-off-by: Yasuaki Ishimatsu <[EMAIL PROTECTED]> arch/ia64/ke

[PATCH take3 12/12] Enable percpu vector domain for IA64_DIG

2007-07-17 Thread Yasuaki Ishimatsu
Add per-CPU vector domain support for IA64_DIG. It is enabled by adding the "vector=percpu" boot option. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> Signed-off-by: Yasuaki Ishimatsu <[EMAIL PROTECTED]> arch/ia64/kernel/irq_ia64.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-)

[PATCH take3 11/12] Enable percpu vector domain for IA64_GENERIC

2007-07-17 Thread Yasuaki Ishimatsu
Add per-CPU vector domain support for IA64_GENERIC. It is enabled by adding the "vector=percpu" boot option. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> Signed-off-by: Yasuaki Ishimatsu <[EMAIL PROTECTED]> Documentation/kernel-parameters.txt |3 +++ arch/ia64/kernel/irq_ia64.c

[PATCH take3 8/12] Add mapping table between irq and vector

2007-07-17 Thread Yasuaki Ishimatsu
Add mapping tables between irqs and vectors, and its management code. This is necessary for supporting multiple vector domain because 1:1 mapping between irq and vector will be changed to n:1. The irq == vector relationship between irqs and vectors is explicitly remained for percpu interrupts, pla

[PATCH take3 7/12] Check if irq is sharable

2007-07-17 Thread Yasuaki Ishimatsu
Need to check if irq is sharable amoung handlers when searching sharable IOSAPIC irq. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> Signed-off-by: Yasuaki Ishimatsu <[EMAIL PROTECTED]> arch/ia64/kernel/iosapic.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) Index: linux-2.

[PATCH take3 5/12] Use dynamic irq for iosapic interrupts

2007-07-17 Thread Yasuaki Ishimatsu
Use create_irq()/destroy_irq() for iosapic interrupts. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> Signed-off-by: Yasuaki Ishimatsu <[EMAIL PROTECTED]> arch/ia64/kernel/iosapic.c | 39 +++ 1 files changed, 15 insertions(+), 24 deletions(-) Index: lin

[PATCH take3 6/12] Fix invalid irq vector assumption for iosapic

2007-07-17 Thread Yasuaki Ishimatsu
Many of IOSAPIC codes depends on the flollowing assumptions, but these would become invalid when multiple vector domain will be supported in the future. - 1:1 mapping between IRQ and vector - IRQ == vector To fix those invalid assumptions, this patch changes iosapic_intr_info[] to be indexed

[PATCH take3 4/12] Use per iosapic lock for indirect iosapic register access

2007-07-17 Thread Yasuaki Ishimatsu
Use per-iosapic lock for indirect iosapic register access. It reduces lock contention. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> Signed-off-by: Yasuaki Ishimatsu <[EMAIL PROTECTED]> arch/ia64/kernel/iosapic.c | 57 ++--- include/asm-ia64/iosapic

[PATCH take3 0/12] Support vector domain on ia64

2007-07-17 Thread Yasuaki Ishimatsu
Hi, Here is a series of patches for ia64 vector domain. By these patches, we can use more than NR_VECTORS(256) irqs. This is based on existing x86-64 vector domain code. I tested it on my ia64 box. Changes from previous patchset: - rebase to 2.6.22 - remove unnecessary whitespaces - do the bui

[PATCH take3 3/12] Cleanup lock order in iosapic_register_intr

2007-07-17 Thread Yasuaki Ishimatsu
Cleanup order of irq_desc.lock and iosapic_lock in iosapic_register_intr() and iosapic_unregister_intr(). Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> Signed-off-by: Yasuaki Ishimatsu <[EMAIL PROTECTED]> arch/ia64/kernel/iosapic.c | 50 ++--- 1 fil

[PATCH take3 2/12] Remove duplicated members in iosapic_rte_info

2007-07-17 Thread Yasuaki Ishimatsu
Remove duplicated members in iosapic_rte_info in iosapic.c. This patch has no functional changes. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> Signed-off-by: Yasuaki Ishimatsu <[EMAIL PROTECTED]> arch/ia64/kernel/iosapic.c | 60 ++--- 1 files chang

[PATCH take3 1/12] Remove block structure for locking in iosapic.c

2007-07-17 Thread Yasuaki Ishimatsu
Remove unnecessary indent between spin_lock() and spin_unlock() in iosapic.c. This has no functional changes. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> Signed-off-by: Yasuaki Ishimatsu <[EMAIL PROTECTED]> arch/ia64/kernel/iosapic.c | 303 - 1

Re: [PATCH 1/2] ia64 clocksource

2007-07-17 Thread Hidetoshi Seto
Bob Picco wrote: @@ -214,61 +209,56 @@ ENTRY(fsys_gettimeofday) : movl r27 = xtime : .time_redo: - .pred.rel.mutex p8,p9,p10 - ld4.acq r28 = [r29] // xtime_lock.sequence. Must come first for locking purposes + ld4.acq r28 = [r20] // gtod_lock.sequence, Mu