Re: [PATCH] ia64: fix a few section mismatch warnings

2007-07-26 Thread Sam Ravnborg
On Fri, Jul 27, 2007 at 05:36:14AM +0100, Al Viro wrote: > On Fri, Jul 27, 2007 at 06:27:44AM +0200, Sam Ravnborg wrote: > > On Fri, Jul 27, 2007 at 02:18:13AM +0100, Al Viro wrote: > > > On Thu, Jul 26, 2007 at 11:01:41PM +0200, Sam Ravnborg wrote: > > > > > > > +static void *__init_refok alloc

[PATCH] flush cache fixes for ia64 [2/2] sync icache dcache

2007-07-26 Thread KAMEZAWA Hiroyuki
flush icache for ia64 take4. This patch is against 2.6.23-rc1. Changes v3 -> v4: - avoid implementing flush_(i)cache_pages(). - added sync_icache_dcache() call. - change Documentation/cachetlb.txt Current ia64 kernel flushes icache by lazy_mmu_prot_update() *after* set_pte(). This is wrong.

[PATCH] flush cache fixes for ia64 [1/2] migration fix

2007-07-26 Thread KAMEZAWA Hiroyuki
In migration, a new page should be cache flushed before set_pte() in some archs. Signed-Off-By: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> --- mm/migrate.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.23-rc1.test/mm/migrate.c =

[PATCH] flush cache fixes for ia64 [0/2] intro

2007-07-26 Thread KAMEZAWA Hiroyuki
This patch set is flush_cache_xxx fixes for ia64, take4. against 2.6.23-rc1. Consists of 2 patches. 1. page migration fix ... Christoph, could you review this ? 2. remove lazy_mmu_prot_update() and introduce sync_icache_dcache() If name or style is wrong, please point out. Any comme

Re: [PATCH] ia64: fix a few section mismatch warnings

2007-07-26 Thread Al Viro
On Fri, Jul 27, 2007 at 06:27:44AM +0200, Sam Ravnborg wrote: > On Fri, Jul 27, 2007 at 02:18:13AM +0100, Al Viro wrote: > > On Thu, Jul 26, 2007 at 11:01:41PM +0200, Sam Ravnborg wrote: > > > > > +static void *__init_refok alloc_rte(unsigned long size) > > > +{ > > > + return alloc_bootmem(size

Re: [PATCH] ia64: fix a few section mismatch warnings

2007-07-26 Thread Sam Ravnborg
On Fri, Jul 27, 2007 at 02:18:13AM +0100, Al Viro wrote: > On Thu, Jul 26, 2007 at 11:01:41PM +0200, Sam Ravnborg wrote: > > > +static void *__init_refok alloc_rte(unsigned long size) > > +{ > > + return alloc_bootmem(size); > > +} > > That makes no sense at all. If we ever call that after f

Re: Regression in serial console on ia64 after 2.6.22

2007-07-26 Thread Yinghai Lu
Andrew Morton wrote: On Wed, 25 Jul 2007 08:39:01 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: Subject : Regression in serial console on ia64 after 2.6.22 References : http://marc.info/?l=linux-ia64&m=118483645914066&w=2 Last known good : ? Submitter : Horms <[EMAIL PROTECTED]

Re: Regression in serial console on ia64 after 2.6.22

2007-07-26 Thread Andrew Morton
On Wed, 25 Jul 2007 08:39:01 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: > >> Subject : Regression in serial console on ia64 after 2.6.22 > >> References : http://marc.info/?l=linux-ia64&m=118483645914066&w=2 > >> Last known good : ? > >> Submitter : Horms <[EMAIL PROTECTED]> >

Re: [PATCH] ia64: fix a few section mismatch warnings

2007-07-26 Thread Al Viro
On Thu, Jul 26, 2007 at 11:01:41PM +0200, Sam Ravnborg wrote: > +static void *__init_refok alloc_rte(unsigned long size) > +{ > + return alloc_bootmem(size); > +} That makes no sense at all. If we ever call that after freeing initmem, we are screwed, period. Sounds like __init fodder. - T

RE: [PATCH] ia64: fix build failure on fs/quota.c

2007-07-26 Thread Doug Chapman
On Thu, 2007-07-26 at 14:24 -0700, Luck, Tony wrote: > This issue wandered off onto a long thread "build fix for x86_64" which > died out without a final patch. Here's the summary: > Ahh, thanks, I had not seen that thread. > > +#if defined(CONFIG_X86_64) || (defined(CONFIG_IA64) && > > defin

RE: [PATCH] ia64: fix build failure on fs/quota.c

2007-07-26 Thread Luck, Tony
This issue wandered off onto a long thread "build fix for x86_64" which died out without a final patch. Here's the summary: > +#if defined(CONFIG_X86_64) || (defined(CONFIG_IA64) && > defined(CONFIG_COMPAT)) It was pointed out that x86-64 also has a CONFIG_COMPAT, so the "right" #ifdef mess wou

[PATCH] ia64: fix a few section mismatch warnings

2007-07-26 Thread Sam Ravnborg
Fix the following section mismatch warnings: WARNING: vmlinux.o(.text+0x41902): Section mismatch: reference to .init.text:__alloc_bootmem (between 'ia64_mca_cpu_init' and 'ia64_do_tlb_purge') WARNING: vmlinux.o(.text+0x49222): Section mismatch: reference to .init.text:__alloc_bootmem (between 'r

Re: 2.6.23-rc1-mm1: boot hang on ia64 with memoryless nodes

2007-07-26 Thread Lee Schermerhorn
On Thu, 2007-07-26 at 23:00 +0900, KAMEZAWA Hiroyuki wrote: > On Thu, 26 Jul 2007 09:53:27 -0400 > Lee Schermerhorn <[EMAIL PROTECTED]> wrote: > > > On Wed, 2007-07-25 at 17:18 -0400, Lee Schermerhorn wrote: > > > On Wed, 2007-07-25 at 12:38 -0700, Christoph Lameter wrote: > > > > (ccing Andy who

Re: [PATCH] ia64: fix build failure on fs/quota.c

2007-07-26 Thread Doug Chapman
On Thu, 2007-07-19 at 13:15 -0400, Doug Chapman wrote: > Fix ia64 build failure on fs/qutoa.c. A recent patch used the > type compat_u64 which on ia64 is only available if CONFIG_COMPAT > is defined. > > > From: Tony Luck <[EMAIL PROTECTED]> > Signed-off-by: Doug Chapman <[EMAIL PROTECTED]> > >

Re: [PATCH] flush icache before set_pte on ia64 take3

2007-07-26 Thread Zoltan Menyhart
KAMEZAWA Hiroyuki wrote: Thank you for advise. Hmm..how about this ? == /* * synchronize icache and dcache if the hardware doesn't do it automatically * and the page is executable. */ static inline arch_sync_icache_dcache(pte_t pte, page) { } Why not? I just wanted to see if you chang

Re: [PATCH] flush icache before set_pte on ia64 take3

2007-07-26 Thread KAMEZAWA Hiroyuki
On Thu, 26 Jul 2007 17:13:52 +0200 Zoltan Menyhart <[EMAIL PROTECTED]> wrote: > I can agree: > - lazy_mmu_prot_update() is not the right place for a flush > - to flush I-cache before inserting PTE (at least for the > machines with physical address tagged caches) > > Can we have a separate, spec

Re: [PATCH] flush icache before set_pte on ia64 take3

2007-07-26 Thread Zoltan Menyhart
I do not think changing the semantics of flush_cache_page() is a good idea. Please have a look at Documentation/cachetlb.txt. This is for virtual address tagged caches. The doc. does not say much about flush_icache_page(). It is used in: install_page(): can release any previously existing mappin

Re: 2.6.23-rc1-mm1: boot hang on ia64 with memoryless nodes

2007-07-26 Thread Lee Schermerhorn
On Thu, 2007-07-26 at 09:53 -0400, Lee Schermerhorn wrote: > On Wed, 2007-07-25 at 17:18 -0400, Lee Schermerhorn wrote: > > On Wed, 2007-07-25 at 12:38 -0700, Christoph Lameter wrote: > > > (ccing Andy who did the work on the config stuff) > > > > > > On Wed, 25 Jul 2007, Lee Schermerhorn wrote:

Re: 2.6.23-rc1-mm1: boot hang on ia64 with memoryless nodes

2007-07-26 Thread KAMEZAWA Hiroyuki
On Thu, 26 Jul 2007 09:53:27 -0400 Lee Schermerhorn <[EMAIL PROTECTED]> wrote: > On Wed, 2007-07-25 at 17:18 -0400, Lee Schermerhorn wrote: > > On Wed, 2007-07-25 at 12:38 -0700, Christoph Lameter wrote: > > > (ccing Andy who did the work on the config stuff) > > > > > > On Wed, 25 Jul 2007, Lee

Re: 2.6.23-rc1-mm1: boot hang on ia64 with memoryless nodes

2007-07-26 Thread Lee Schermerhorn
On Wed, 2007-07-25 at 17:18 -0400, Lee Schermerhorn wrote: > On Wed, 2007-07-25 at 12:38 -0700, Christoph Lameter wrote: > > (ccing Andy who did the work on the config stuff) > > > > On Wed, 25 Jul 2007, Lee Schermerhorn wrote: > > > > > I tried to deselect SPARSEMEM_VMEMMAP. Kconfig's "def_boo

Re: [PATCH] flush icache before set_pte on ia64 take3

2007-07-26 Thread KAMEZAWA Hiroyuki
On Thu, 26 Jul 2007 17:13:23 +0900 KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote: > - lazy_mmu_prot_update() checked pte's executable bit. This was because old >Linux's anon page has executable bit. Current kernel doesn't set executable >bit on anonymous pages. > Linux's anon page had VM_EX

[PATCH] flush icache before set_pte on ia64 take3

2007-07-26 Thread KAMEZAWA Hiroyuki
This is a patch for flush icache for ia64 take3. against 2.6.23-rc1. tested on ia64/NUMA. Comments ? Should I add CONFIG_MONTECITO ? (It seems header-file dependency is not clean..but...) Thanks, -Kame == [IA64] flush icache before setting pte Changelog: - reviewed the whole patch again and a