flush icache for ia64 take4.
This patch is against 2.6.23-rc1.
Changes V4 -> V5:
- removed sync_icache_dcache from do_wp_page() page reuse case.
Changes v3 -> v4:
- avoid implementing flush_(i)cache_pages().
- added sync_icache_dcache() call.
- change Documentation/cachetlb.txt
Current i
On Fri, Jul 27, 2007 at 03:32:13PM -0700, Luck, Tony wrote:
> - mca_data = alloc_bootmem(sizeof(struct ia64_mca_cpu)
> - * NR_CPUS + KERNEL_STACK_SIZE);
> + mca_data = mca_bootmem(NR_CPUS + KERNEL_STACK_SIZE);
>
> Oops. You moved the mu
In migration, a new page should be cache flushed before set_pte()
in some archs which have virtually-tagged cache..
V4 -> V5:
* changed flush_icache_page to flush_cache_page.
Signed-Off-By: KAMEZAWA Hiruyoki <[EMAIL PROTECTED]>
---
mm/migrate.c |1 +
1 file changed, 1 insertion(+)
Index
Appliled comments on take 4.
patches are against 2.6.23-rc1.
Changes:
- changes flush_icache_page to be flush_cache_page() in
remove_migration_pte().
- removed sync_icache_dcahe() in page reuse case of do_wp_page().
Considerations:
- I can add CONFIG_MONTECITO if necessary. But it will be
On Sat, 28 Jul 2007 07:06:09 +0900
KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote:
> On Fri, 27 Jul 2007 09:39:16 -0700 (PDT)
> Christoph Lameter <[EMAIL PROTECTED]> wrote:
>
> > This will have no effect on x86_64, ia64 and i386. Maybe useful for
> > virtually mapped platforms (parisc)?
> >
> yes.
On Fri, Jul 27, 2007 at 04:21:47PM -0700, Luck, Tony wrote:
> > So it seems on ia64 with gcc 3.3.6 there's some 8 byte alignment of the
> > array members?
> >
> > Sam and the ia64 maintainers Cc'ed - they might know better what's going
> > on here.
>
> This ia64 maintainer is baffled ... but I d
Adrian Bunk <[EMAIL PROTECTED]> writes:
> I don't have an idea how this happens, but it sounds like an alignment
> issue:
>
> sizeof(struct acpi_device_id)=20
This is wrong. The structure has 24 bytes (including 7(!) bytes of
padding).
Andreas.
--
Andreas Schwab, SuSE Labs, [EMAIL PROTECTED]
Hi Linus,
please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux-2.6.git release
This will update the files shown below. The fs/quota.c change (together with
the changes to arch/{ia64,x86_64}/Kconfig solve a build problem when
CONFIG_COMPAT=n
(discussed to death on
On Fri, Jul 27, 2007 at 06:25:12PM +0200, Thomas Renninger wrote:
> On Fri, 2007-07-27 at 08:26 +0200, Jan Dittmer wrote:
> > Len Brown wrote:
> > > Hi Linus,
> > >
> > > please pull from:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git
> > > release
> >
> > T
- mca_data = alloc_bootmem(sizeof(struct ia64_mca_cpu)
-* NR_CPUS + KERNEL_STACK_SIZE);
+ mca_data = mca_bootmem(NR_CPUS + KERNEL_STACK_SIZE);
Oops. You moved the multiply by sizeof(struct ia64_mca_cpu) up into
the mca_bootmem()
On Fri, 27 Jul 2007 09:39:16 -0700 (PDT)
Christoph Lameter <[EMAIL PROTECTED]> wrote:
> This will have no effect on x86_64, ia64 and i386. Maybe useful for
> virtually mapped platforms (parisc)?
>
yes.
- Kame
> asm-ia64/cacheflush.c
>
> #define flush_icache_page(vma,page) do { } w
This will have no effect on x86_64, ia64 and i386. Maybe useful for
virtually mapped platforms (parisc)?
asm-ia64/cacheflush.c
#define flush_icache_page(vma,page) do { } while (0)
Acked-by: Christoph Lameter <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubs
On Sat, 28 Jul 2007 00:02:23 +0900
KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote:
> On Fri, 27 Jul 2007 16:16:27 +0200
> Zoltan Menyhart <[EMAIL PROTECTED]> wrote:
>
> > Do you really need a "sync_icache_dcache()" in "do_wp_page()"?
> > I guess it is only needed when the EXEC bit of the PTE gets tu
On Fri, 27 Jul 2007 16:16:27 +0200
Zoltan Menyhart <[EMAIL PROTECTED]> wrote:
> Do you really need a "sync_icache_dcache()" in "do_wp_page()"?
> I guess it is only needed when the EXEC bit of the PTE gets turned on.
>
Ah, sorry. do_wp_page() without page copy (reuse case) doesn't need sync.
Abou
Do you really need a "sync_icache_dcache()" in "do_wp_page()"?
I guess it is only needed when the EXEC bit of the PTE gets turned on.
--- linux-2.6.23-rc1.test.orig/mm/migrate.c
+++ linux-2.6.23-rc1.test/mm/migrate.c
@@ -172,6 +172,7 @@ static void remove_migration_pte(struct
pte = pte_mkold(
When comparing a pointer, it's clearer to compare it to NULL than to 0.
Here is an excerpt of the semantic patch:
@@
expression *E;
@@
E ==
- 0
+ NULL
@@
expression *E;
@@
E !=
- 0
+ NULL
Signed-off-by: Yoann Padioleau <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
Cc: linux-ia64@vger.kernel
Fix the following section mismatch warnings:
WARNING: vmlinux.o(.text+0x41902): Section mismatch: reference to
.init.text:__alloc_bootmem (between 'ia64_mca_cpu_init' and 'ia64_do_tlb_purge')
WARNING: vmlinux.o(.text+0x49222): Section mismatch: reference to
.init.text:__alloc_bootmem (between 'r
17 matches
Mail list logo