Re: [PATCH] Failure to grow RBS

2007-08-16 Thread Andrew Burgess
* Luck, Tony [EMAIL PROTECTED] [2007-08-15 13:46:39 -0700]: But it looks on paper like this solves the RBS case. Needs a Signed-off-by line. Apologies, this is my first kernel patch, so I'm still learning :) Signed-off-by: Andrew Burgess [EMAIL PROTECTED] diff -urp

RE: scripts/mod/file2alias.c cross compile problem

2007-08-16 Thread Thomas Renninger
On Fri, 2007-08-03 at 08:08 +1000, Rusty Russell wrote: On Thu, 2007-08-02 at 09:25 -0700, Luck, Tony wrote: Adrian Bunk: scripts/mod/file2alias.c is compiled with HOSTCC and ensures that kernel_ulong_t is correct, but it can't cope with different padding on different architectures.

RE: scripts/mod/file2alias.c cross compile problem

2007-08-16 Thread Luck, Tony
-#define ACPI_ID_LEN 9 +#define ACPI_ID_LEN 16 /* only 9 bytes needed here, 16 bytes are used */ What will happen if someone uses more than 9 bytes? With the old limit there would be a compile time error it someone initialized with: {PNP0C0ABCDEFGH, 0}, But if we change ACPI_ID_LEN

RE: scripts/mod/file2alias.c cross compile problem

2007-08-16 Thread Thomas Renninger
On Thu, 2007-08-16 at 09:26 -0700, Luck, Tony wrote: -#define ACPI_ID_LEN9 +#define ACPI_ID_LEN16 /* only 9 bytes needed here, 16 bytes are used */ What will happen if someone uses more than 9 bytes? With the old limit there would be a compile time error it someone