Re: [PATCH] Move dmi_scan_machine() call ealier

2007-11-07 Thread Simon Horman
On Wed, Nov 07, 2007 at 09:40:29AM -0700, Alex Williamson wrote: > > On Wed, 2007-11-07 at 08:30 -0800, Luck, Tony wrote: > > > Thanks for the review Simon. Is the patch below more like what > > > you're thinking? I agree that check_bugs doesn't initial seem like the > > > most appropriate pla

Re: [PATCH] Move dmi_scan_machine() call ealier

2007-11-07 Thread Simon Horman
On Wed, Nov 07, 2007 at 08:14:19AM -0700, Alex Williamson wrote: > > On Wed, 2007-11-07 at 16:15 +0900, Simon Horman wrote: > > On Tue, Nov 06, 2007 at 10:31:07AM -0700, Alex Williamson wrote: > > > > > >I'd like to move our call to dmi_scan_machine up earlier in the boot > > > process so tha

RE: [PATCH] Move dmi_scan_machine() call ealier

2007-11-07 Thread Alex Williamson
On Wed, 2007-11-07 at 08:30 -0800, Luck, Tony wrote: > > Thanks for the review Simon. Is the patch below more like what > > you're thinking? I agree that check_bugs doesn't initial seem like the > > most appropriate place to setup DMI, but think about what DMI is > > typically used for in the

RE: [PATCH] Move dmi_scan_machine() call ealier

2007-11-07 Thread Luck, Tony
> Thanks for the review Simon. Is the patch below more like what > you're thinking? I agree that check_bugs doesn't initial seem like the > most appropriate place to setup DMI, but think about what DMI is > typically used for in the kernel. Then re-name check_bugs() to something more suited to

Re: [PATCH] Move dmi_scan_machine() call ealier

2007-11-07 Thread Alex Williamson
On Wed, 2007-11-07 at 16:15 +0900, Simon Horman wrote: > On Tue, Nov 06, 2007 at 10:31:07AM -0700, Alex Williamson wrote: > > > >I'd like to move our call to dmi_scan_machine up earlier in the boot > > process so that we can take advantage of a DMI hook, called out of > > acpi_early_init, to

Re: [PATCH] Move dmi_scan_machine() call ealier

2007-11-06 Thread Simon Horman
On Tue, Nov 06, 2007 at 10:31:07AM -0700, Alex Williamson wrote: > >I'd like to move our call to dmi_scan_machine up earlier in the boot > process so that we can take advantage of a DMI hook, called out of > acpi_early_init, to enable _OSI(Linux) on Xen HVM domains. Since the > SMBIOS parsing

[PATCH] Move dmi_scan_machine() call ealier

2007-11-06 Thread Alex Williamson
I'd like to move our call to dmi_scan_machine up earlier in the boot process so that we can take advantage of a DMI hook, called out of acpi_early_init, to enable _OSI(Linux) on Xen HVM domains. Since the SMBIOS parsing makes use of ioremap, which Bjorn pointed out is fragile early in boot, I'