Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-28 Thread Christoph Hellwig
On Mon, Aug 27, 2007 at 01:10:56PM -0500, Dean Nelson wrote: > > Does it? Well, then open the file in question and start doing > > close(dup(fd)) > > in a loop. Won't take long for an oops... > > Actually it won't oops. And that's because when the file is opened, > xpmem_open() creates a struct

Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Al Viro
On Mon, Aug 27, 2007 at 03:24:20PM -0500, Robin Holt wrote: > On Mon, Aug 27, 2007 at 08:35:10PM +0100, Al Viro wrote: > > On Mon, Aug 27, 2007 at 02:19:06PM -0500, Dean Nelson wrote: > > > > > No operations can be done once it's closed, only while it's opened. > > > > What the hell do you mean,

Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Robin Holt
On Mon, Aug 27, 2007 at 08:35:10PM +0100, Al Viro wrote: > On Mon, Aug 27, 2007 at 02:19:06PM -0500, Dean Nelson wrote: > > > No operations can be done once it's closed, only while it's opened. > > What the hell do you mean, can't be done? > > fd = open(...); > fp = popen("/bin/date"

Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Al Viro
On Mon, Aug 27, 2007 at 02:19:06PM -0500, Dean Nelson wrote: > No operations can be done once it's closed, only while it's opened. What the hell do you mean, can't be done? fd = open(...); fp = popen("/bin/date", "r"); /* read from fp */ fclose(fp); do ope

Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Dean Nelson
On Mon, Aug 27, 2007 at 07:15:44PM +0100, Al Viro wrote: > On Mon, Aug 27, 2007 at 01:10:56PM -0500, Dean Nelson wrote: > > On Mon, Aug 27, 2007 at 05:13:28PM +0100, Al Viro wrote: > > > On Mon, Aug 27, 2007 at 10:59:33AM -0500, Dean Nelson wrote: > > > > This patch exports __put_task_struct as it

Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Al Viro
On Mon, Aug 27, 2007 at 01:10:56PM -0500, Dean Nelson wrote: > On Mon, Aug 27, 2007 at 05:13:28PM +0100, Al Viro wrote: > > On Mon, Aug 27, 2007 at 10:59:33AM -0500, Dean Nelson wrote: > > > This patch exports __put_task_struct as it is needed by XPMEM. > > > > > > Signed-off-by: Dean Nelson <[EMA

Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Dean Nelson
On Mon, Aug 27, 2007 at 05:13:28PM +0100, Al Viro wrote: > On Mon, Aug 27, 2007 at 10:59:33AM -0500, Dean Nelson wrote: > > This patch exports __put_task_struct as it is needed by XPMEM. > > > > Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> > > > > --- > > > > One struct file_operations registe

Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Al Viro
On Mon, Aug 27, 2007 at 10:59:33AM -0500, Dean Nelson wrote: > This patch exports __put_task_struct as it is needed by XPMEM. > > Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> > > --- > > One struct file_operations registered by XPMEM, xpmem_open(), calls > 'get_task_struct(current->group_leade

[PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Dean Nelson
This patch exports __put_task_struct as it is needed by XPMEM. Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> --- One struct file_operations registered by XPMEM, xpmem_open(), calls 'get_task_struct(current->group_leader)' and another, xpmem_flush(), calls 'put_task_struct(tg->group_leader)'. Th