Sata_promise.c queries

2005-02-09 Thread Gary Poppitz
First off, I have the libdata-2.6 pull. The version of sata_promise.c is 1.58 . Is this the latest one available? Next question, in function pdc_qc_issue_prot, there is a BUG() call in the case of ATA_PROT_ATAPI_DMA. Is this one of those "fixme"s that will be addressed Real Soon Now, or is this

Problem on SATA-disk with Promise SATAII 150 TX4 ("DriveReady SeekComplete Error")

2005-02-09 Thread Johannes Resch
Hi, [please CC me on replies] I've got a box running 2.6.10 (with the patch[0] needed to support the Promise SATAII 150 TX4 controller). This box has three software raid1 partitions mirrored on a SATA disk on the Promise controller and a disk on the mainboard IDE controller (VIA vt8235). Within

Re: Sata_promise.c queries

2005-02-09 Thread Bartlomiej Zolnierkiewicz
On Wed, 9 Feb 2005 08:51:47 -0700, Gary Poppitz <[EMAIL PROTECTED]> wrote: > First off, I have the libdata-2.6 pull. > > The version of sata_promise.c is 1.58 . > > Is this the latest one available? > > Next question, in function pdc_qc_issue_prot, there is a BUG() call in > the case of > ATA_PR

Re: toshiba ide - ide dma setting

2005-02-09 Thread Marcin Kuk
Hi. That's me again. I don't know if you remember my problem so I remind. What can I try to do for enabling DMA in my Toshiba Satellite 320CDT laptop. Any ideas, suggestions? I will be thankful. > Bad news :-(. > > Now I am working with my new compiled 2..6.10ac12 kernel. > I can't enable DMA se

Re: [rfc][patch] ide: fix unneeded LBA48 taskfile registers access

2005-02-09 Thread Tejun Heo
Hello, Bartlomiej. Happy new lunar year. Bartlomiej Zolnierkiewicz wrote: I would prefer to not teach do_rw_taskfile() about ->tf_{in,out}_flags (and convert all users to use helpers) - it is much simpler this way, ->flags field in ide_task_t is needed anyway (32-bit I/O flag). New lunar year da

Re: [rfc][patch] ide: fix unneeded LBA48 taskfile registers access

2005-02-09 Thread Bartlomiej Zolnierkiewicz
Hello Tejun, On Thu, 10 Feb 2005 09:01:58 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, Bartlomiej. Happy new lunar year. > > Bartlomiej Zolnierkiewicz wrote: > > > > I would prefer to not teach do_rw_taskfile() about ->tf_{in,out}_flags > > (and convert all users to use helpers) - it i

Re: [rfc][patch] ide: fix unneeded LBA48 taskfile registers access

2005-02-09 Thread Tejun Heo
Okay, another quick question. To fix the io_32bit race problem in ide_taskfile_ioctl() (and later ide_cmd_ioctl() too), it seems simplest to mark the taskfile with something like ATA_TFLAG_IO_16BIT flag and use the flag in task_in_intr(). However, ATA_TFLAG_* are used by libata, and I think t

Re: [rfc][patch] ide: fix unneeded LBA48 taskfile registers access

2005-02-09 Thread Bartlomiej Zolnierkiewicz
On Thu, 10 Feb 2005 09:52:25 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > > Okay, another quick question. > > To fix the io_32bit race problem in ide_taskfile_ioctl() (and later > ide_cmd_ioctl() too), it seems simplest to mark the taskfile with > something like ATA_TFLAG_IO_16BIT flag and u

Re: [rfc][patch] ide: fix unneeded LBA48 taskfile registers access

2005-02-09 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: On Thu, 10 Feb 2005 09:52:25 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: Okay, another quick question. To fix the io_32bit race problem in ide_taskfile_ioctl() (and later ide_cmd_ioctl() too), it seems simplest to mark the taskfile with something like ATA_TFLAG_IO