Re: [PATCH libata-dev-2.6] ata_scsi_verify_xlat() fix

2005-02-24 Thread Albert Lee
Jeff Garzik wrote: As far as I can tell, your patches are diff'd correctly. Yet, they still do not apply: drivers/scsi/libata-scsi.c 1.68: 1661 lines 2 out of 2 hunks FAILED -- saving rejects to file drivers/scsi/libata-scsi.c.rej I do not understand the problem, so I simply applied them by h

Re: [PATCH 2.6.11+ sata_qstor] libata: sata_qstor cosmetic fixes

2005-02-24 Thread Jeff Garzik
Mark Lord wrote: Jeff Garzik wrote: Mark Lord wrote: Minor patch for new 2.6.xx sata_qstor driver attached, as per Alexey's fine-toothed comb! :) Signed-off-by: Mark Lord <[EMAIL PROTECTED]> I had to apply this manually, since your mailer "corrupts" the patch by encoding text/plain as base64. P

IDE channels not independent in PIIX4E?

2005-02-24 Thread GrantC
Greetings, I have an old but reliable Intel SE440BX-2 with 440BX and PIIX4E chipset. 120 + 80 GB hard drives on each channel as master, very disappointing md software RAID0 or RAID1 performance. Slackware 10.1 with 2.4.29 or 2.4.30pre2, testing back to 2.4.21. One thing I noticed is that if I

Re: [PATCH libata-dev-2.6] Issue INITIALIZE DEVICE PARAMETERS for CHS only devices

2005-02-24 Thread Jeff Garzik
This patch also looked perfect, and also did not apply. I don't understand this, either. I applied this patch manually also. Thanks much! Jeff - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at htt

Re: [PATCH libata-dev-2.6] ata_scsi_verify_xlat() fix

2005-02-24 Thread Jeff Garzik
As far as I can tell, your patches are diff'd correctly. Yet, they still do not apply: drivers/scsi/libata-scsi.c 1.68: 1661 lines 2 out of 2 hunks FAILED -- saving rejects to file drivers/scsi/libata-scsi.c.rej I do not understand the problem, so I simply applied them by hand. Thanks for your

Re: [PATCH libata-dev-2.6] Issue INITIALIZE DEVICE PARAMETERS for CHS only devices

2005-02-24 Thread Albert Lee
Albert Lee wrote: Rediff'ed against 2.6.11-rc5 + C/H/S patches. Attached please find the revised patch for your review. I forgot to mention. The correct title, as indicated by Mark, should be: "Issue INITIALIZE DEVICE PARAMETERS for pre-ATA4 or CHS only devices" Albert - To unsubscribe from this

Re: [PATCH libata-dev-2.6] Issue INITIALIZE DEVICE PARAMETERS for CHS only devices

2005-02-24 Thread Albert Lee
This patch similarly fails to apply: Jeff, Rediff'ed against 2.6.11-rc5 + C/H/S patches. Attached please find the revised patch for your review. Albert Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- l

Re: [PATCH libata-dev-2.6] ata_scsi_verify_xlat() fix

2005-02-24 Thread Albert Lee
Jeff Garzik wrote: Patch looks OK, but does not appear to be diff'd against linux-2.6.11-rc4 + CHS support patches When I try to apply your patch, I get drivers/scsi/libata-scsi.c 1.68: 1661 lines drivers/scsi/libata-scsi.c 1.68 -> 1.69: 1661 lines 2 out of 2 hunks FAILED -- saving rejects to

Multiple drives with IDNF errors

2005-02-24 Thread mmadore
Hi, We have an array of 15 Seagate Barracuda 7200.7 (ST3200822AS) 200GB SATA drives, connected to 2 Marvell 88SX6081 8-port SATA Controllers (Supermicro DAC-SATA-MV8). The system (X5DPL-TGM & SC933T-760B) is running RH9 with kernel 2.4.26. The drives are configured as software RAID 5 The problem

Re: [PATCH libata-2.6] AHCI: print port ID not number

2005-02-24 Thread Jeff Garzik
Brett Russ wrote: The attached patch fixes the "ata#: error occurred, port reset" line to display the port id instead of the port number. Signed-off-by: Brett Russ <[EMAIL PROTECTED]> --- libata-2.6/drivers/scsi/ahci.c Thu Feb 24 14:18:35 2005 +++ libata-2.6-ahci-printk/drivers/scsi/ahci.c Thu Feb

Re: [PATCH libata-2.6] AHCI: support for tf_read (RFC)

2005-02-24 Thread Jeff Garzik
Brett Russ wrote: I coded this because ata_pass_thru_cc() (in the dev branch) and other functions call tf_read() which is supported for most except ahci. I've been unable to test because I'm leaving on vacation and am in a last minute rush but wanted to get this out there for comments. Signed-off-b

[PATCH libata-2.6] AHCI: support for tf_read (RFC)

2005-02-24 Thread Brett Russ
I coded this because ata_pass_thru_cc() (in the dev branch) and other functions call tf_read() which is supported for most except ahci. I've been unable to test because I'm leaving on vacation and am in a last minute rush but wanted to get this out there for comments. Signed-off-by: Brett Russ <[E

Re: [patch ide-dev 3/9] merge LBA28 and LBA48 Host Protected Area support code

2005-02-24 Thread Greg Freemyer
On Thu, 24 Feb 2005 17:30:55 +0100, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > On Thursday 24 February 2005 17:10, Greg Freemyer wrote: > > I have generic question about HPA, not the patch. > > > > I have noticed with a SUSE 2.6.8 vendor kernel, the HPA behavior is > > not consistent. >

[PATCH libata-2.6] AHCI: print port ID not number

2005-02-24 Thread Brett Russ
The attached patch fixes the "ata#: error occurred, port reset" line to display the port id instead of the port number. Signed-off-by: Brett Russ <[EMAIL PROTECTED]> --- libata-2.6/drivers/scsi/ahci.c Thu Feb 24 14:18:35 2005 +++ libata-2.6-ahci-printk/drivers/scsi/ahci.c Thu Feb 24 14:21:4

Re: [PATCH libata-2.6] AHCI: print port ID not number

2005-02-24 Thread Jeff Garzik
Brett Russ wrote: The attached patch fixes the "ata#: error occurred, port reset" line to display the port id instead of the port number. Signed-off-by: Brett Russ <[EMAIL PROTECTED]> --- libata-2.6/drivers/scsi/ahci.c

[PATCH libata-2.6] AHCI: print port ID not number

2005-02-24 Thread Brett Russ
The attached patch fixes the "ata#: error occurred, port reset" line to display the port id instead of the port number. Signed-off-by: Brett Russ <[EMAIL PROTECTED]> --- libata-2.6/drivers/scsi/ahci.c Thu Feb 24 14:18:35 2005 +++ libata-2.6-ahci-printk/drivers/scsi/ahci.c Thu Feb 24 14:21:4

RE: libata-scsi.c: ata_scsi_simulate question

2005-02-24 Thread Winstel, Drew
> That's what the SCSI T10 SAT standard specifies. Thanks for the clarification. It's been far too long since I've looked at the T10 standards... Drew - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Re: [patch ide-dev 3/9] merge LBA28 and LBA48 Host Protected Area support code

2005-02-24 Thread Bartlomiej Zolnierkiewicz
On Thursday 24 February 2005 17:10, Greg Freemyer wrote: > I have generic question about HPA, not the patch. > > I have noticed with a SUSE 2.6.8 vendor kernel, the HPA behavior is > not consistent. Please retry with vanilla kernel. > ie. With exactly the same computer/controller, but with diffe

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-02-24 Thread Bartlomiej Zolnierkiewicz
On Thu, 10 Feb 2005 17:38:14 +0900 (KST), Tejun Heo <[EMAIL PROTECTED]> wrote: > > 01_ide_task_end_request_fix.patch > > task_end_request() modified to always call ide_end_drive_cmd() > for taskfile requests. Previously, ide_end_drive_cmd() was > called only when task->tf

Re: [patch ide-dev 3/9] merge LBA28 and LBA48 Host Protected Area support code

2005-02-24 Thread Greg Freemyer
I have generic question about HPA, not the patch. I have noticed with a SUSE 2.6.8 vendor kernel, the HPA behavior is not consistent. ie. With exactly the same computer/controller, but with different disk drives (models/manufacturers) the HPA behavior varies. In all my testing the HPA was always

Re: [PATCH 2.6.11-rc3 08/11] ide: remove REQ_DRIVE_TASK handling

2005-02-24 Thread Bartlomiej Zolnierkiewicz
> @@ -945,33 +931,7 @@ static ide_startstop_t execute_drive_cmd > if (args->tf_out_flags.all != 0) > return flagged_taskfile(drive, args); > return do_rw_taskfile(drive, args); > - } else if (rq->flags & REQ_DRIVE_TASK) { > -

Re: [PATCH 2.6.11-rc3 10/11] ide: make ide_cmd_ioctl() use TASKFILE

2005-02-24 Thread Bartlomiej Zolnierkiewicz
> + in_valid->b.status_command = 1; > + in_valid->b.error_feature = 1; > + in_valid->b.nsector = 1; ide_end_drive_cmd() must be fixed first to respect ->tf_in_flags and it must be done *without* affecting HDIO_DRIVE_TASKFILE. > extern int ide_driveid_upda

[patch ide-dev 3/9] merge LBA28 and LBA48 Host Protected Area support code

2005-02-24 Thread Bartlomiej Zolnierkiewicz
* merge idedisk_read_native_max_address() and idedisk_read_native_max_address_ext() * merge idedisk_set_max_address() and idedisk_set_max_address_ext() diff -Nru a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c --- a/drivers/ide/ide-disk.c2005-02-19 17:22:44 +01:00 +++ b/drivers/ide/ide-

Re: [PATCH 2.6.11+ sata_qstor] libata: sata_qstor cosmetic fixes

2005-02-24 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: Minor patch for new 2.6.xx sata_qstor driver attached, as per Alexey's fine-toothed comb! :) Signed-off-by: Mark Lord <[EMAIL PROTECTED]> I had to apply this manually, since your mailer "corrupts" the patch by encoding text/plain as base64. Please fix your mai

[patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-02-24 Thread Bartlomiej Zolnierkiewicz
ide_task_ioctl() rewritten to use taskfile transport. This is the last user of REQ_DRIVE_TASK. bart: ported to recent IDE changes by me Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> diff -Nru a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c --- a/drivers/ide/ide-taskfile.c2005-0

[patch ide-dev 9/9] remove unused REQ_DRIVE_TASK handling

2005-02-24 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> diff -Nru a/drivers/block/ll_rw_blk.c b/drivers/block/ll_rw_blk.c --- a/drivers/block/ll_rw_blk.c 2005-02-24 15:30:14 +01:00 +++ b/drivers/block/ll_rw_blk.c 2005-02-24 15:30:14 +01:00 @@ -851,7 +851,6 @@ "REQ_QUIET", "REQ_SPECIAL",

[patch ide-dev 7/9] convert disk flush functions to use REQ_DRIVE_TASKFILE

2005-02-24 Thread Bartlomiej Zolnierkiewicz
Original patch from Tejun Heo <[EMAIL PROTECTED]>, ported over recent IDE changes by me. * teach ide_tf_get_address() about CHS * use ide_tf_get_address() and remove ide_get_error_location() * use ide_task_init_flush() and remove ide_fill_flush_cmd() * convert idedisk_issue_flush() to use REQ_DRI

[patch ide-dev 1/9] use struct ata_taskfile in ide_task_t

2005-02-24 Thread Bartlomiej Zolnierkiewicz
* use struct ata_taskfile instead of .flags, .tfRegister[] and .hobRegister[] in ide_task_t * add #ifndef __KERNEL__ around definitions of {task,hob}_struct_t * don't set write-only .hobRegister[6] and .hobRegister[7] in idedisk_set_max_address_ext() * remove no longer needed IDE_CONTROL_OFFSE

[patch ide-dev 4/9] add ide_task_init_flush() helper

2005-02-24 Thread Bartlomiej Zolnierkiewicz
* add ide_task_init_flush() helper * use it in do_idedisk_cacheflush() and ide_start_power_step() * inline do_idedisk_cacheflush() into ide_cacheflush_p() diff -Nru a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c --- a/drivers/ide/ide-disk.c2005-02-19 17:22:58 +01:00 +++ b/drivers/ide/ide-d

[patch ide-dev 6/9] check capacity in ide_task_init_flush()

2005-02-24 Thread Bartlomiej Zolnierkiewicz
Use WIN_FLUSH_CACHE_EXT only if disk requires LBA48. diff -Nru a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c --- a/drivers/ide/ide-io.c 2005-02-23 20:58:16 +01:00 +++ b/drivers/ide/ide-io.c 2005-02-23 20:58:16 +01:00 @@ -61,7 +61,8 @@ memset(task, 0, sizeof(*task)); - if

[patch ide-dev 2/9] add ide_tf_get_address() helper

2005-02-24 Thread Bartlomiej Zolnierkiewicz
* add ide_tf_get_address() helper * use it in idedisk_read_native_max_address[_ext]() and idedisk_set_max_address[_ext]() diff -Nru a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c --- a/drivers/ide/ide-disk.c2005-02-19 17:22:32 +01:00 +++ b/drivers/ide/ide-disk.c2005-02-19 17:22:32 +0

[patch ide-dev 5/9] fix setting LBA bit in Device register for REQ_DRIVE_TASKFILE

2005-02-24 Thread Bartlomiej Zolnierkiewicz
Don't set LBA bit in Device register for the following cases: * Power Management requests (WIN_FLUSH_CACHE[_EXT], WIN_STANDBYNOW1, WIN_IDLEIMMEDIATE commands) * special commands (WIN_SPECIFY, WIN_RESTORE, WIN_SETMULT) * /proc/ide/ SMART support (WIN_SMART with SMART_ENABLE, SMART_READ_VALUES

[RFT PATCH] PCI MSI support for AHCI SATA driver

2005-02-24 Thread Jeff Garzik
Any testers wanna give this a shot? Testing should be easy: (a) make sure it still works. (b) cat /proc/interrupts to make sure that MSI is truly activated. Patch against 2.6.11-rc5. diff -Nru a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c --- a/drivers/scsi/ahci.c 2005-02-24 07:00:45 -05:00 ++

[BK PATCHES] ide-2.6 update

2005-02-24 Thread Bartlomiej Zolnierkiewicz
Hi Linus, Please do a bk pull bk://bart.bkbits.net/ide-2.6 This will update the following files: drivers/ide/ide-disk.c | 10 -- drivers/ide/ide-io.c |4 ++-- drivers/ide/pci/hpt366.c | 29 +++-- include/linux/ide.h |7 +++ 4

Re: [PATCH] ide: make 1-bit fields unsigned

2005-02-24 Thread Bartlomiej Zolnierkiewicz
thanks, applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html