Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-01 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: Yes but it seems that you've assumed that ioctl == flagged taskfile and fs/internal == normal taskfile which is _not_ what I aim for. I want fully-flagged taskfile handling like flagged_taskfile() and "hot path" simpler taskfile handling like do_rw_taskfile() (at le

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-01 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: If somebody implements SG_IO ioctl and SCSI command pass-through from libata for IDE driver (and add possibility for discrete taskfiles), we can just deprecate HDIO_DRIVE_TASKFILE, forget about it and some time later remove this FPOS. Can you explain what you mean b

Re: PCI Constants Update for SATA Driver

2005-03-01 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: On Sun, 2005-02-27 at 13:08 -0500, Jeff Garzik wrote: Henning Schmiedehausen wrote: Hi, having the various constants in pci_ids.h is a really good thing for grepping through the kernel source. And if they were used, it would be even better (if you e.g. are looking for

[SATA] libata-dev queue updated

2005-03-01 Thread Jeff Garzik
A minor update, mostly to update to the latest kernel. BK users: bk pull bk://gkernel.bkbits.net/libata-dev-2.6 Patch: http://www.kernel.org/pub/linux/kernel/people/jgarzik/libata/2.6.11-rc5-bk4-libata-dev1.patch.bz2 This will update the following files: drivers/scsi/Kconfig |

Re: PCI Constants Update for SATA Driver

2005-03-01 Thread Benjamin Herrenschmidt
On Sun, 2005-02-27 at 13:08 -0500, Jeff Garzik wrote: > Henning Schmiedehausen wrote: > > Hi, > > > > having the various constants in pci_ids.h is a really good thing for > > grepping through the kernel source. And if they were used, it would be > > even better (if you e.g. are looking for which d

Re: PCI Constants Update for SATA Driver

2005-03-01 Thread Benjamin Herrenschmidt
On Sun, 2005-02-27 at 18:42 +0100, Henning Schmiedehausen wrote: static struct pci_device_id k2_sata_pci_tbl[] = { - { 0x1166, 0x0240, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, - { 0x1166, 0x0241, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, - { 0x1166, 0x0242, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },

Re: data_xfer too fast? - SATA PIO

2005-03-01 Thread Benjamin Herrenschmidt
On Mon, 2005-02-28 at 15:39 -0800, Mat Loikkanen wrote: > We've run into the issue of ata_mmio_data_xfer() reading our host > controller's data fifo too fast -- requesting a data word when the fifo was > empty, before the device had sent PIO data (in our observed case somewhere > in the middle of a

SATA Plugfest

2005-03-01 Thread Mat Loikkanen
Thought I'd pass along our experience at the SATA Plugfest in Milpitas, CA, recently. The Plugfest was a 2 1/2 day event where some companies roamed with their devices, plugging into host controllers from other companies who stayed put in their hotel suites. The days were scheduled with 1-hour ti

RE: data_xfer too fast? - SATA PIO

2005-03-01 Thread Mat Loikkanen
Thanks, Mark. I think the hardware designer plans to do this -- add wait states on the bus (we sell soft IP, so our controller is on an FPGA on our test platform). I wasn't sure if there were any PCI/ISA-isms that were at play here. We are ARM AMBA/AHB bus based, targeting embedded applications.

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-01 Thread Tejun Heo
Hello, Bartlomiej. On Tue, Mar 01, 2005 at 03:30:32PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Sun, 27 Feb 2005 15:49:22 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > > > > Taskfile DMA path is still broken. Also calling ide_end_request() > > will work there, but IMHO it's just cleaner to

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-01 Thread Bartlomiej Zolnierkiewicz
On Sun, 27 Feb 2005 15:49:22 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > On Thu, Feb 24, 2005 at 04:58:03PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Thu, 10 Feb 2005 17:38:14 +0900 (KST), Tejun Heo <[EMAIL PROTECTED]> > > wrote: > > > > > > 01_ide_task_end_request_fix.patch > > > > > >

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-01 Thread Bartlomiej Zolnierkiewicz
On Tue, 1 Mar 2005 18:29:15 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, > > On Tue, Mar 01, 2005 at 09:42:18AM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hello, > > > > On Tue, 1 Mar 2005 13:21:16 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > > > > > > So, how do you like the following

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-01 Thread Tejun Heo
Hello, On Tue, Mar 01, 2005 at 09:42:18AM +0100, Bartlomiej Zolnierkiewicz wrote: > Hello, > > On Tue, 1 Mar 2005 13:21:16 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > > > > So, how do you like the following set of TFLAG's? > > > > /* struct ata_taskfile flags */ > > > > /* The following si

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-01 Thread Bartlomiej Zolnierkiewicz
Hello, On Tue, 1 Mar 2005 13:21:16 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, Bartlomiej. > Hello, Jeff. > > On Mon, Feb 28, 2005 at 05:14:55PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Monday 28 February 2005 16:24, Tejun Heo wrote: > > > Bartlomiej Zolnierkiewicz wrote: > > > > >