Re: [RFC] libata debugging

2005-08-27 Thread Borislav Petkov
HI Jeff, another question: unsigned int ata_dev_classify(struct ata_taskfile *tf) in drivers/scsi/libata-core.c doesn't have access to an ata_port struct and it thus cannot be converted to the new ata_msg_xxx usage. However, this function has only two users which both have ata_port defined in

[PATCH] libata: scsi error handling

2005-08-27 Thread Douglas Gilbert
Jeff, Here is a follow on patch based on lk 2.6.13-rc7 plus the start_stop_unit patch and the rw_zero_length patch. It adds more general error processing, typically for problems (or an early finish) detected while a SCSI command is being processed prior to an ATA command being executed. Changelog

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-27 Thread Yani Ioannou
Hi Pavel, On 8/27/05, Pavel Machek <[EMAIL PROTECTED]> wrote: > Well, with my power-managment hat on: > > we probably want "freeze" functionality to be generic; it makes sense > for other devices, too. > > "My battery is so low I can not use wifi any more" => userspace > freezes wifi. > > Now,

[RFC] current libata eh doc

2005-08-27 Thread Tejun Heo
Hello, libata developers. This document describes current libata EH. (I have decided to keep ATA exceptions doc, this and yet-to-be-posted new EH doc separate.) I hope this can help EH discussion. libata EH == This document describes how errors are handl

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-27 Thread Pavel Machek
Hi! > > > Please make the interface accept number of seconds (as suggested by Jens) > > > and remove this module parameter. This way interface will be more flexible > > > and cleaner. I really don't see any advantage in doing "echo 1 > ..." > > > instead > > > of "echo x > ..." (Pavel, please ex

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-27 Thread Jens Axboe
On Sat, Aug 27 2005, Jeff Garzik wrote: > Here is the patch I just checked in. Looks perfect. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-27 Thread Jeff Garzik
Here is the patch I just checked in. Jeff diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c --- a/drivers/scsi/libata-scsi.c +++ b/drivers/scsi/libata-scsi.c @@ -630,11 +630,19 @@ static unsigned int ata_scsi_rw_xlat(str tf->lbah = scsicmd[3];

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-27 Thread Jens Axboe
On Sat, Aug 27 2005, Douglas Gilbert wrote: > Jeff Garzik wrote: > > Does the attached look OK to everybody? > > > > Jeff, > Yes. > > And after an exchange with Jens, it would probably be > safer to map transfer_length=0 for READ_10 and READ_16 > (as well as WRITE_10 and WRITE_16) to a nop on th