[PATCH 11/13] libata: remove unused functions

2007-01-09 Thread Tejun Heo
Now that all LLDs are converted to use devres, default stop callbacks are unused. Remove them. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c | 81 +++- include/linux/libata.h|4 -- 2 files changed, 6 insertions(+), 79

Re: SATA Promise

2007-01-09 Thread Mikael Pettersson
On Mon, 08 Jan 2007 10:06:49 -0700, Gary Thomas wrote: > > Yes. SATAPI and PATAPI are working. Patches have been posted > > to linux-ide, and hopefully final combined/reworked/tidied-up > > patches should be available tomorrow. > > Very nice, thanks. > > BTW, what SATAPI drive did you try this wi

Re: [PATCH] ata_piix: add ICH7 on Acer 3682WLMi to laptop list

2007-01-09 Thread Jeff Garzik
Tejun Heo wrote: From: J J <[EMAIL PROTECTED]> In Acer Aspire hdd is connected to ICH7 via 40c cable, however it is short cable and it is UDMA66 capable. Signed-off-by: J J <[EMAIL PROTECTED]> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the lin

Re: [PATCH] pata_sis: implement laptop list and add ASUS A6K/A6U

2007-01-09 Thread Jeff Garzik
Tejun Heo wrote: From: Jakub W. Jozwicki J <[EMAIL PROTECTED]> In ASUS A6K/A6U hdd is connected to SiS 96x via 40c cable, however it is short cable and is UDMA66 capable. tj: fixed if () conditionals ah: fixed infinite loop Signed-off-by: Jakub W. Jozwicki <[EMAIL PROTECTED]> Cc: Andreas Henri

Re: [PATCH 1/3] libata: straighten out ATA_ID_* constants

2007-01-09 Thread Jeff Garzik
Tejun Heo wrote: * Kill _OFS suffixes in ATA_ID_{SERNO|FW_REV|PROD}_OFS for consistency with other ATA_ID_* constants. * Kill ATA_SERNO_LEN * Add and use ATA_ID_SERNO_LEN, ATA_ID_FW_REV_LEN and ATA_ID_PROD_LEN. This change also makes ata_device_blacklisted() use proper length for fwrev.

Re: [PATCH] libata: handle pci_enable_device() failure while resuming

2007-01-09 Thread Jeff Garzik
Tejun Heo wrote: Handle pci_enable_device() failure while resuming. This patch kills the "ignoring return value of 'pci_enable_device'" warning message and propagates __must_check through ata_pci_device_do_resume(). Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/ahci.c|

Re: libata-dev.git rebased

2007-01-09 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: Jeff, Here's my rebased patch. Let me know if there's a problem with it. applied (again), thanks for your patience - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vge

Re: DMA errors with HTP370 IDE in <= 2.6.18.2

2007-01-09 Thread Sergei Shtylyov
Michael Bueker wrote: > In the controller's setup utility, I can choose access modes. If i switch it from UDMA5 to PIO0, the only difference during boot is: PIO0 is outrageously slow, use PIO4 (very slow as well but at least somewhat faster). Anyway, this won't help with Linux... ide2

Re: ICH7m problem using libata

2007-01-09 Thread Matthew Stapleton
Tejun Heo wrote: > Can you try the attached patch over 2.6.19 and report full dmesg? Thanks. > > -- > tejun > Attached is my full dmesg. -- Matthew Stapleton Linux version 2.6.19-gentoo-r3 ([EMAIL PROTECTED]) (gcc version 4.1.1 (Gentoo 4.1.1-r3)) #1 SMP PREEMPT Sun Jan 7 14:13:35 EST 2007 BI

ICH6-M libata disk timeouts 2.6.18 -> 2.6.19

2007-01-09 Thread Mike Accetta
We have a system with an ICH6-M controller and two SATA drives configured for software RAID1. Under 2.6.18, adding the second drive to the array and starting a re-sync would go to completion without incident. Under 2.6.19, adding the second drive will always eventually generate what appear to be ti

Re: No DMA with HTP370 IDE controller

2007-01-09 Thread Michael Bueker
Bartlomiej Zolnierkiewicz wrote: Have you looked at changes to drivers/ide/pci/hpt366.c? The code is not the same, there are a lot of fixes in -mm: hpt3xx-rework-rate-filtering.patch hpt3xx-rework-rate-filtering-tidy.patch hpt3xx-print-the-real-chip-name-at-startup.patch hpt3xx-switch-to-using-p

Re: ICH6-M libata disk timeouts 2.6.18 -> 2.6.19

2007-01-09 Thread Mike Accetta
Here's a bit more information on these timeouts. I noticed a mention of changing the command queue depth in a recent lkml post and decided to give that a whirl. This problem seems to be related to the depth of the queue. When I set the value for /sys/block/sdb/device/queue_depth to 4 the raid1

[PATCH 2.6.20-rc4 1/2] sata_promise: TX2plus PATA support

2007-01-09 Thread Mikael Pettersson
This patch implements a simple way of setting up per-port flags on the SATA+PATA Promise TX2plus chips, which is a prerequisite for supporting the PATA port on those chips. It is based on the observation that ap->flags isn't really used until after ->port_start() has been invoked. So it places the

[PATCH 2.6.20-rc4 2/2] sata_promise: ATAPI support

2007-01-09 Thread Mikael Pettersson
This patch adds ATAPI support to the sata_promise driver. This has been tested on both first- and second-generation chips (20378 and 20575), and with both SATAPI and PATAPI devices. CD-writing works. SATAPI DMA works on second-generation chips, but on first-generation chips SATAPI is limited to PI

Re: [PATCH 2.6.20-rc4 1/2] sata_promise: TX2plus PATA support

2007-01-09 Thread Jeff Garzik
Mikael Pettersson wrote: This patch implements a simple way of setting up per-port flags on the SATA+PATA Promise TX2plus chips, which is a prerequisite for supporting the PATA port on those chips. It is based on the observation that ap->flags isn't really used until after ->port_start() has bee

Re: [PATCH 2.6.20-rc4 1/2] sata_promise: TX2plus PATA support

2007-01-09 Thread Jeff Garzik
Mikael Pettersson wrote: @@ -271,6 +272,11 @@ static int pdc_port_start(struct ata_por struct pdc_port_priv *pp; int rc; + /* fix up port flags and cable type for SATA+PATA chips */ + ap->flags |= hp->port_flags[ap->port_no]; + if (ap->flags & ATA_FLAG_SATA) +

Re: [PATCH 2.6.20-rc4 2/2] sata_promise: ATAPI support

2007-01-09 Thread Jeff Garzik
Mikael Pettersson wrote: + for(i = 0; i < 1000; ++i) { + status = readb(port_mmio + 0x38); /* altstatus */ magic number (0x38) + if (status == 0xFF) + break; + if (status & ATA_BUSY) + ; +

Re: [PATCH] sata_nv: add suspend/resume support v3 (Resubmit)

2007-01-09 Thread Jeff Garzik
Robert Hancock wrote: Thoughts from Jeff & company on merging the patch below into libata-dev? This has been in the -mm tree for over a month now, I haven't heard any complaints about regressions.. --- From: Robert Hancock <[EMAIL PROTECTED]> This patch adds the necessary callbacks to suppor

Re: [2.6 patch] drivers/ata/: make 4 functions static

2007-01-09 Thread Jeff Garzik
Adrian Bunk wrote: This patch makes the following needlessly global functions static: - libata-core.c: ata_qc_complete_internal() - libata-scsi.c: ata_scsi_qc_new() - libata-scsi.c: ata_dump_status() - libata-scsi.c: ata_to_sense_error() Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> applied

Re: [PATCH 1/3] atiixp.c: remove unused code

2007-01-09 Thread Conke Hu
On 1/7/07, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: On 1/6/07, Conke Hu <[EMAIL PROTECTED]> wrote: > A previous patch to atiixp.c was removed but some code has not been This one? http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ab17443a3df35abe4b7529e8

Re: [PATCH 2/3] atiixp.c: sb600 ide only has one channel

2007-01-09 Thread Conke Hu
On 1/7/07, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: On 1/6/07, Conke Hu <[EMAIL PROTECTED]> wrote: > AMD/ATI SB600 IDE/PATA controller only has one channel. > > Signed-off-by: Conke Hu <[EMAIL PROTECTED]> Acked-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> [ but the patch is lin

Re: [PATCH 3/3] atiixp.c: add cable detection support for ATI IDE

2007-01-09 Thread Conke Hu
On 1/7/07, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: On 1/6/07, Conke Hu <[EMAIL PROTECTED]> wrote: > IDE HDD does not work if it uses a 40-pin PATA cable on ATI chipset. > This patch fixes the bug. > > Signed-off-by: Conke Hu <[EMAIL PROTECTED]> Acked-by: Bartlomiej Zolnierkiewicz <[

Re: [PATCH 3/3] atiixp.c: add cable detection support for ATI IDE

2007-01-09 Thread Jeff Garzik
Conke Hu wrote: --- linux-2.6.20-rc4/drivers/ide/pci/atiixp.c.32007-01-09 15:37:42.0 +0800 +++ linux-2.6.20-rc4/drivers/ide/pci/atiixp.c2007-01-09 15:40:08.0 +0800 @@ -291,8 +291,12 @@ fast_ata_pio: Your patches are still getting word-wrapped...

Re: [PATCH 3/3] atiixp.c: add cable detection support for ATI IDE

2007-01-09 Thread Bartlomiej Zolnierkiewicz
The good news is that it doesn't matter now as Andrew fixed Conke's patches manually and applied them to -mm [ but without my Acked-by-s :( ]. On 1/9/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Conke Hu wrote: > > --- linux-2.6.20-rc4/drivers/ide/pci/atiixp.c.32007-01

Re: [PATCH 1/3] atiixp.c: remove unused code

2007-01-09 Thread Bartlomiej Zolnierkiewicz
On 1/9/07, Conke Hu <[EMAIL PROTECTED]> wrote: On 1/7/07, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > On 1/6/07, Conke Hu <[EMAIL PROTECTED]> wrote: > > A previous patch to atiixp.c was removed but some code has not been > > This one? > > http://kernel.org/git/?p=linux/kernel/git/torv

Re: [PATCH 3/3] atiixp.c: add cable detection support for ATI IDE

2007-01-09 Thread Andrew Morton
On Tue, 9 Jan 2007 14:54:01 +0100 "Bartlomiej Zolnierkiewicz" <[EMAIL PROTECTED]> wrote: > The good news is that it doesn't matter now as Andrew fixed Conke's patches > manually and applied them to -mm I applied three pathces, but there's been such a storm of inadequately changelogged mangled pat

Re: [PATCH 3/3] atiixp.c: add cable detection support for ATI IDE

2007-01-09 Thread Conke Hu
On 1/10/07, Andrew Morton <[EMAIL PROTECTED]> wrote: Here are the three patches. Conke, can you please tell us whether this is all correct and complete? From: "Conke Hu" <[EMAIL PROTECTED]> A previous patch to atiixp.c was removed but some code has not been cleaned. Now we remove these code s

Re: [PATCH] SCSI: Add the SGPIO support for sata_nv.c

2007-01-09 Thread Robert Hancock
Since I've been the one making the most changes in sata_nv lately I figured I would make some more comments on this patch: Subject: RE: [PATCH] SCSI: Add the SGPIO support for sata_nv.c From: "Peer Chen" <[EMAIL PROTECTED]> Date: Tue, 7 Nov 2006 17:55:11 +0800 To: "Christoph Hellwig" <[EMAIL PRO

[PATCHSET] Managed device resources, take #2

2007-01-09 Thread Tejun Heo
Hello, This is the second take of devres patchset. Changes from the last take[L] are... * generic managed iomap interface functions implemented - devm_ioport_map/unmap() - devm_ioremap[_nocache](), devm_iounmap() * libata-sff legacy mode now uses generic managed iomap interface

[PATCH 4/13] devres: implement managed DMA interface

2007-01-09 Thread Tejun Heo
Implement managed DMA interface - dmam_alloc_coherent(), dmam_free_coherent(), dmam_declare_coherent_memory(), dmam_pool_create() and dmam_pool_destroy(). Except for being managed, these take the same arguments and have the same effect as non-managed counterparts. Signed-off-by: Tejun Heo <[EMAIL

[PATCH 6/13] devres: implement managed iomap interface

2007-01-09 Thread Tejun Heo
Implement managed iomap interface - devm_ioport_map(), devm_ioport_unmap(), devm_ioremap(), devm_ioremap_nocache(), devm_iounmap(), pcim_iomap_table(), pcim_iomap() and pcim_iounmap(). Except for being managed and additional gendev argument, these functions take the same arguments and have the same

[PATCH 3/13] devres: implement managed IRQ interface

2007-01-09 Thread Tejun Heo
Implement managed IRQ interface - devm_request_irq() and devm_free_irq(). Except for the first @dev argument and being managed, these take the same arguments and have the same effect as non-managed coutnerparts. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- include/linux/interrupt.h |6 ++

[PATCH 9/13] libata: update libata core layer to use devres

2007-01-09 Thread Tejun Heo
Update libata core layer to use devres. * ata_device_add() acquires all resources in managed mode. * ata_host is allocated as devres associated with ata_host_release. * Port attached status is handled as devres associated with ata_host_attach_release(). * Initialization failure and host remov

[PATCH 2/13] devres: implement managed IO region interface

2007-01-09 Thread Tejun Heo
Implement managed IO region interface - devm_request_region() and devm_release_region(). Except for the first @dev argument and being managed, these take the same arguments and have the same effect as non-managed coutnerparts. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- include/linux/ioport

[PATCH 7/13] devres: add Documentation/driver-model/devres.txt

2007-01-09 Thread Tejun Heo
Add Documentation/driver-model/drvres.txt. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- Documentation/driver-model/devres.txt | 268 + 1 files changed, 268 insertions(+), 0 deletions(-) diff --git a/Documentation/driver-model/devres.txt b/Documentation/drive

[PATCH 5/13] devres: implement managed PCI interface

2007-01-09 Thread Tejun Heo
Implement managed PCI interface - pcim_enable_device(), pcim_pin_device() and pci_is_managed(). pcim_enable_device() is equivalent to pci_enable_device() except that it makes the PCI device managed. After pcim_enable_device(), PCI resources such as enabledness, msi/msix/intx status and BAR region

[PATCH 12/13] devres: implement pcim_iomap_regions()

2007-01-09 Thread Tejun Heo
Implement pcim_iomap_regions(). This function takes mask of BARs to request and iomap. No BAR should have length of zero. BARs are iomapped using pcim_iomap_table(). Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- include/linux/io.h |2 + lib/iomap.c| 53

[PATCH 8/13] libata: implement ata_host_detach()

2007-01-09 Thread Tejun Heo
Implement ata_host_detach() which calls ata_port_detach() for each port in the host and export it. ata_port_detach() is now internal and thus un-exported. ata_host_detach() will be used as the 'deregister from libata layer' function after devres conversion. Signed-off-by: Tejun Heo <[EMAIL PROTE

[PATCH 1/13] devres: device resource management core

2007-01-09 Thread Tejun Heo
Implement device resource management core, in short, devres. A device driver can allocate arbirary size of devres data which is associated with a release function. On driver detach, release function is invoked on the devres data, then, devres data is freed. devreses are typed by associated relea